2022-04-11 02:29:24

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH v2] remoteproc: mtk_scp: Fix a potential double free

'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need
to free it explicitly in the remove function.

Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()")
Signed-off-by: Christophe JAILLET <[email protected]>
---
v1 -> v2:
- add missing Signed-off-by
---
drivers/remoteproc/mtk_scp.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 38609153bf64..4a0e6c4bc6f4 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -877,7 +877,6 @@ static int scp_remove(struct platform_device *pdev)
for (i = 0; i < SCP_IPI_MAX; i++)
mutex_destroy(&scp->ipi_desc[i].lock);
mutex_destroy(&scp->send_lock);
- rproc_free(scp->rproc);

return 0;
}
--
2.32.0


Subject: Re: [PATCH v2] remoteproc: mtk_scp: Fix a potential double free

Il 09/04/22 08:27, Christophe JAILLET ha scritto:
> 'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need
> to free it explicitly in the remove function.
>
> Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()")
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2022-04-12 19:45:17

by Mathieu Poirier

[permalink] [raw]
Subject: Re: [PATCH v2] remoteproc: mtk_scp: Fix a potential double free

On Mon, Apr 11, 2022 at 10:55:52AM +0200, AngeloGioacchino Del Regno wrote:
> Il 09/04/22 08:27, Christophe JAILLET ha scritto:
> > 'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need
> > to free it explicitly in the remove function.
> >
> > Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()")
> > Signed-off-by: Christophe JAILLET <[email protected]>
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Applied.

Thanks,
Mathieu

>
>