2020-01-13 07:05:11

by Wei Yang

Subject: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

No functional change, just leverage the helper function to improve
readability as others.

Signed-off-by: Wei Yang <[email protected]>
---
mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index 7646bf993b25..7705929cc920 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
pmdval = READ_ONCE(*pmd);
if (pmd_none(pmdval))
return no_page_table(vma, flags);
- if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
+ if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
page = follow_huge_pmd(mm, address, pmd, flags);
if (page)
return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
pud = pud_offset(p4dp, address);
if (pud_none(*pud))
return no_page_table(vma, flags);
- if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
+ if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
page = follow_huge_pud(mm, address, pud, flags);
if (page)
return page;
--
2.17.1

2020-01-13 13:23:20

by Vlastimil Babka

Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

On 1/13/20 8:03 AM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
>
> Signed-off-by: Wei Yang <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>

> ---
> mm/gup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
> pmdval = READ_ONCE(*pmd);
> if (pmd_none(pmdval))
> return no_page_table(vma, flags);
> - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pmd(mm, address, pmd, flags);
> if (page)
> return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
> pud = pud_offset(p4dp, address);
> if (pud_none(*pud))
> return no_page_table(vma, flags);
> - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pud(mm, address, pud, flags);
> if (page)
> return page;
>

2020-01-13 21:05:54

by David Rientjes

Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

On Mon, 13 Jan 2020, Wei Yang wrote:

> No functional change, just leverage the helper function to improve
> readability as others.
>
> Signed-off-by: Wei Yang <[email protected]>

Acked-by: David Rientjes <[email protected]>

2020-01-14 19:09:39

by Ralph Campbell

Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

On 1/12/20 11:03 PM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
>
> Signed-off-by: Wei Yang <[email protected]>

I had thought about doing this same thing. :-)
Reviewed-by: Ralph Campbell <[email protected]>

> ---
> mm/gup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
> pmdval = READ_ONCE(*pmd);
> if (pmd_none(pmdval))
> return no_page_table(vma, flags);
> - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pmd(mm, address, pmd, flags);
> if (page)
> return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
> pud = pud_offset(p4dp, address);
> if (pud_none(*pud))
> return no_page_table(vma, flags);
> - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pud(mm, address, pud, flags);
> if (page)
> return page;
>

2020-01-15 01:53:17

by Wei Yang

Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

On Tue, Jan 14, 2020 at 11:07:03AM -0800, Ralph Campbell wrote:
>
>On 1/12/20 11:03 PM, Wei Yang wrote:
>> No functional change, just leverage the helper function to improve
>> readability as others.
>>
>> Signed-off-by: Wei Yang <[email protected]>
>
>I had thought about doing this same thing. :-)

Ah, in Chinese, there is a saying: Heroes see the same :-)

>Reviewed-by: Ralph Campbell <[email protected]>
>
>> ---
>> mm/gup.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/gup.c b/mm/gup.c
>> index 7646bf993b25..7705929cc920 100644
>> --- a/mm/gup.c
>> +++ b/mm/gup.c
>> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
>> pmdval = READ_ONCE(*pmd);
>> if (pmd_none(pmdval))
>> return no_page_table(vma, flags);
>> - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
>> + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
>> page = follow_huge_pmd(mm, address, pmd, flags);
>> if (page)
>> return page;
>> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
>> pud = pud_offset(p4dp, address);
>> if (pud_none(*pud))
>> return no_page_table(vma, flags);
>> - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
>> + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
>> page = follow_huge_pud(mm, address, pud, flags);
>> if (page)
>> return page;
>>

--
Wei Yang
Help you, Help me