2020-08-29 10:37:53

by Yi Li

Subject: [PATCH] bnx2x: correct a mistake when show error code

use rc for error code.

Signed-off-by: Yi Li <[email protected]>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
index 1426c691c7c4..0346771396ce 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
@@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x *bp, u32 shmem_base_path[],
}

if (rc)
- netdev_err(bp->dev, "Warning: PHY was not initialized,"
- " Port %d\n",
- 0);
+ netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
+ rc);
return rc;
}

--
2.25.3

2020-08-29 11:01:51

by Yi Li

Subject: Re: [PATCH] bnx2x: correct a mistake when show error code

It is useless.
The original code just tell some error info. and don't show errorcode

On 8/29/20, Yi Li <[email protected]> wrote:
> use rc for error code.
>
> Signed-off-by: Yi Li <[email protected]>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x
> *bp, u32 shmem_base_path[],
> }
>
> if (rc)
> - netdev_err(bp->dev, "Warning: PHY was not initialized,"
> - " Port %d\n",
> - 0);
> + netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> + rc);
> return rc;
> }
>
> --
> 2.25.3
>
>
>
>

2020-08-30 07:59:23

by Igor Russkikh

Subject: Re: [EXT] [PATCH] bnx2x: correct a mistake when show error code

> drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x
> *bp, u32 shmem_base_path[],
> }
>
> if (rc)
> - netdev_err(bp->dev, "Warning: PHY was not initialized,"
> - " Port %d\n",
> - 0);
> + netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> + rc);
> return rc;

Hi Yi,

Thanks, but if you want to report rc in this trace - then state "rc = %d"
explicitly in the string. Because now its "Port %d" but you put error code in
there...

Thanks,
Igor