2020-01-21 01:42:01

by chenzhou

Subject: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

Fixes coccicheck warning:

./drivers/net/ethernet/amd/declance.c:611:14-15:
WARNING comparing pointer to 0

Compare pointer-typed values to NULL rather than 0.

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/ethernet/amd/declance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 6592a2d..7282ce5 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c
@@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
skb = netdev_alloc_skb(dev, len + 2);

- if (skb == 0) {
+ if (!skb) {
dev->stats.rx_dropped++;
*rds_ptr(rd, mblength, lp->type) = 0;
*rds_ptr(rd, rmd1, lp->type) =
--
2.7.4

2020-01-21 08:40:45

by Sergei Shtylyov

Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

Hello!

On 21.01.2020 4:35, Chen Zhou wrote:

> Fixes coccicheck warning:
>
> ./drivers/net/ethernet/amd/declance.c:611:14-15:
> WARNING comparing pointer to 0
>
> Compare pointer-typed values to NULL rather than 0.

I don't see NULL in the patch -- you used ! instead.

> Signed-off-by: Chen Zhou <[email protected]>
> ---
> drivers/net/ethernet/amd/declance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
> index 6592a2d..7282ce5 100644
> --- a/drivers/net/ethernet/amd/declance.c
> +++ b/drivers/net/ethernet/amd/declance.c
> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
> len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
> skb = netdev_alloc_skb(dev, len + 2);
>
> - if (skb == 0) {
> + if (!skb) {
> dev->stats.rx_dropped++;
> *rds_ptr(rd, mblength, lp->type) = 0;
> *rds_ptr(rd, rmd1, lp->type) =

MBR, Sergei

2020-01-21 08:55:30

by chenzhou

Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

Hi Sergei,

On 2020/1/21 16:39, Sergei Shtylyov wrote:
> Hello!
>
> On 21.01.2020 4:35, Chen Zhou wrote:
>
>> Fixes coccicheck warning:
>>
>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>> WARNING comparing pointer to 0
>>
>> Compare pointer-typed values to NULL rather than 0.
>
> I don't see NULL in the patch -- you used ! instead.

Yeah, i used ! here.

Thanks,
Chen Zhou

>
>> Signed-off-by: Chen Zhou <[email protected]>
>> ---
>> drivers/net/ethernet/amd/declance.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
>> index 6592a2d..7282ce5 100644
>> --- a/drivers/net/ethernet/amd/declance.c
>> +++ b/drivers/net/ethernet/amd/declance.c
>> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
>> len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
>> skb = netdev_alloc_skb(dev, len + 2);
>> - if (skb == 0) {
>> + if (!skb) {
>> dev->stats.rx_dropped++;
>> *rds_ptr(rd, mblength, lp->type) = 0;
>> *rds_ptr(rd, rmd1, lp->type) =
>
> MBR, Sergei
>
>

2020-01-21 09:04:13

by Sergei Shtylyov

Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

On 21.01.2020 11:54, Chen Zhou wrote:

>>> Fixes coccicheck warning:
>>>
>>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>>> WARNING comparing pointer to 0
>>>
>>> Compare pointer-typed values to NULL rather than 0.
>>
>> I don't see NULL in the patch -- you used ! instead.
>
> Yeah, i used ! here.

Make the patch description match the diff, please.

> Thanks,
> Chen Zhou

MBR, Sergei

2020-01-21 09:21:04

by chenzhou

Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

On 2020/1/21 17:01, Sergei Shtylyov wrote:
> On 21.01.2020 11:54, Chen Zhou wrote:
>
>>>> Fixes coccicheck warning:
>>>>
>>>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>>>> WARNING comparing pointer to 0
>>>>
>>>> Compare pointer-typed values to NULL rather than 0.
>>>
>>> I don't see NULL in the patch -- you used ! instead.
>>
>> Yeah, i used ! here.
>
> Make the patch description match the diff, please.

ok, i will fix this in next version.

Thanks,
Chen Zhou

>
>> Thanks,
>> Chen Zhou
>
> MBR, Sergei
>
>