2006-11-08 09:55:00

by Andrew Morton

[permalink] [raw]
Subject: 2.6.19-rc5-mm1


Temporarily at

http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/

will turn up at

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/

when kernel.org mirroring catches up.



- Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
userspace tools, instructions, etc.

It needs a recent binutils to build.

- The hrtimer+dynticks code still doesn't work right for machines which halt
their TSC in low-power states.




Boilerplate:

- See the `hot-fixes' directory for any important updates to this patchset.

- To fetch an -mm tree using git, use (for example)

git-fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git tag v2.6.16-rc2-mm1
git-checkout -b local-v2.6.16-rc2-mm1 v2.6.16-rc2-mm1

- -mm kernel commit activity can be reviewed by subscribing to the
mm-commits mailing list.

echo "subscribe mm-commits" | mail [email protected]

- If you hit a bug in -mm and it is not obvious which patch caused it, it is
most valuable if you can perform a bisection search to identify which patch
introduced the bug. Instructions for this process are at

http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt

But beware that this process takes some time (around ten rebuilds and
reboots), so consider reporting the bug first and if we cannot immediately
identify the faulty patch, then perform the bisection search.

- When reporting bugs, please try to Cc: the relevant maintainer and mailing
list on any email.

- When reporting bugs in this kernel via email, please also rewrite the
email Subject: in some manner to reflect the nature of the bug. Some
developers filter by Subject: when looking for messages to read.

- Semi-daily snapshots of the -mm lineup are uploaded to
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ and are announced on
the mm-commits list.




Changes since 2.6.19-rc4-mm2:


git-acpi.patch
git-alsa.patch
git-agpgart.patch
git-cifs.patch
git-cpufreq.patch
git-drm.patch
git-dvb.patch
git-gfs2-nmw.patch
git-ia64.patch
git-ieee1394.patch
git-infiniband.patch
git-input.patch
git-libata-all.patch
git-mips.patch
git-mmc.patch
git-mtd.patch
git-netdev-all.patch
git-net.patch
git-ioat.patch
git-ocfs2.patch
git-pcmcia.patch
git-powerpc.patch
git-r8169.patch
git-pciseg.patch
git-s390.patch
git-scsi-misc.patch
git-scsi-target.patch
git-sas.patch
git-qla3xxx.patch
git-watchdog.patch
git-wireless.patch
git-cryptodev.patch
git-gccbug.patch

git trees.

-ecryptfs-cipher-code-to-new-crypto-api-fix.patch
-md-check-bio-address-after-mapping-through-partitions-tidy.patch
-md-send-online-offline-uevents-when-an-md-array-starts-stops.patch
-sys_pselect7-vs-compat_sys_pselect7-uaccess-error-handling.patch
-update-some-docbook-comments.patch
-docbook-merge-journal-api-into-filesystemstmpl.patch
-fix-ipc-entries-removal.patch
-un-needed-add-store-operation-wastes-a-few-bytes.patch
-fix-ufs-superblock-alignment-issues.patch
-lkdtm-cleanup-headers-and-module_param-module_parm_desc.patch
-cleanup-read_pages.patch
-cifs-readpages-fixes.patch
-fuse-readpages-cleanup.patch
-gfs2-readpages-fixes.patch
-edac_mc-fix-error-handling.patch
-nfs4-fix-for-recursive-locking-problem.patch
-ipmi_si_intfc-sets-bad-class_mask-with-pci_device_class.patch
-init_reap_node-initialization-fix.patch
-printk-timed-ratelimit.patch
-schedule-removal-of-futex_fd.patch
-acpi_noirq-section-fix.patch
-swsusp-debugging.patch
-swsusp-debugging-doc.patch
-spi-section-fix.patch
-reiserfs-reset-errval-after-initializing-bitmap-cache.patch
-usb-hub-build-fix.patch
-remove-hotplug-cpu-crap-from-cpufreq.patch
-uml-fix-i-o-hang.patch
-uml-include-tidying.patch
-create-compat_sys_migrate_pages.patch
-wire-up-sys_migrate_pages.patch
-revert-iscsi-build-failure-use-depends-instead-of.patch
-let-pci_multithread_probe-depend-on-broken.patch
-hdspm-printk-warning-fix.patch
-nozomi-warning-fixes.patch
-nozomi-irq-flags-fixes.patch
-update-uio_interrupt.patch
-dvb-dibx000_common-fix.patch
-input-handle-sysfs-errors.patch
-input-drivers-handle-sysfs-errors.patch
-lightning-return-proper-return-code.patch
-ps-2-driver-update-for-fujitsu-4-wire-touchscreen-on-hitachi-tablets.patch
-lifebook-learn-about-tabs.patch
-git-net-configh-got-removed.patch
-sundance-remove-txstartthresh-and-rxearlythresh.patch
-sundance-fix-tx-pause-bug-reset_tx-intr_handler.patch
-sundance-correct-initial-and-close-hardware-step.patch
-defxx-big-endian-hosts-support.patch
-netxen-build-fix.patch
-netxen-more-build-fixes.patch
-forcedeth-add-mgmt-unit-support.patch
-forcedeth-add-recoverable-error-support.patch
-forcedeth-add-new-nvidia-pci-ids.patch
-forcedeth-add-support-for-new-mcp67-device.patch
-nfs-nfsaclsvc_encode_getaclres-fix-potential-null-deref-and-tiny-optimization.patch
-sunrpc-add-missing-spin_unlock.patch
-git-scsi-target-fixup.patch
-git-scsi-target-vs-git-block.patch
-scsi-target-needs-pci.patch
-gregkh-usb-sierra-new-device.patch
-gregkh-usb-hid-core-big-endian-fix-fix.patch
-xpad-additional-usb-ids-added.patch
-usb-print_schedule_frame-defined-but-not-used-warning-fix.patch
-x86_64-mm-i386-reloc-data-4k-aligned.patch
-x86_64-mm-paravirt-cpu-detect.patch
-x86_64-mm-clear-irq-vector.patch
-x86_64-mm-io-apic-reuse.patch
-prep-for-paravirt-desch-clearer-parameter-names.patch
-prep-for-paravirt-desch-clearer-parameter-names-fix.patch
-prep-for-paravirt-rearrange-processorh.patch
-paravirtualization-header-and-stubs-for.patch
-paravirtualization-patch-inline-replacements-for.patch
-paravirtualization-patch-inline-replacements-for-fix.patch
-paravirtualization-more-generic-paravirtualization.patch
-paravirtualization-allow-selected-bug-checks-to-be.patch
-paravirtualization-allow-disabling-legacy-power.patch
-paravirtualization-add-apic-accessors-to-paravirt-ops.patch
-paravirtualization-add-apic-accessors-to-paravirt-ops-tidy.patch
-paravirtualization-add-mmu-virtualization-to.patch
-swsusp-use-platform-mode-by-default.patch
-improve-the-remove-sysctl-warnings.patch
-sysctl-allow-a-zero-ctl_name-in-the-middle-of-a-sysctl-table.patch
-sysctl-implement-ctl_unnumbered.patch

Merged into mainline or a subsystem tree.

+regression-in-2619-rc-microcode-driver.patch
+a-minor-fix-for-set_mb-in-documentation-memory-barrierstxt.patch
+nfsd4-reindent-do_open_lookup.patch
+nfsd4-fix-open-create-permissions.patch
+x86_64-mm-i386-reloc-data-4k-aligned.patch
+dm-fix-find_device-race.patch
+dm-suspend-fix-error-path.patch
+dm-multipath-fix-rr_add_path-order.patch
+dm-raid1-fix-waiting-for-io-on-suspend.patch
+dm-raid1-fix-waiting-for-io-on-suspend-fix.patch
+drivers-telephony-ixj-fix-an-array-overrun.patch
+tigran-has-moved.patch
+md-change-online-offline-events-to-a-single-change-event.patch
+md-fix-sizing-problem-with-raid5-reshape-and-config_lbd=n.patch
+md-do-not-freeze-md-threads-for-suspend.patch
+fix-kretprobe-booster-to-save-regs-and-set-status.patch

2.6.19 queue (mostly)

+video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register.patch
+video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-msi-laptop-fix.patch
+add-display-output-class-support.patch
+backlight-and-output-sysfs-support-for-acpi-video-driver.patch
+add-output-class-document.patch
+fix-comments-style-in-acpi-videoc.patch

ACPI things.

+video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch

Fix sony acpi driver for acpi things.

+remove-hotplug-cpu-crap-from-cpufreq.patch

cpufreq cleanup

+git-cpufreq-build-fix.patch

cpufreq fix

+fix-gregkh-driver-network-device.patch

Fix driver tree

+tda826x-use-correct-max-frequency.patch

DVB fix

+ia64-select-acpi_numa-if-acpi.patch

ia64 fix

+input-map-btn_forward-to-button-2-in-mousedev.patch

input fix

+e1000-linkage-fix.patch

netdev fix

+net-uninline-xfrm_selector_match.patch
+net-uninline-skb_put.patch

uninline porky functions in net

+fix-sunrpc-wakeup-execute-race-condition.patch

NFS fix

+powerpc-add-efika-platform-support.patch

ppc board support.

+gregkh-pci-pci-multithread-not-broken.patch

PCI tree update

+fix-pci-sysfs-file-deletion.patch

PCI fix

+pci-check-szhi-when-sz-is-0-for-64-bit-pref-mem.patch

PCI fix which is partial and which I don't fully understand :(

+drivers-scsi-mca_53c9xc-save_flags-cli-removal.patch
+drivers-scsi-mca_53c9xc-save_flags-cli-removal-fix.patch
+drivers-scsi-psi240ic-fix-an-array-overrun.patch

scsi fixlets

+git-sas-kconfig-fix.patch

SAS fix

+gregkh-usb-usb-storage-unusual_devs.h-entry-for-sony-ericsson-p990i.patch
+gregkh-usb-usb-ftdi_sio-adds-vendor-product-id-for-a-rfid-construction-kit.patch
+gregkh-usb-usb-ftdi-driver-pid-for-dmx-interfaces.patch
+gregkh-usb-usb-fix-ucr-61s2b-unusual_dev-entry.patch
+gregkh-usb-usb-ohci-fix-root-hub-resume-bug.patch
+gregkh-usb-usb-hid-handle-stall-on-interrupt-endpoint.patch
+gregkh-usb-usb-core-don-t-match-interface-descriptors-for-vendor-specific-devices.patch
+gregkh-usb-usb-ohci-hcd-fix-compiler-warning.patch
+gregkh-usb-usb-ohci-disable-rhsc-inside-interrupt-handler.patch
+gregkh-usb-usb-kmemdup-cleanup-in-drivers-usb.patch
+gregkh-usb-usb-ohci-remove-stale-testing-code-from-root-hub-resume.patch
+gregkh-usb-aircable-use-usb-endpoint-functions.patch
+gregkh-usb-appledisplay-use-usb-endpoint-functions.patch
+gregkh-usb-cdc_ether-use-usb-endpoint-functions.patch
+gregkh-usb-cdc-use-usb-endpoint-functions.patch
+gregkh-usb-devices-use-usb-endpoint-functions.patch
+gregkh-usb-ftdi-use-usb-endpoint-functions.patch
+gregkh-usb-hid-use-usb-endpoint-functions.patch
+gregkh-usb-idmouse-use-usb-endpoint-functions.patch
+gregkh-usb-kobil_sct-use-usb-endpoint-functions.patch
+gregkh-usb-legousbtower-use-usb-endpoint-functions.patch
+gregkh-usb-onetouch-use-usb-endpoint-functions.patch
+gregkh-usb-phidgetkit-use-usb-endpoint-functions.patch
+gregkh-usb-phidgetmotorcontrol-use-usb-endpoint-functions.patch
+gregkh-usb-speedtch-use-usb-endpoint-functions.patch
+gregkh-usb-usbkbd-use-usb-endpoint-functions.patch
+gregkh-usb-usbmouse-use-usb-endpoint-functions.patch
+gregkh-usb-usbnet-use-usb-endpoint-functions.patch
+gregkh-usb-usbtest-use-usb-endpoint-functions.patch
+gregkh-usb-usb-use-usb-endpoint-functions.patch
+gregkh-usb-yealink-use-usb-endpoint-functions.patch
+gregkh-usb-usb-makes-usb_endpoint_-functions-inline.patch
+gregkh-usb-usb-autosuspend-code-consolidation.patch
+gregkh-usb-usb-expand-autosuspend-autoresume-api.patch
+gregkh-usb-usb-print_schedule_frame-defined-but-not-used-warning-fix.patch

USB tree updates

+fix-gregkh-usb-usb-expand-autosuspend-autoresume-api.patch

Fix it.

+correct-keymapping-on-powerbook-built-in-usb-iso-keyboards.patch
+powerpc-add-of_platform-support-for-ohci-bigendian-hc.patch
+usb-urb-unlink-free-clenup.patch
+usb-idmouse-cleanup.patch

USB updates

+x86_64-mm-i386-reloc-abssym.patch
+x86_64-mm-i386-reloc-cleanup-align.patch
+x86_64-mm-paravirt-cpu-detect.patch
+x86_64-mm-clear-irq-vector.patch
+x86_64-mm-io-apic-reuse.patch
+x86_64-mm-pka-cast.patch
+x86_64-mm-probe-kernel-address.patch
+x86_64-mm-i386-probe-kernel-address.patch
+x86_64-mm-fix-exit-idle-race.patch
+x86_64-mm-try-multiple-timer-pins.patch
+x86_64-mm-sa_siginfo-was-forgotten.patch
+x86_64-mm-reserve-bootmem-beyond-end-pfn.patch
+x86_64-mm-header-and-stubs-for.patch
+x86_64-mm-paravirt-patch.patch
+x86_64-mm-paravirt-entry.patch
+x86_64-mm-paravirt-bug-skip.patch
+x86_64-mm-paravirt-no-legacy.patch
+x86_64-mm-paravirt-apic.patch
+x86_64-mm-paravirt-tlb.patch
+x86_64-mm-paravirt-broken.patch
+x86_64-mm-paravirt-compile.patch
+x86_64-mm-calgary-shift.patch
+x86_64-mm-calgary-bios.patch
+x86_64-mm-calgary-bios-cleanup.patch
+x86_64-mm-calgary-not-default.patch
+x86_64-mm-make-x86_64-udelay-round-up-instead-of-down..patch
+x86_64-mm-comment-magic-constants-in-delay.h.patch
+x86_64-mm-setup-saved_max_pfn-correctly-kdump.patch
+x86_64-mm-io-apic-cleanup.patch
+x86_64-mm-i386-apic-irq-race.patch
+x86_64-mm-apic-irq-race.patch
+x86_64-mm-i386-iopl.patch
+x86_64-mm-csum-dont-inline.patch

x86 tree updates

-revert-x86_64-mm-cpa-clflush.patch

Dropped

+x86_64-mm-i386-reloc-abssym-hack.patch
+fix-x86_64-mm-i386-reloc-kallsyms.patch

Fix x86 tree

+paravirtualization-header-and-stubs-for-fix.patch
+paravirtualization-header-and-stubs-for-headers_check-fix.patch
+paravirtualization-patch-inline-replacements-for-fix-2.patch
+paravirtualization-patch-inline-replacements-for-fix-3.patch
+paravirtualization-more-generic-paravirtualization-warning-fix.patch

Fix paravirt patches in x86 tree

+htirq-refactor-so-we-only-have-one-function-that-writes-to-the-chip.patch
+htirq-allow-buggy-drivers-of-buggy-hardware-to-write-the-registers.patch
+htirq-allow-buggy-drivers-of-buggy-hardware-to-write-the-registers-update.patch

Rework hypertransport code

+x86_64-update-mmconfig-resource-insertion-to-check-against-e820-map.patch
+i386-update-mmconfig-resource-insertion-to-check-against-e820-map.patch

x86 updates

+mm-pagefault_disableenable-s390-fix.patch

Fix mm-pagefault_disableenable.patch

+fix-kunmap_atomics-use-of-kpte_clear_flush.patch

kunmap_atomic() fixlet.

+allowing-user-processes-to-rise-their-oom_adj-value.patch

Allow processes to increase their oomkillability.

+gpio-framework-for-avr32.patch
+avr32-spi-ethernet-platform_device-update.patch
+avr32-move-spi-device-definitions-into-main-board.patch
+atmel-spi-driver.patch
+atmel-spi-driver-maintainers-entry.patch
+avr32-move-ethernet-tag-parsing-to-board-specific.patch
+atmel-macb-ethernet-driver.patch
+adapt-macb-driver-to-net_device-changes.patch

avr32 things

+suspend-dont-change-cpus_allowed-for-task-initiating-the-suspend.patch
+swsusp-measure-memory-shrinking-time.patch

swsusp updates

+cciss-version-change.patch
+cciss-reference-driver-support.patch
+cciss-increase-number-of-commands-on-controller.patch
+cciss-fix-pci-ssid-for-the-e500-controller.patch
+cciss-disable-dma-prefetch-on-p600.patch
+cciss-set-sector_size-to-2048-for-performance.patch
+cciss-set-sector_size-to-2048-for-performance-tidy.patch
+cciss-change-cciss_open-for-consistency.patch
+cciss-remove-unused-revalidate_allvol-function.patch
+cciss-add-support-for-1024-logical-volumes.patch
+cciss-cleanup-cciss_interrupt-mode.patch

cciss updates (most of them)

+drivers-add-lcd-support-update-7.patch

More LCD driver updates

-cciss-change-pci-id-for-bug-workaround.patch

Dropped.

+taskstats-cleanup-reply-assembling.patch

taskstats cleanup

-vfs-bkl-is-not-required-for-remount_fs.patch

Dropped.

+get_options-to-allow-a-hypenated-range-for-isolcpus.patch
+vfs_getattr-remove-dead-code.patch
+ext3-uninline-large-functions.patch
+ext4-uninline-large-functions.patch
+uninline-module_put.patch
+i2lib-unused-variable-cleanup.patch
+make-initramfs-printk-a-warning-on-incorrect-cpio-type.patch
+corrupted-cramfs-filesystems-cause-kernel-oops.patch
+lockdep-print-current-locks-on-in_atomic-warnings.patch
+lockdep-name-some-old-style-locks.patch
+documentation-remount_fs-needs-lock_kernel.patch
+sleep-profiling.patch
+sleep-profiling-fixes.patch
+sleep-profiling-fix.patch
+ext4_ext_split-remove-dead-code.patch
+debug-workqueue-locking-sanity.patch
+debug-workqueue-locking-sanity-fix.patch
+initramfs-handle-more-than-one-source-dir-or-file-list.patch

Misc

+bdev-fix-bd_part_count-leak.patch

Fix blockdev lockdep patches in -mm.

-struct-path-convert-splice.patch

Dropped, for some reason. I think the fix got moved into a different patch
during reject fixups.

+tty_ioctl-use-termios-for-the-old-structure-and-termios2.patch
+tty_ioctl-use-termios-for-the-old-structure-and-termios2-fix.patch

More tty core updates

+char-stallion-functions-cleanup.patch
+char-stallion-fix-fail-paths.patch
+char-stallion-brd-struct-locking.patch
+char-stallion-remove-syntactic-sugar.patch
+char-stallion-variables-cleanup.patch
+char-stallion-use-dynamic-dev.patch
+char-istallion-convert-to-pci-probing.patch
+char-istallion-remove-the-mess.patch
+char-istallion-eliminate-typedefs.patch
+char-istallion-variables-cleanup.patch
+char-istallion-ifdef-eisa-code.patch
+char-istallion-brdnr-locking.patch
+char-istallion-free-only-isa.patch
+char-istallion-correct-fail-paths.patch
+char-istallion-correct-fail-paths-fix.patch

More char driver clanups.

+kernel-schedc-whitespace-cleanups.patch
+kernel-schedc-whitespace-cleanups-more.patch

Clean up sched.c

-radeonfb-support-24bpp-32bpp-minus-alpha.patch

Dropped

+various-fbdev-files-mark-structs-fix.patch

Fix various-fbdev-files-mark-structs.patch

+fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch

fbdev fix

+md-tidy-up-device-change-notification-when-an-md-array-is-stopped.patch
+md-change-lifetime-rules-for-md-devices.patch
+md-define-raid5_mergeable_bvec.patch
+md-handle-bypassing-the-read-cache-assuming-nothing-fails.patch
+md-allow-reads-that-have-bypassed-the-cache-to-be-retried-on-failure.patch
+md-allow-reads-that-have-bypassed-the-cache-to-be-retried-on-failure-fix.patch
+md-enable-bypassing-cache-for-reads.patch

RAID updates

+clockevents-add-broadcast-support-fix.patch
+acpi-include-apic-h-fix.patch
+acpi-verify-lapic-timer-fix.patch

Try to fix the hrtimers patches in -mm some more (unsuccessfully)

+clocksource-add-usage-of-config_sysfs.patch
+clocksource-small-cleanup-2.patch
+clocksource-small-cleanup-2-fix.patch
+clocksource-small-acpi_pm-cleanup.patch

clocksource cleanups

+kvm-userspace-interface.patch
+kvm-intel-virtual-mode-extensions-definitions.patch
+kvm-kvm-data-structures.patch
+kvm-random-accessors-and-constants.patch
+kvm-virtualization-infrastructure.patch
+kvm-virtualization-infrastructure-kvm-fix-guest-cr4-corruption.patch
+kvm-memory-slot-management.patch
+kvm-vcpu-creation-and-maintenance.patch
+kvm-workaround-cr0cd-cache-disable-bit-leak-from-guest-to.patch
+kvm-vcpu-execution-loop.patch
+kvm-define-exit-handlers.patch
+kvm-less-common-exit-handlers.patch
+kvm-mmu.patch
+kvm-x86-emulator.patch
+kvm-plumbing.patch
+kvm-dynamically-determine-which-msrs-to-load-and-save.patch
+kvm-fix-calculation-of-initial-value-of-rdx-register.patch

In-kernel virtual machine

-kevent-core-files.patch
-kevent-core-files-fix.patch
-kevent-core-files-s390-hack.patch
-kevent-poll-select-notifications.patch
-kevent-socket-notifications.patch
-kevent-socket-notifications-fix-2.patch
-kevent-socket-notifications-fix-4.patch
-kevent-timer-notifications.patch
-kevent-timer-notifications-fix.patch
-kevent-fix-socket-notifications.patch
-kevent-remove-mmap-interface.patch
+kevent-v23-description.patch
+kevent-v23-core-files.patch
+kevent-v23-poll-select-notifications.patch
+kevent-v23-socket-notifications.patch
+kevent-v23-socket-notifications-fix-again.patch
+kevent-v23-timer-notifications.patch
+kevent-timer-notifications-fix.patch

Updated kevent patches

+e1000-printk-warning-fixes.patch

Fix warnings due to e1000_7033_dump_ring.patch


All 1245 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/patch-list



2006-11-08 11:11:44

by Reuben Farrelly

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1



On 8/11/2006 8:54 PM, Andrew Morton wrote:
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
>
> will turn up at
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
>
>
> when kernel.org mirroring catches up.
>
>
>
> - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> userspace tools, instructions, etc.
>
> It needs a recent binutils to build.
>
> - The hrtimer+dynticks code still doesn't work right for machines which halt
> their TSC in low-power states.

I think this might be a davej thing:

CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_cpu_exit':
/usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:762:
undefined reference to `cpufreq_frequency_table_put_attr'
arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_target':
/usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:406:
undefined reference to `cpufreq_frequency_table_target'
arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_verify':
/usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:491:
undefined reference to `cpufreq_frequency_table_verify'
arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_cpu_init':
/usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:698:
undefined reference to `cpufreq_frequency_table_cpuinfo'
/usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:734:
undefined reference to `cpufreq_frequency_table_get_attr'
arch/x86_64/kernel/built-in.o: In function `trampoline_end':
(.data+0x40c0): undefined reference to `cpufreq_freq_attr_scaling_available_freqs'
drivers/built-in.o: In function `ondemand_powersave_bias_init':
/usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:164: undefined
reference to `cpufreq_frequency_get_table'
drivers/built-in.o: In function `powersave_bias_target':
/usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:126: undefined
reference to `cpufreq_frequency_table_target'
/usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:134: undefined
reference to `cpufreq_frequency_table_target'
/usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:138: undefined
reference to `cpufreq_frequency_table_target'
make: *** [.tmp_vmlinux1] Error 1
[root@tornado linux-mm]#

.config looks like this:

#
# ACPI (Advanced Configuration and Power Interface) Support
#
CONFIG_ACPI=y
CONFIG_ACPI_AC=y
# CONFIG_ACPI_BATTERY is not set
CONFIG_ACPI_BUTTON=y
# CONFIG_ACPI_HOTKEY is not set
CONFIG_ACPI_FAN=y
# CONFIG_ACPI_DOCK is not set
CONFIG_ACPI_BAY=m
CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_IBM is not set
# CONFIG_ACPI_TOSHIBA is not set
# CONFIG_ACPI_SONY is not set
CONFIG_ACPI_BLACKLIST_YEAR=0
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_X86_PM_TIMER=y
# CONFIG_ACPI_CONTAINER is not set
# CONFIG_ACPI_SBS is not set
#
# CPU Frequency scaling
#
CONFIG_CPU_FREQ=y
CONFIG_CPU_FREQ_TABLE=m
# CONFIG_CPU_FREQ_DEBUG is not set
CONFIG_CPU_FREQ_STAT=m
# CONFIG_CPU_FREQ_STAT_DETAILS is not set
# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE=y
# CONFIG_CPU_FREQ_GOV_PERFORMANCE is not set
# CONFIG_CPU_FREQ_GOV_POWERSAVE is not set
CONFIG_CPU_FREQ_GOV_USERSPACE=y
CONFIG_CPU_FREQ_GOV_ONDEMAND=y
# CONFIG_CPU_FREQ_GOV_CONSERVATIVE is not set

#
# CPUFreq processor drivers
#
# CONFIG_X86_POWERNOW_K8 is not set
# CONFIG_X86_SPEEDSTEP_CENTRINO is not set
CONFIG_X86_ACPI_CPUFREQ=y

#
# shared options
#
# CONFIG_X86_ACPI_CPUFREQ_PROC_INTF is not set
# CONFIG_X86_SPEEDSTEP_LIB is not set

This is the first time I'm building some of the CPU power management features,
so the problem may not be new to this release.

Reuben

2006-11-08 12:08:22

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

Hello,

This was seen on athlon machine with 'make allmodconfig'.

CC [M] drivers/kvm/kvm_main.o
{standard input}: Assembler messages:
{standard input}:830: Error: no such instruction: `vmclear -12(%ebp)'
{standard input}:979: Error: no such instruction: `vmptrld -36(%ebp)'
{standard input}:1557: Error: no such instruction: `vmxon -20(%ebp)'
{standard input}:1579: Error: no such instruction: `vmxoff'
{standard input}:1935: Error: no such instruction: `vmread %eax,%eax'
{standard input}:1966: Error: no such instruction: `vmwrite %edx,%eax'
{standard input}:8697: Error: no such instruction: `vmwrite %esp,%eax'
{standard input}:8709: Error: no such instruction: `vmlaunch '
{standard input}:8711: Error: no such instruction: `vmresume '
make[2]: *** [drivers/kvm/kvm_main.o] Error 1
make[1]: *** [drivers/kvm] Error 2
make: *** [drivers] Error 2


system info:

Linux localhost 2.6.16-gentoo-r13 #4 PREEMPT Sat Oct 14 17:47:21 CEST 2006 i686 AMD Athlon(tm) XP 1700+ AuthenticAMD GNU/Linux

Gnu C 3.4.6
Gnu make 3.81
binutils 2.16.1
util-linux 2.12r
mount 2.12r
module-init-tools 3.2.2
e2fsprogs 1.39
nfs-utils 1.0.6
Linux C Library > libc.2.4
Dynamic linker (ldd) 2.4
Procps 3.2.6
Net-tools 1.60
Kbd 1.12
Sh-utils 6.4
udev 087
Modules Loaded

Regards,

Mariusz Kozlowski

2006-11-08 12:32:53

by Christian Hesse

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wednesday 08 November 2006 13:07, Mariusz Kozlowski wrote:
> Hello,
>
> This was seen on athlon machine with 'make allmodconfig'.

You need binutils >= 2.16.91.0.2 if CONFIG_KVM is enabled. See "[PATCH 0/14]
KVM: Kernel-based Virtual Machine (v4)" for details and discussion.
--
Regards,
Christian


Attachments:
(No filename) (304.00 B)
(No filename) (189.00 B)
Download all attachments

2006-11-08 12:55:19

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

Witam,

> On Wednesday 08 November 2006 13:07, Mariusz Kozlowski wrote:
> > Hello,
> >
> > This was seen on athlon machine with 'make allmodconfig'.
>
> You need binutils >= 2.16.91.0.2 if CONFIG_KVM is enabled. See "[PATCH 0/14]
> KVM: Kernel-based Virtual Machine (v4)" for details and discussion.

True. Thanks.

--
Regards,

Mariusz Kozlowski

2006-11-08 14:58:17

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

> > > This was seen on athlon machine with 'make allmodconfig'.
> >
> > You need binutils >= 2.16.91.0.2 if CONFIG_KVM is enabled. See "[PATCH 0/14]
> > KVM: Kernel-based Virtual Machine (v4)" for details and discussion.
>
> True. Thanks.

binutils upgrade helped. Another problem (also in 2.6.19-rc4-mm2) is:

CC [M] drivers/media/video/pwc/pwc-uncompress.o
In file included from drivers/media/video/pwc/pwc-uncompress.c:29:
include/asm/current.h: In function `get_current':
include/asm/current.h:11: error: `size_t' undeclared (first use in this function)
include/asm/current.h:11: error: (Each undeclared identifier is reported only once
include/asm/current.h:11: error: for each function it appears in.)
make[4]: *** [drivers/media/video/pwc/pwc-uncompress.o] Error 1
make[3]: *** [drivers/media/video/pwc] Error 2
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make: *** [drivers] Error 2

It is the same athlon box with 'make allmodconfig'.

Linux localhost 2.6.16-gentoo-r13 #4 PREEMPT Sat Oct 14 17:47:21 CEST 2006 i686 AMD Athlon(tm) XP 1700+ AuthenticAMD GNU/Linux

Gnu C 3.4.6
Gnu make 3.81
binutils 2.17
util-linux 2.12r
mount 2.12r
module-init-tools 3.2.2
e2fsprogs 1.39
nfs-utils 1.0.6
Linux C Library > libc.2.4
Dynamic linker (ldd) 2.4
Procps 3.2.6
Net-tools 1.60
Kbd 1.12
Sh-utils 6.4
udev 087
Modules Loaded

--
Regards,

Mariusz Kozlowski

2006-11-08 15:08:49

by Benoit Boissinot

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On 11/8/06, Andrew Morton <[email protected]> wrote:
>
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
>
> will turn up at
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
>
> when kernel.org mirroring catches up.
>
I have the following traceback during boot:
[ 20.359613] BUG: unable to handle kernel NULL pointer dereference
at virtual address 00000000
[ 20.359618] printing eip:
[ 20.359620] 00000000
[ 20.359621] *pde = 00000000
[ 20.359625] Oops: 0000 [#1]
[ 20.359627] last sysfs file:
[ 20.359630] Modules linked in: processor fan
[ 20.359635] CPU: 0
[ 20.359636] EIP: 0060:[<00000000>] Not tainted VLI
[ 20.359638] EFLAGS: 00010006 (2.6.19-rc5-mm1 #15)
[ 20.359642] EIP is at 0x0
[ 20.359644] eax: 00000002 ebx: 00000002 ecx: c04332c0 edx: c04332c0
[ 20.359648] esi: e6b71ee0 edi: 00000008 ebp: e6b71e94 esp: dfc27dac
[ 20.359651] ds: 007b es: 007b ss: 0068
[ 20.359654] Process modprobe (pid: 939, ti=dfc26000 task=e6429030
task.ti=dfc26000)
[ 20.359656] Stack: c012fae0 e6b71c00 e80307bd 00000001 e8030b76
dfc27e40 00000000 e6b71d28
[ 20.359663] 00000003 00000003 00000000 00000003 00000004
00000000 e6f8fa00 00000300
[ 20.359669] 00001015 00000300 00000055 00000000 000000fa
00000000 00000000 00000000
[ 20.359675] Call Trace:
[ 20.359677] [<c012fae0>] clockevents_set_global_broadcast+0x60/0x70
[ 20.359686] [<e80307bd>] acpi_propagate_timer_broadcast+0x24/0x31
[processor]
[ 20.359695] [<e8030b76>] acpi_processor_get_power_info+0x3ac/0x4e7
[processor]
[ 20.359704] [<e80204fa>] acpi_processor_power_init+0x9b/0x15e [processor]
[ 20.359712] [<e8020386>] acpi_processor_start+0x386/0x3f8 [processor]
[ 20.359719] [<c020e4cf>] acpi_start_single_object+0x1b/0x3b
[ 20.359727] [<c020ead3>] acpi_bus_register_driver+0x65/0x7c
[ 20.359732] [<e802043b>] acpi_processor_init+0x43/0x67 [processor]
[ 20.359739] [<c0134137>] sys_init_module+0x157/0x1820
[ 20.359746] [<c0102f90>] syscall_call+0x7/0xb
[ 20.359751] =======================
[ 20.359753] Code: Bad EIP value.
[ 20.359756] EIP: [<00000000>] 0x0 SS:ESP 0068:dfc27dac

reverting:
i386-apic-timer-use-clockevents-broadcast.patch
acpi-verify-lapic-timer.patch
acpi-verify-lapic-timer-exports.patch
acpi-verify-lapic-timer-fix.patch

fixes it.

regards,

Benoit

dmesg and kernel config at: http://perso.ens-lyon.fr/benoit.boissinot/kernel/

2006-11-08 18:14:18

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, 8 Nov 2006 15:57:20 +0100
Mariusz Kozlowski <[email protected]> wrote:

> > > > This was seen on athlon machine with 'make allmodconfig'.
> > >
> > > You need binutils >= 2.16.91.0.2 if CONFIG_KVM is enabled. See "[PATCH 0/14]
> > > KVM: Kernel-based Virtual Machine (v4)" for details and discussion.
> >
> > True. Thanks.
>
> binutils upgrade helped. Another problem (also in 2.6.19-rc4-mm2) is:
>
> CC [M] drivers/media/video/pwc/pwc-uncompress.o
> In file included from drivers/media/video/pwc/pwc-uncompress.c:29:
> include/asm/current.h: In function `get_current':
> include/asm/current.h:11: error: `size_t' undeclared (first use in this function)
> include/asm/current.h:11: error: (Each undeclared identifier is reported only once
> include/asm/current.h:11: error: for each function it appears in.)
> make[4]: *** [drivers/media/video/pwc/pwc-uncompress.o] Error 1
> make[3]: *** [drivers/media/video/pwc] Error 2
> make[2]: *** [drivers/media/video] Error 2
> make[1]: *** [drivers/media] Error 2
> make: *** [drivers] Error 2
>
> It is the same athlon box with 'make allmodconfig'.
>
> Linux localhost 2.6.16-gentoo-r13 #4 PREEMPT Sat Oct 14 17:47:21 CEST 2006 i686 AMD Athlon(tm) XP 1700+ AuthenticAMD GNU/Linux
>
> Gnu C 3.4.6

Well I dunno - I cannot reproduce this with gcc-3.4.2.

I assume what's happening is that

get_current->read_pda->pda_from_op->pda_offset->offsetof

is using the gcc-3 version of offsetof:

#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)

only we don't have a definition of size_t in scope.

Except pda.h includes linux/types.h.

Another possibility is that the compiler is being silly and is expanding
typeof(a_size_t_type) into `size_t' and is then unable to find a definition
of size_t.

Hey, I've got an idea: I'll punt this to the maintainer ;)


Can you please run

make drivers/media/video/pwc/pwc-uncompress.i

and then make that file available? (It's half a meg - just mail it to me
privately and I'll upload it).

2006-11-08 19:19:27

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, 8 Nov 2006 15:57:20 +0100
Mariusz Kozlowski <[email protected]> wrote:

> CC [M] drivers/media/video/pwc/pwc-uncompress.o
> In file included from drivers/media/video/pwc/pwc-uncompress.c:29:
> include/asm/current.h: In function `get_current':
> include/asm/current.h:11: error: `size_t' undeclared (first use in this function)
> include/asm/current.h:11: error: (Each undeclared identifier is reported only once
> include/asm/current.h:11: error: for each function it appears in.)

Ah, you're i386, not x86_64. This should help.


From: Andrew Morton <[email protected]>

i386's pda.h needs types.h for size_t (used by offsetof if gcc-3)

Cc: Mariusz Kozlowski <[email protected]>,
Cc: Andi Kleen <[email protected]>
Cc: Jeremy Fitzhardinge <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---

include/asm-i386/pda.h | 1 +
1 files changed, 1 insertion(+)

diff -puN include/asm-i386/current.h~fix-x86_64-mm-pda-current include/asm-i386/current.h
diff -puN include/asm-i386/pda.h~fix-x86_64-mm-pda-current include/asm-i386/pda.h
--- a/include/asm-i386/pda.h~fix-x86_64-mm-pda-current
+++ a/include/asm-i386/pda.h
@@ -7,6 +7,7 @@
#define _I386_PDA_H

#include <linux/stddef.h>
+#include <linux/types.h>

struct i386_pda
{
_

2006-11-08 20:06:32

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, 08 Nov 2006 22:11:26 +1100
Reuben Farrelly <[email protected]> wrote:

>
>
> On 8/11/2006 8:54 PM, Andrew Morton wrote:
> > Temporarily at
> >
> > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> >
> > will turn up at
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> >
> >
> > when kernel.org mirroring catches up.
> >
> >
> >
> > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > userspace tools, instructions, etc.
> >
> > It needs a recent binutils to build.
> >
> > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > their TSC in low-power states.
>
> I think this might be a davej thing:
>
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_cpu_exit':
> /usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:762:
> undefined reference to `cpufreq_frequency_table_put_attr'
> arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_target':
> /usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:406:
> undefined reference to `cpufreq_frequency_table_target'
> arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_verify':
> /usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:491:
> undefined reference to `cpufreq_frequency_table_verify'
> arch/x86_64/kernel/built-in.o: In function `acpi_cpufreq_cpu_init':
> /usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:698:
> undefined reference to `cpufreq_frequency_table_cpuinfo'
> /usr/src/linux/linux-mm/arch/x86_64/kernel/cpufreq/../../../i386/kernel/cpu/cpufreq/acpi-cpufreq.c:734:
> undefined reference to `cpufreq_frequency_table_get_attr'
> arch/x86_64/kernel/built-in.o: In function `trampoline_end':
> (.data+0x40c0): undefined reference to `cpufreq_freq_attr_scaling_available_freqs'
> drivers/built-in.o: In function `ondemand_powersave_bias_init':
> /usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:164: undefined
> reference to `cpufreq_frequency_get_table'
> drivers/built-in.o: In function `powersave_bias_target':
> /usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:126: undefined
> reference to `cpufreq_frequency_table_target'
> /usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:134: undefined
> reference to `cpufreq_frequency_table_target'
> /usr/src/linux/linux-mm/drivers/cpufreq/cpufreq_ondemand.c:138: undefined
> reference to `cpufreq_frequency_table_target'
> make: *** [.tmp_vmlinux1] Error 1
> [root@tornado linux-mm]#
>
> .config looks like this:

It's pretty useless sending a mangled config. In future, please send the
whole thing.

The problem is that you have

> CONFIG_CPU_FREQ_TABLE=m
> CONFIG_X86_ACPI_CPUFREQ=y

but acpi-cpufreq needs the stuff in freq_table.c.

This happens again and again and again and again. I wish people would just
stop using `select'. It. Doesn't. Work.

Either we fix select or we stop using the damn thing.

2006-11-08 20:16:06

by Dave Jones

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, Nov 08, 2006 at 12:05:47PM -0800, Andrew Morton wrote:

> The problem is that you have
>
> > CONFIG_CPU_FREQ_TABLE=m
> > CONFIG_X86_ACPI_CPUFREQ=y
>
> but acpi-cpufreq needs the stuff in freq_table.c.
>
> This happens again and again and again and again. I wish people would just
> stop using `select'. It. Doesn't. Work.
>
> Either we fix select or we stop using the damn thing.

So, why doesn't select set the symbol it's selecting to the
same value as the symbol being configured ?
That would solve the issue no?

Dave

--
http://www.codemonkey.org.uk

2006-11-08 20:31:32

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, 8 Nov 2006 15:15:39 -0500
Dave Jones <[email protected]> wrote:

> On Wed, Nov 08, 2006 at 12:05:47PM -0800, Andrew Morton wrote:
>
> > The problem is that you have
> >
> > > CONFIG_CPU_FREQ_TABLE=m
> > > CONFIG_X86_ACPI_CPUFREQ=y
> >
> > but acpi-cpufreq needs the stuff in freq_table.c.
> >
> > This happens again and again and again and again. I wish people would just
> > stop using `select'. It. Doesn't. Work.
> >
> > Either we fix select or we stop using the damn thing.
>
> So, why doesn't select set the symbol it's selecting to the
> same value as the symbol being configured ?

It would have to be "same or higher", where y > m

> That would solve the issue no?

It would sort-of-solve this issue. But it wouldn't stop `select' from being a
pita. I spent some time trying to reverse-engineer Reuben's config from
the tiny bit he shared with us and gave up because a twisty maze of selects
kept on insisting that CONFIG_CPU_FREQ_TABLE=y.

2006-11-08 20:48:46

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

Hello,

> Ah, you're i386, not x86_64. This should help.

Confirm. Now it seems to be fine. Thanks.

--
Regards,

Mariusz Kozlowski

2006-11-08 21:18:44

by Dave Jones

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, Nov 08, 2006 at 12:31:10PM -0800, Andrew Morton wrote:

> > So, why doesn't select set the symbol it's selecting to the
> > same value as the symbol being configured ?
>
> It would have to be "same or higher", where y > m
> > That would solve the issue no?
>
> It would sort-of-solve this issue. But it wouldn't stop `select' from being a
> pita. I spent some time trying to reverse-engineer Reuben's config from
> the tiny bit he shared with us and gave up because a twisty maze of selects
> kept on insisting that CONFIG_CPU_FREQ_TABLE=y.

I have a vague recollection that we used to have depends in there, but
that didn't work out for other reasons (this is where my memory gets fuzzy).
I think it caused problems when you had forward referencing depends.
That may have been subsequently resolved in kconfig, so maybe its worth
trying again for .20

What's really strange is that this kconfig has been this way for a while,
and it's only really been causing problems the last few weeks. Hmm.

Dave

--
http://www.codemonkey.org.uk

2006-11-08 22:08:31

by Thomas Gleixner

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wed, 2006-11-08 at 16:08 +0100, Benoit Boissinot wrote:
> I have the following traceback during boot:
> [ 20.359613] BUG: unable to handle kernel NULL pointer dereference
> at virtual address 00000000
> [ 20.359618] printing eip:
> [ 20.359620] 00000000
>
> reverting:
> i386-apic-timer-use-clockevents-broadcast.patch
> acpi-verify-lapic-timer.patch
> acpi-verify-lapic-timer-exports.patch
> acpi-verify-lapic-timer-fix.patch

Yep, my bad. working on a fix

tglx


2006-11-08 23:33:57

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
>
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
>
> will turn up at
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
>
> when kernel.org mirroring catches up.
>
>
>
> - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> userspace tools, instructions, etc.
>
> It needs a recent binutils to build.
>
> - The hrtimer+dynticks code still doesn't work right for machines which halt
> their TSC in low-power states.

On my HPC nx6325 it doesn't even reach the point in which the messages become
visible on the console, so I'm unable to get any debug info from it.

Will do a binary search tomorrow (unless someone finds the solution before).

Greetings,
Rafael

2006-11-09 00:17:47

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thu, 9 Nov 2006 00:31:34 +0100
"Rafael J. Wysocki" <[email protected]> wrote:

> On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> >
> > Temporarily at
> >
> > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> >
> > will turn up at
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> >
> > when kernel.org mirroring catches up.
> >
> >
> >
> > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > userspace tools, instructions, etc.
> >
> > It needs a recent binutils to build.
> >
> > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > their TSC in low-power states.
>
> On my HPC nx6325 it doesn't even reach the point in which the messages become
> visible on the console, so I'm unable to get any debug info from it.

Nice. You're using earlyprintk?


2006-11-09 00:47:25

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thursday, 9 November 2006 01:17, Andrew Morton wrote:
> On Thu, 9 Nov 2006 00:31:34 +0100
> "Rafael J. Wysocki" <[email protected]> wrote:
>
> > On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> > >
> > > Temporarily at
> > >
> > > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> > >
> > > will turn up at
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> > >
> > > when kernel.org mirroring catches up.
> > >
> > >
> > >
> > > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > > userspace tools, instructions, etc.
> > >
> > > It needs a recent binutils to build.
> > >
> > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > their TSC in low-power states.
> >
> > On my HPC nx6325 it doesn't even reach the point in which the messages become
> > visible on the console, so I'm unable to get any debug info from it.
>
> Nice. You're using earlyprintk?

earlyprintk=vga doesn't show anything (ie. blank screen), so it seems to crash
really early.

I'm unable to reproduce the problem on a non-SMP box (Asus L5D), which works
just fine with this kernel, but on the other SMP box the framebuffer is broken
(displays all fonts inverted, as in a mirror) and the kernel says it cannot
mount the root fs (which is on an md-raid).

All boxes are x86_64, the .config for nx6325 is attached.


Attachments:
(No filename) (1.39 kB)
.config (49.63 kB)
Download all attachments

2006-11-09 00:55:48

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thu, 9 Nov 2006 01:44:53 +0100
"Rafael J. Wysocki" <[email protected]> wrote:

> On Thursday, 9 November 2006 01:17, Andrew Morton wrote:
> > On Thu, 9 Nov 2006 00:31:34 +0100
> > "Rafael J. Wysocki" <[email protected]> wrote:
> >
> > > On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> > > >
> > > > Temporarily at
> > > >
> > > > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> > > >
> > > > will turn up at
> > > >
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> > > >
> > > > when kernel.org mirroring catches up.
> > > >
> > > >
> > > >
> > > > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > > > userspace tools, instructions, etc.
> > > >
> > > > It needs a recent binutils to build.
> > > >
> > > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > > their TSC in low-power states.
> > >
> > > On my HPC nx6325 it doesn't even reach the point in which the messages become
> > > visible on the console, so I'm unable to get any debug info from it.
> >
> > Nice. You're using earlyprintk?
>
> earlyprintk=vga doesn't show anything (ie. blank screen), so it seems to crash
> really early.

OK, so it's definitely bisection time.

> I'm unable to reproduce the problem on a non-SMP box (Asus L5D), which works
> just fine with this kernel, but on the other SMP box the framebuffer is broken
> (displays all fonts inverted, as in a mirror)

Which fbdev driver? (suspect fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch)

> and the kernel says it cannot
> mount the root fs (which is on an md-raid).

hm, there was probably some earlier message which tells us why that
happened. Doing a capure-and-compare on the dmesg output would be nice
(netconsole?)


> All boxes are x86_64, the .config for nx6325 is attached.
>

2006-11-09 01:07:17

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thursday, 9 November 2006 01:55, Andrew Morton wrote:
> On Thu, 9 Nov 2006 01:44:53 +0100
> "Rafael J. Wysocki" <[email protected]> wrote:
>
> > On Thursday, 9 November 2006 01:17, Andrew Morton wrote:
> > > On Thu, 9 Nov 2006 00:31:34 +0100
> > > "Rafael J. Wysocki" <[email protected]> wrote:
> > >
> > > > On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> > > > >
> > > > > Temporarily at
> > > > >
> > > > > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> > > > >
> > > > > will turn up at
> > > > >
> > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> > > > >
> > > > > when kernel.org mirroring catches up.
> > > > >
> > > > >
> > > > >
> > > > > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > > > > userspace tools, instructions, etc.
> > > > >
> > > > > It needs a recent binutils to build.
> > > > >
> > > > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > > > their TSC in low-power states.
> > > >
> > > > On my HPC nx6325 it doesn't even reach the point in which the messages become
> > > > visible on the console, so I'm unable to get any debug info from it.
> > >
> > > Nice. You're using earlyprintk?
> >
> > earlyprintk=vga doesn't show anything (ie. blank screen), so it seems to crash
> > really early.
>
> OK, so it's definitely bisection time.

Well, I've got some data from earlyprintk (forgot I needed to boot with
vga=normal).

Unfortunately, I had to rewrite the trace manually:

clear_IO_APIC_pin+0x15/0x6a
try_apic_pin+0x7a/0x98
setup_IO_APIC+0x600/0xb7a
smp_prepare_cpus+0x33a/0x371
init+0x60/0x32d
child_rip+0xa/0x12

[And then the unwinder said it got stuck.]

RIP is reported to be at ioapic_read_entry+0x33/0x61, which according to gdb
is:

0xffffffff80271418 is in ioapic_read_entry (include/asm/io.h:204).
199
200 #define mmiowb()
201
202 static inline void __writel(__u32 b, volatile void __iomem *addr)
203 {
204 *(__force volatile __u32 *)addr = b;
205 }
206 static inline void __writeq(__u64 b, volatile void __iomem *addr)
207 {
208 *(__force volatile __u64 *)addr = b;

> > I'm unable to reproduce the problem on a non-SMP box (Asus L5D), which works
> > just fine with this kernel,

Well, it's booted with 'noapic', so no wonder ...

> > but on the other SMP box the framebuffer is broken
> > (displays all fonts inverted, as in a mirror)
>
> Which fbdev driver? (suspect fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch)

vga=792

> > and the kernel says it cannot mount the root fs (which is on an md-raid).
>
> hm, there was probably some earlier message which tells us why that
> happened. Doing a capure-and-compare on the dmesg output would be nice
> (netconsole?)

Tomorrow I'll try a serial one, but now I must get some sleep (I can hardly
see anything).

2006-11-09 03:10:21

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] cpufreq: select consistently (Re: 2.6.19-rc5-mm1)

On Wed, 8 Nov 2006 15:15:39 -0500 Dave Jones wrote:

> On Wed, Nov 08, 2006 at 12:05:47PM -0800, Andrew Morton wrote:
>
> > The problem is that you have
> >
> > > CONFIG_CPU_FREQ_TABLE=m
> > > CONFIG_X86_ACPI_CPUFREQ=y
> >
> > but acpi-cpufreq needs the stuff in freq_table.c.
> >
> > This happens again and again and again and again. I wish people would just
> > stop using `select'. It. Doesn't. Work.
> >
> > Either we fix select or we stop using the damn thing.
>
> So, why doesn't select set the symbol it's selecting to the
> same value as the symbol being configured ?
> That would solve the issue no?

Why does arch/i386/kernel/cpu/cpufreq/Kconfig say:

config X86_ACPI_CPUFREQ
tristate "ACPI Processor P-States driver"
select CPU_FREQ_TABLE
depends on ACPI_PROCESSOR

but arch/x86_64/kernel/cpufreq/Kconfig say:

config X86_ACPI_CPUFREQ
tristate "ACPI Processor P-States driver"
depends on ACPI_PROCESSOR

# NOTE: no "select" on the latter one. // Randy


Let's see. Does that one-line patch fix anything? <builds>

make oldconfig

< CONFIG_CPU_FREQ_TABLE=m
> CONFIG_CPU_FREQ_TABLE=y

Builds cleanly now.

---
From: Randy Dunlap <[email protected]>

Make x86_64 ACPI_CPU_FREQ select CPU_FREQ_TABLE like other methods do.
(although we should still eliminate as much use of 'select' as possible)

Signed-off-by: Randy Dunlap <[email protected]>
---
arch/x86_64/kernel/cpufreq/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-2.6.19-rc5-mm1.orig/arch/x86_64/kernel/cpufreq/Kconfig
+++ linux-2.6.19-rc5-mm1/arch/x86_64/kernel/cpufreq/Kconfig
@@ -49,6 +49,7 @@ config X86_SPEEDSTEP_CENTRINO_ACPI

config X86_ACPI_CPUFREQ
tristate "ACPI Processor P-States driver"
+ select CPU_FREQ_TABLE
depends on ACPI_PROCESSOR
help
This driver adds a CPUFreq driver which utilizes the ACPI

2006-11-09 03:39:30

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] cpufreq: select consistently (Re: 2.6.19-rc5-mm1)

On Wed, Nov 08, 2006 at 07:09:44PM -0800, Randy Dunlap wrote:

> Why does arch/i386/kernel/cpu/cpufreq/Kconfig say:
>
> config X86_ACPI_CPUFREQ
> tristate "ACPI Processor P-States driver"
> select CPU_FREQ_TABLE
> depends on ACPI_PROCESSOR
>
> but arch/x86_64/kernel/cpufreq/Kconfig say:
>
> config X86_ACPI_CPUFREQ
> tristate "ACPI Processor P-States driver"
> depends on ACPI_PROCESSOR
>
> # NOTE: no "select" on the latter one. // Randy

A better question might be why they're two separate Kconfig's.
x86-64 doesn't make its own copy of the drivers, so why are
the Kconfig's special ?

Dave

--
http://www.codemonkey.org.uk

2006-11-09 15:04:25

by Andy Whitcroft

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure

We are seeing compile failures on ppc64 in ohci-hcd.c as below:

In file included from drivers/usb/host/ohci-hcd.c:949:
drivers/usb/host/ohci-ppc-of.c: In function `ohci_hcd_ppc_of_init':
drivers/usb/host/ohci-ppc-of.c:272: warning: int format, different type
arg (arg 2)
drivers/usb/host/ohci-ppc-of.c:272: warning: int format, different type
arg (arg 3)
drivers/usb/host/ohci-ppc-of.c: At top level:
drivers/usb/host/ohci-ppc-of.c:282: error: redefinition of `__inittest'
drivers/usb/host/ohci-pci.c:252: error: `__inittest' previously defined here
drivers/usb/host/ohci-ppc-of.c:282: error: redefinition of `init_module'
drivers/usb/host/ohci-pci.c:252: error: `init_module' previously defined
here
drivers/usb/host/ohci-ppc-of.c:283: error: redefinition of `__exittest'
drivers/usb/host/ohci-pci.c:260: error: `__exittest' previously defined here
drivers/usb/host/ohci-ppc-of.c:283: error: redefinition of `cleanup_module'
drivers/usb/host/ohci-pci.c:260: error: `cleanup_module' previously
defined here

Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
occured by default on my config then we end up with two module_init()
calls, which is illegal.

powerpc-add-of_platform-support-for-ohci-bigendian-hc

I am guessing that we are only meant to be able to have one of these
defined at a time? I changed the default to n for this and I could at
least compile the kernel, but I am sure thats not the right fix.

Nicolas?

-apw

2006-11-09 15:44:34

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

On Thursday, 9 November 2006 02:04, Rafael J. Wysocki wrote:
> On Thursday, 9 November 2006 01:55, Andrew Morton wrote:
> > On Thu, 9 Nov 2006 01:44:53 +0100
> > "Rafael J. Wysocki" <[email protected]> wrote:
> >
> > > On Thursday, 9 November 2006 01:17, Andrew Morton wrote:
> > > > On Thu, 9 Nov 2006 00:31:34 +0100
> > > > "Rafael J. Wysocki" <[email protected]> wrote:
> > > >
> > > > > On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> > > > > >
> > > > > > Temporarily at
> > > > > >
> > > > > > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> > > > > >
> > > > > > will turn up at
> > > > > >
> > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> > > > > >
> > > > > > when kernel.org mirroring catches up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > > > > > userspace tools, instructions, etc.
> > > > > >
> > > > > > It needs a recent binutils to build.
> > > > > >
> > > > > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > > > > their TSC in low-power states.
> > > > >
> > > > > On my HPC nx6325 it doesn't even reach the point in which the messages become
> > > > > visible on the console, so I'm unable to get any debug info from it.
> > > >
> > > > Nice. You're using earlyprintk?
> > >
> > > earlyprintk=vga doesn't show anything (ie. blank screen), so it seems to crash
> > > really early.
> >
> > OK, so it's definitely bisection time.
>
> Well, I've got some data from earlyprintk (forgot I needed to boot with
> vga=normal).
>
> Unfortunately, I had to rewrite the trace manually:
>
> clear_IO_APIC_pin+0x15/0x6a
> try_apic_pin+0x7a/0x98
> setup_IO_APIC+0x600/0xb7a
> smp_prepare_cpus+0x33a/0x371
> init+0x60/0x32d
> child_rip+0xa/0x12
>
> [And then the unwinder said it got stuck.]
>
> RIP is reported to be at ioapic_read_entry+0x33/0x61,

This is 100% reproducible on the nx6325 (but not on the other boxes) and
apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
happen with this patch reverted).

> > > but on the other SMP box the framebuffer is broken
> > > (displays all fonts inverted, as in a mirror)
> >
> > Which fbdev driver? (suspect fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch)
>
> vga=792

This indeed is caused by fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
which affects two out of three boxes on which I tested it (both have Radeon cards).

> > > and the kernel says it cannot mount the root fs (which is on an md-raid).
> >
> > hm, there was probably some earlier message which tells us why that
> > happened. Doing a capure-and-compare on the dmesg output would be nice
> > (netconsole?)

This happens because of md-change-lifetime-rules-for-md-devices.patch and
seems to be a universal breakage.

So, in fact there are three different offending patches.


--
You never change things by fighting the existing reality.
R. Buckminster Fuller

2006-11-09 17:58:32

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

On Thu, 9 Nov 2006 16:42:00 +0100
"Rafael J. Wysocki" <[email protected]> wrote:

> On Thursday, 9 November 2006 02:04, Rafael J. Wysocki wrote:
> > On Thursday, 9 November 2006 01:55, Andrew Morton wrote:
> > > On Thu, 9 Nov 2006 01:44:53 +0100
> > > "Rafael J. Wysocki" <[email protected]> wrote:
> > >
> > > > On Thursday, 9 November 2006 01:17, Andrew Morton wrote:
> > > > > On Thu, 9 Nov 2006 00:31:34 +0100
> > > > > "Rafael J. Wysocki" <[email protected]> wrote:
> > > > >
> > > > > > On Wednesday, 8 November 2006 10:54, Andrew Morton wrote:
> > > > > > >
> > > > > > > Temporarily at
> > > > > > >
> > > > > > > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> > > > > > >
> > > > > > > will turn up at
> > > > > > >
> > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> > > > > > >
> > > > > > > when kernel.org mirroring catches up.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > - Merged the Kernel-based Virtual Machine patches. See kvm.sf.net for
> > > > > > > userspace tools, instructions, etc.
> > > > > > >
> > > > > > > It needs a recent binutils to build.
> > > > > > >
> > > > > > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > > > > > their TSC in low-power states.
> > > > > >
> > > > > > On my HPC nx6325 it doesn't even reach the point in which the messages become
> > > > > > visible on the console, so I'm unable to get any debug info from it.
> > > > >
> > > > > Nice. You're using earlyprintk?
> > > >
> > > > earlyprintk=vga doesn't show anything (ie. blank screen), so it seems to crash
> > > > really early.
> > >
> > > OK, so it's definitely bisection time.
> >
> > Well, I've got some data from earlyprintk (forgot I needed to boot with
> > vga=normal).
> >
> > Unfortunately, I had to rewrite the trace manually:
> >
> > clear_IO_APIC_pin+0x15/0x6a
> > try_apic_pin+0x7a/0x98
> > setup_IO_APIC+0x600/0xb7a
> > smp_prepare_cpus+0x33a/0x371
> > init+0x60/0x32d
> > child_rip+0xa/0x12
> >
> > [And then the unwinder said it got stuck.]
> >
> > RIP is reported to be at ioapic_read_entry+0x33/0x61,
>
> This is 100% reproducible on the nx6325 (but not on the other boxes) and
> apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
> happen with this patch reverted).

Thanks, dropped.

> > > > but on the other SMP box the framebuffer is broken
> > > > (displays all fonts inverted, as in a mirror)
> > >
> > > Which fbdev driver? (suspect fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch)
> >
> > vga=792
>
> This indeed is caused by fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
> which affects two out of three boxes on which I tested it (both have Radeon cards).

Thanks, dropped.

> > > > and the kernel says it cannot mount the root fs (which is on an md-raid).
> > >
> > > hm, there was probably some earlier message which tells us why that
> > > happened. Doing a capure-and-compare on the dmesg output would be nice
> > > (netconsole?)
>
> This happens because of md-change-lifetime-rules-for-md-devices.patch and
> seems to be a universal breakage.

Thanks, dropped.

> So, in fact there are three different offending patches.

Should now be zero (hah).

2006-11-09 18:43:25

by Benoit Boissinot

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On 11/8/06, Andrew Morton <[email protected]> wrote:
>
> Temporarily at
>
> http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
>
> will turn up at
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
>
> when kernel.org mirroring catches up.
>

I got the following oops when undocking my laptop:

[27525.704000] ACPI: undocking
[27526.076000] usb 3-1: USB disconnect, address 2
[27526.228000] usb 4-3: USB disconnect, address 2
[27526.232000] BUG: unable to handle kernel paging request at virtual
address 00200200
[27526.232000] printing eip:
[27526.232000] e8074e26
[27526.232000] *pde = 00000000
[27526.232000] Oops: 0002 [#1]
[27526.232000] last sysfs file: /class/net/eth0/carrier
[27526.232000] Modules linked in: af_packet binfmt_misc rfcomm l2cap
bluetooth ipv6 capability commoncap i915 drm acpi_cpufreq
cpufreq_userspace cpufreq_stats cpufreq_powersave cpufreq_ondemand
freq_table cpufreq_conservative video output sr_mod cdrom sbs
sony_acpi i2c_ec i2c_core button dock battery container ac backlight
dm_mod md_mod sbp2 lp shpchp pci_hotplug sg usb_storage joydev tsdev
libusual pcmcia usbhid irda evdev crc_ccitt psmouse serio_raw
snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss
ata_generic snd_pcm snd_timer ipw2200 parport_pc parport snd soundcore
snd_page_alloc intel_agp agpgart pcspkr ieee80211 ieee80211_crypt
yenta_socket rsrc_nonstatic pcmcia_core tg3 iTCO_wdt rtc ext3 jbd
mbcache ohci1394 ieee1394 ehci_hcd uhci_hcd usbcore sd_mod ata_piix
libata scsi_mod thermal processor fan
[27526.232000] CPU: 0
[27526.232000] EIP: 0060:[<e8074e26>] Not tainted VLI
[27526.232000] EFLAGS: 00010002 (2.6.19-rc5-mm1 #18)
[27526.232000] EIP is at
scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod]
[27526.232000] eax: e3d88890 ebx: e3d88808 ecx: 00100100 edx: 00200200
[27526.232000] esi: 00000286 edi: e3d88800 ebp: e45bd014 esp: dfdb1e3c
[27526.232000] ds: 007b es: 007b ss: 0068
[27526.232000] Process khubd (pid: 1739, ti=dfdb0000 task=dfe4f030
task.ti=dfdb0000)
[27526.232000] Stack: e3d88a64 e8074df0 c0374580 e45bd07c c01280e2
e3d888f8 c03745dc c0233182
[27526.232000] c03745dc e3d888f8 c03745dc c0374580 c01d53e9
e3d88910 c01d5430 e425ec28
[27526.232000] ffffffed c01d6065 e3d88890 e425ec28 ffffffed
e8074667 e425ec00 00000202
[27526.232000] Call Trace:
[27526.232000] [<e8074df0>]
scsi_device_dev_release_usercontext+0x0/0x100 [scsi_mod]
[27526.232000] [execute_in_process_context+34/112]
execute_in_process_context+0x22/0x70
[27526.232000] [device_release+18/112] device_release+0x12/0x70
[27526.232000] [kobject_cleanup+73/144] kobject_cleanup+0x49/0x90
[27526.232000] [kobject_release+0/16] kobject_release+0x0/0x10
[27526.232000] [kref_put+53/160] kref_put+0x35/0xa0
[27526.232000] [<e8074667>] __scsi_remove_device+0x67/0x80 [scsi_mod]
[27526.232000] [<e8073a33>] scsi_forget_host+0x43/0x50 [scsi_mod]
[27526.232000] [<e806c6f2>] scsi_remove_host+0x32/0xb0 [scsi_mod]
[27526.232000] [<e83c9c5e>] storage_disconnect+0xe/0x20 [usb_storage]
[27526.232000] [<e80e095f>] usb_unbind_interface+0x4f/0xa0 [usbcore]
[27526.232000] [__device_release_driver+100/144]
__device_release_driver+0x64/0x90
[27526.232000] [device_release_driver+34/64] device_release_driver+0x22/0x40
[27526.232000] [bus_remove_device+92/144] bus_remove_device+0x5c/0x90
[27526.232000] [device_del+327/416] device_del+0x147/0x1a0
[27526.232000] [<e80ddf78>] usb_disable_device+0x78/0xe0 [usbcore]
[27526.232000] [<e80da614>] usb_disconnect+0x94/0xe0 [usbcore]
[27526.232000] [<e80db260>] hub_thread+0x200/0xc40 [usbcore]
[27526.232000] [autoremove_wake_function+0/80]
autoremove_wake_function+0x0/0x50
[27526.232000] [<e80db060>] hub_thread+0x0/0xc40 [usbcore]
[27526.232000] [kthread+169/224] kthread+0xa9/0xe0
[27526.232000] [kthread+0/224] kthread+0x0/0xe0
[27526.232000] [kernel_thread_helper+7/28] kernel_thread_helper+0x7/0x1c
[27526.232000] =======================
[27526.232000] Code: ff ff 89 1c 24 89 74 24 04 89 6c 24 0c 8b 68 64
8d 55 ec 9c 5e fa ff 82 58 01 00 00 8d 98 78 ff ff ff 8b 53 04 8b 88
78 ff ff ff <89> 0a 89 51 04 b9 00 01 10 00 c7 43 04 00 02 20 00 8d 58
80 8b
[27526.232000] EIP: [<e8074e26>]
scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
0068:dfdb1e3c

full dmesg attached, I can test patches and provide any useful
information if needed (just not now because the dock is at work).

thanks,

Benoit


Attachments:
(No filename) (4.35 kB)
kern.log.gz (10.04 kB)
Download all attachments

2006-11-09 19:05:05

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1


(added linux-scsi)

On Thu, 9 Nov 2006 19:43:17 +0100
"Benoit Boissinot" <[email protected]> wrote:

> On 11/8/06, Andrew Morton <[email protected]> wrote:
> >
> > Temporarily at
> >
> > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> >
> > will turn up at
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> >
> > when kernel.org mirroring catches up.
> >
>
> I got the following oops when undocking my laptop:
>
> [27525.704000] ACPI: undocking
> [27526.076000] usb 3-1: USB disconnect, address 2
> [27526.228000] usb 4-3: USB disconnect, address 2
> [27526.232000] BUG: unable to handle kernel paging request at virtual
> address 00200200
> [27526.232000] printing eip:
> [27526.232000] e8074e26
> [27526.232000] *pde = 00000000
> [27526.232000] Oops: 0002 [#1]
> [27526.232000] last sysfs file: /class/net/eth0/carrier
> [27526.232000] Modules linked in: af_packet binfmt_misc rfcomm l2cap
> bluetooth ipv6 capability commoncap i915 drm acpi_cpufreq
> cpufreq_userspace cpufreq_stats cpufreq_powersave cpufreq_ondemand
> freq_table cpufreq_conservative video output sr_mod cdrom sbs
> sony_acpi i2c_ec i2c_core button dock battery container ac backlight
> dm_mod md_mod sbp2 lp shpchp pci_hotplug sg usb_storage joydev tsdev
> libusual pcmcia usbhid irda evdev crc_ccitt psmouse serio_raw
> snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss
> ata_generic snd_pcm snd_timer ipw2200 parport_pc parport snd soundcore
> snd_page_alloc intel_agp agpgart pcspkr ieee80211 ieee80211_crypt
> yenta_socket rsrc_nonstatic pcmcia_core tg3 iTCO_wdt rtc ext3 jbd
> mbcache ohci1394 ieee1394 ehci_hcd uhci_hcd usbcore sd_mod ata_piix
> libata scsi_mod thermal processor fan
> [27526.232000] CPU: 0
> [27526.232000] EIP: 0060:[<e8074e26>] Not tainted VLI
> [27526.232000] EFLAGS: 00010002 (2.6.19-rc5-mm1 #18)
> [27526.232000] EIP is at
> scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod]
> [27526.232000] eax: e3d88890 ebx: e3d88808 ecx: 00100100 edx: 00200200
> [27526.232000] esi: 00000286 edi: e3d88800 ebp: e45bd014 esp: dfdb1e3c
> [27526.232000] ds: 007b es: 007b ss: 0068
> [27526.232000] Process khubd (pid: 1739, ti=dfdb0000 task=dfe4f030
> task.ti=dfdb0000)
> [27526.232000] Stack: e3d88a64 e8074df0 c0374580 e45bd07c c01280e2
> e3d888f8 c03745dc c0233182
> [27526.232000] c03745dc e3d888f8 c03745dc c0374580 c01d53e9
> e3d88910 c01d5430 e425ec28
> [27526.232000] ffffffed c01d6065 e3d88890 e425ec28 ffffffed
> e8074667 e425ec00 00000202
> [27526.232000] Call Trace:
> [27526.232000] [<e8074df0>]
> scsi_device_dev_release_usercontext+0x0/0x100 [scsi_mod]
> [27526.232000] [execute_in_process_context+34/112]
> execute_in_process_context+0x22/0x70
> [27526.232000] [device_release+18/112] device_release+0x12/0x70
> [27526.232000] [kobject_cleanup+73/144] kobject_cleanup+0x49/0x90
> [27526.232000] [kobject_release+0/16] kobject_release+0x0/0x10
> [27526.232000] [kref_put+53/160] kref_put+0x35/0xa0
> [27526.232000] [<e8074667>] __scsi_remove_device+0x67/0x80 [scsi_mod]
> [27526.232000] [<e8073a33>] scsi_forget_host+0x43/0x50 [scsi_mod]
> [27526.232000] [<e806c6f2>] scsi_remove_host+0x32/0xb0 [scsi_mod]
> [27526.232000] [<e83c9c5e>] storage_disconnect+0xe/0x20 [usb_storage]
> [27526.232000] [<e80e095f>] usb_unbind_interface+0x4f/0xa0 [usbcore]
> [27526.232000] [__device_release_driver+100/144]
> __device_release_driver+0x64/0x90
> [27526.232000] [device_release_driver+34/64] device_release_driver+0x22/0x40
> [27526.232000] [bus_remove_device+92/144] bus_remove_device+0x5c/0x90
> [27526.232000] [device_del+327/416] device_del+0x147/0x1a0
> [27526.232000] [<e80ddf78>] usb_disable_device+0x78/0xe0 [usbcore]
> [27526.232000] [<e80da614>] usb_disconnect+0x94/0xe0 [usbcore]
> [27526.232000] [<e80db260>] hub_thread+0x200/0xc40 [usbcore]
> [27526.232000] [autoremove_wake_function+0/80]
> autoremove_wake_function+0x0/0x50
> [27526.232000] [<e80db060>] hub_thread+0x0/0xc40 [usbcore]
> [27526.232000] [kthread+169/224] kthread+0xa9/0xe0
> [27526.232000] [kthread+0/224] kthread+0x0/0xe0
> [27526.232000] [kernel_thread_helper+7/28] kernel_thread_helper+0x7/0x1c
> [27526.232000] =======================
> [27526.232000] Code: ff ff 89 1c 24 89 74 24 04 89 6c 24 0c 8b 68 64
> 8d 55 ec 9c 5e fa ff 82 58 01 00 00 8d 98 78 ff ff ff 8b 53 04 8b 88
> 78 ff ff ff <89> 0a 89 51 04 b9 00 01 10 00 c7 43 04 00 02 20 00 8d 58
> 80 8b
> [27526.232000] EIP: [<e8074e26>]
> scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> 0068:dfdb1e3c
>
> full dmesg attached, I can test patches and provide any useful
> information if needed (just not now because the dock is at work).

You're the second or third person to report this (to no effect, btw).
Other reports have been with USB-unplug, so I doubt if the docking code is
involved.

2006-11-09 19:27:29

by Mattia Dongili

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
>
> (added linux-scsi)
[...]
> > [27526.232000] EIP: [<e8074e26>]
> > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > 0068:dfdb1e3c
> >
> > full dmesg attached, I can test patches and provide any useful
> > information if needed (just not now because the dock is at work).
>
> You're the second or third person to report this (to no effect, btw).

oh, great. I was going to report the same (had with usb key unplug).
Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
...
usb 5-1: new high speed USB device using ehci_hcd and address 8
usb 5-1: new device found, idVendor=0c76, idProduct=0005
usb 5-1: new device strings: Mfr=1, Product=2, SerialNumber=3
usb 5-1: Product: FlashDisk
usb 5-1: Manufacturer: USBDisk
usb 5-1: SerialNumber: 0608120154580
usb 5-1: configuration #1 chosen from 1 choice
scsi3 : SCSI emulation for USB Mass Storage devices
usb-storage: device found at 8
usb-storage: waiting for device to settle before scanning
scsi 3:0:0:0: Direct-Access USBDisk FlashDisk 1.00 PQ: 0 ANSI: 2
SCSI device sdc: 2002000 512-byte hdwr sectors (1025 MB)
sdc: Write Protect is off
sdc: Mode Sense: 0b 00 00 08
sdc: assuming drive cache: write through
SCSI device sdc: 2002000 512-byte hdwr sectors (1025 MB)
sdc: Write Protect is off
sdc: Mode Sense: 0b 00 00 08
sdc: assuming drive cache: write through
sdc: sdc1
sd 3:0:0:0: Attached scsi removable disk sdc
usb-storage: device scan complete
usb 5-1: USB disconnect, address 8
BUG: unable to handle kernel paging request at virtual address 00100104
printing eip:
c024831f
*pde = 00000000
Oops: 0002 [#1]
SMP
last sysfs file: /devices/pci0000:00/0000:00:1d.7/usb5/5-1/idVendor
Modules linked in: ipv6 cpufreq_ondemand acpi_cpufreq freq_table thermal fan button processor ac battery ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack nfnetlink iptable_filter ip_tables x_tables usbhid hci_usb bluetooth dm_snapshot dm_mirror dm_mod sbp2 loop eth1394 usb_storage pcmcia snd_hda_intel snd_hda_codec snd_pcm_oss snd_mixer_oss ipw3945 tpm_infineon tpm ieee80211 ieee80211_crypt yenta_socket i2c_i801 ide_cd ohci1394 firmware_class intel_agp agpgart tpm_bios pcspkr ehci_hcd evdev sky2 ieee1394 uhci_hcd rsrc_nonstatic tifm_7xx1 tifm_core snd_pcm rtc psmouse pcmcia_core snd_timer usbcore snd soundcore snd_page_alloc cdrom
CPU: 0
EIP: 0060:[<c024831f>] Not tainted VLI
EFLAGS: 00010002 (2.6.19-rc5-mm1-1 #4)
EIP is at scsi_device_dev_release_usercontext+0x41/0xfa
eax: 00200200 ebx: f7824094 ecx: 00100100 edx: 00000286
esi: f7824008 edi: f7824000 ebp: f78bddc0 esp: f78bddb0
ds: 007b es: 007b ss: 0068
Process khubd (pid: 756, ti=f78bc000 task=c1990a70 task.ti=f78bc000)
Stack: f7f05014 f7824284 c02482de c032e6e0 f78bddd0 c012d897 f782410c c032e748
f78bddd8 c024754d f78bddf0 c022f74d c01d1b6e f782410c c032e748 c032e6e0
f78bde08 c01d1b54 f7f0508c f7824124 c01d1b74 00000246 f78bde10 c01d1b7f
Call Trace:
[<c012d897>] execute_in_process_context+0x1d/0x4e
[<c024754d>] scsi_device_dev_release+0x15/0x17
[<c022f74d>] device_release+0x29/0x6b
[<c01d1b54>] kobject_cleanup+0x46/0x66
[<c01d1b7f>] kobject_release+0xb/0xd
[<c01d263b>] kref_put+0x7f/0x90
[<c01d1b0c>] kobject_put+0x14/0x16
[<c022f829>] put_device+0xf/0x11
[<c0247c49>] __scsi_remove_device+0x5e/0x62
[<c02458cc>] scsi_forget_host+0x30/0x4f
[<c02410c5>] scsi_remove_host+0x6a/0xdd
[<f8e3f6c7>] quiesce_and_remove_host+0x8f/0x94 [usb_storage]
[<f8e3f789>] storage_disconnect+0x11/0x1b [usb_storage]
[<f8d338c2>] usb_unbind_interface+0x4c/0x94 [usbcore]
[<c02314c7>] __device_release_driver+0x71/0x86
[<c0231895>] device_release_driver+0x26/0x3d
[<c0230f29>] bus_remove_device+0x5e/0x6c
[<c022fbd2>] device_del+0x104/0x15a
[<f8d314a8>] usb_disable_device+0x5f/0xbc [usbcore]
[<f8d2e1be>] usb_disconnect+0x8b/0xe7 [usbcore]
[<f8d2edd5>] hub_thread+0x397/0xa50 [usbcore]
[<c01307e2>] kthread+0xb5/0xdf
[<c0103a0f>] kernel_thread_helper+0x7/0x10
DWARF2 unwinder stuck at kernel_thread_helper+0x7/0x10
Leftover inexact backtrace:
[<c0103ee9>] show_trace_log_lvl+0x1a/0x2f
[<c0103f9b>] show_stack_log_lvl+0x9d/0xa5
[<c0104168>] show_registers+0x1c5/0x29b
[<c0104354>] die+0x116/0x22e
[<c0117c57>] do_page_fault+0x446/0x51f
[<c02c5a4c>] error_code+0x7c/0x84
[<c012d897>] execute_in_process_context+0x1d/0x4e
[<c024754d>] scsi_device_dev_release+0x15/0x17
[<c022f74d>] device_release+0x29/0x6b
[<c01d1b54>] kobject_cleanup+0x46/0x66
[<c01d1b7f>] kobject_release+0xb/0xd
[<c01d263b>] kref_put+0x7f/0x90
[<c01d1b0c>] kobject_put+0x14/0x16
[<c022f829>] put_device+0xf/0x11
[<c0247c49>] __scsi_remove_device+0x5e/0x62
[<c02458cc>] scsi_forget_host+0x30/0x4f
[<c02410c5>] scsi_remove_host+0x6a/0xdd
[<f8e3f6c7>] quiesce_and_remove_host+0x8f/0x94 [usb_storage]
[<f8e3f789>] storage_disconnect+0x11/0x1b [usb_storage]
[<f8d338c2>] usb_unbind_interface+0x4c/0x94 [usbcore]
[<c02314c7>] __device_release_driver+0x71/0x86
[<c0231895>] device_release_driver+0x26/0x3d
[<c0230f29>] bus_remove_device+0x5e/0x6c
[<c022fbd2>] device_del+0x104/0x15a
[<f8d314a8>] usb_disable_device+0x5f/0xbc [usbcore]
[<f8d2e1be>] usb_disconnect+0x8b/0xe7 [usbcore]
[<f8d2edd5>] hub_thread+0x397/0xa50 [usbcore]
[<c01307e2>] kthread+0xb5/0xdf
[<c0103a0f>] kernel_thread_helper+0x7/0x10
=======================
Code: f0 89 c6 8b 83 6c ff ff ff 83 ee 14 8b 40 2c e8 b5 d4 07 00 ff 86 70 01 00 00 8d b3 74 ff ff ff 8b 8b 74 ff ff ff 89 c2 8b 46 04 <89> 41 04 89 08 c7 46 04 00 02 20 00 8d b3 7c ff ff ff 8b 8b 7c
EIP: [<c024831f>] scsi_device_dev_release_usercontext+0x41/0xfa SS:ESP 0068:f78bddb0


> Other reports have been with USB-unplug, so I doubt if the docking code is
> involved.

full dmesg is here:
http://oioio.altervista.org/linux/dmesg_usbkey_remove
and .config:
http://oioio.altervista.org/linux/config-2.6.19-rc5-mm1-1

--
mattia
:wq!

2006-11-09 21:58:35

by Alan Stern

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

On Thu, 9 Nov 2006, Mattia Dongili wrote:

> On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> >
> > (added linux-scsi)
> [...]
> > > [27526.232000] EIP: [<e8074e26>]
> > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > 0068:dfdb1e3c
> > >
> > > full dmesg attached, I can test patches and provide any useful
> > > information if needed (just not now because the dock is at work).
> >
> > You're the second or third person to report this (to no effect, btw).
>
> oh, great. I was going to report the same (had with usb key unplug).
> Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006

I don't know exactly where the problem lies, but I have narrowed it down.

In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the
device's refcount by 1. However in sd_remove(), the call to del_gendisk()
decreases the device's refcount by 2. Consequently the structure is
deallocated too early, causing the oops.

Somebody who knows more than I do about add_disk() and del_gendisk() will
have to figure what's going wrong.

Alan Stern

2006-11-09 22:44:07

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure


> Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
> default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
> occured by default on my config then we end up with two module_init()
> calls, which is illegal.
>
> powerpc-add-of_platform-support-for-ohci-bigendian-hc
>
> I am guessing that we are only meant to be able to have one of these
> defined at a time? I changed the default to n for this and I could at
> least compile the kernel, but I am sure thats not the right fix.

Paul, which patch did you merge ? I rejected the initial one that was
doing 2 drivers/probe routines and Nicolas did a new one.. You may have
taken the wrong one.

Cheers.
Ben.

2006-11-09 22:51:17

by Andrew Morton

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

On Thu, 9 Nov 2006 16:58:31 -0500 (EST)
Alan Stern <[email protected]> wrote:

> On Thu, 9 Nov 2006, Mattia Dongili wrote:
>
> > On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> > >
> > > (added linux-scsi)
> > [...]
> > > > [27526.232000] EIP: [<e8074e26>]
> > > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > > 0068:dfdb1e3c
> > > >
> > > > full dmesg attached, I can test patches and provide any useful
> > > > information if needed (just not now because the dock is at work).
> > >
> > > You're the second or third person to report this (to no effect, btw).
> >
> > oh, great. I was going to report the same (had with usb key unplug).
> > Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
>
> I don't know exactly where the problem lies, but I have narrowed it down.
>
> In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the
> device's refcount by 1. However in sd_remove(), the call to del_gendisk()
> decreases the device's refcount by 2. Consequently the structure is
> deallocated too early, causing the oops.
>
> Somebody who knows more than I do about add_disk() and del_gendisk() will
> have to figure what's going wrong.
>

hm. Maybe it's the disk_sysfs_symlinks() changes.

Could someone who can reproduce this please try this revert, on
2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?



fs/partitions/check.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
--- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
+++ a/fs/partitions/check.c
@@ -416,7 +416,7 @@ static char *make_block_name(struct gend

static int disk_sysfs_symlinks(struct gendisk *disk)
{
- struct device *target = disk->driverfs_dev;
+ struct device *target = get_device(disk->driverfs_dev);
int err;
char *disk_name = NULL;

@@ -452,8 +452,9 @@ err_out_dev_link:
sysfs_remove_link(&disk->kobj, "device");
err_out_disk_name:
kfree(disk_name);
- }
err_out:
+ put_device(target);
+ }
return err;
}

_

2006-11-09 23:42:13

by Cédric Augonnet

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

2006/11/9, Andrew Morton <[email protected]>:

>
> hm. Maybe it's the disk_sysfs_symlinks() changes.
>
> Could someone who can reproduce this please try this revert, on
> 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
>
>
>
> fs/partitions/check.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
> --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
> +++ a/fs/partitions/check.c
> @@ -416,7 +416,7 @@ static char *make_block_name(struct gend
>
> static int disk_sysfs_symlinks(struct gendisk *disk)
> {
> - struct device *target = disk->driverfs_dev;
> + struct device *target = get_device(disk->driverfs_dev);
> int err;
> char *disk_name = NULL;
>
> @@ -452,8 +452,9 @@ err_out_dev_link:
> sysfs_remove_link(&disk->kobj, "device");
> err_out_disk_name:
> kfree(disk_name);
> - }
> err_out:
> + put_device(target);
> + }
> return err;
> }
>
> _
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

Hi,

This patch seems to be working : whereas i had the same oops as Mattia
each time I unplugged my USB external DD drive, now it does not happen
anymore.
Thank you very much for this one !

Best regards,
C?dric

2006-11-10 00:11:36

by Andrew Morton

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

On Fri, 10 Nov 2006 00:39:46 +0100
"C__dric Augonnet" <[email protected]> wrote:

> 2006/11/9, Andrew Morton <[email protected]>:
>
> >
> > hm. Maybe it's the disk_sysfs_symlinks() changes.
> >
> > Could someone who can reproduce this please try this revert, on
> > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
> >
> >
> >
> > fs/partitions/check.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
> > --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
> > +++ a/fs/partitions/check.c
> > @@ -416,7 +416,7 @@ static char *make_block_name(struct gend
> >
> > static int disk_sysfs_symlinks(struct gendisk *disk)
> > {
> > - struct device *target = disk->driverfs_dev;
> > + struct device *target = get_device(disk->driverfs_dev);
> > int err;
> > char *disk_name = NULL;
> >
> > @@ -452,8 +452,9 @@ err_out_dev_link:
> > sysfs_remove_link(&disk->kobj, "device");
> > err_out_disk_name:
> > kfree(disk_name);
> > - }
> > err_out:
> > + put_device(target);
> > + }
> > return err;
> > }
> >
> > _
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
> Hi,
>
> This patch seems to be working : whereas i had the same oops as Mattia
> each time I unplugged my USB external DD drive, now it does not happen
> anymore.
> Thank you very much for this one !
>

OK, thanks. I dropped the patch. So ide-cs will now start deadlocking
again.

2006-11-10 03:10:47

by Ed Tomlinson

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Wednesday 08 November 2006 04:54, Andrew Morton wrote:
> -radeonfb-support-24bpp-32bpp-minus-alpha.patch
>
>  Dropped
>
> +various-fbdev-files-mark-structs-fix.patch
>
>  Fix various-fbdev-files-mark-structs.patch
>
> +fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
>
>  fbdev fix

Strongly suspect that something is not right with these patches. I have a:

01:00.0 VGA compatible controller: ATI Technologies Inc RV280 [Radeon 9200] (rev 01) (prog-if 00 [VGA])
Subsystem: ATI Technologies Inc Unknown device 2002
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (2000ns min), Cache Line Size 08
Interrupt: pin A routed to IRQ 16
Region 0: Memory at d0000000 (32-bit, prefetchable) [size=128M]
Region 1: I/O ports at 8000 [size=256]
Region 2: Memory at e9010000 (32-bit, non-prefetchable) [size=64K]
[virtual] Expansion ROM at e8000000 [disabled] [size=128K]
Capabilities: [58] AGP version 3.0
Status: RQ=256 Iso- ArqSz=0 Cal=0 SBA+ ITACoh- GART64- HTrans- 64bit- FW+ AGP3+ Rate=x4,x8
Command: RQ=32 ArqSz=2 Cal=0 SBA+ AGP+ GART64- 64bit- FW- Rate=x8
Capabilities: [50] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-

booting with:

kernel /boot/2.6.19-rc5-mm1 root=/dev/sda3 vga=0x318 video=vesafb:ywrap,mtrr:3 console=tty0 console=ttyS0,38400 nmi_watchdog=1

gives a strangely corrupted screen. The characters seem reversed...

What else can help?

Ed Tomlinson

2006-11-10 03:32:09

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thu, 9 Nov 2006 22:21:49 -0500
Ed Tomlinson <[email protected]> wrote:

> On Wednesday 08 November 2006 04:54, Andrew Morton wrote:
> > -radeonfb-support-24bpp-32bpp-minus-alpha.patch
> >
> > ?Dropped
> >
> > +various-fbdev-files-mark-structs-fix.patch
> >
> > ?Fix various-fbdev-files-mark-structs.patch
> >
> > +fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
> >
> > ?fbdev fix
>
> Strongly suspect that something is not right with these patches. I have a:
>
> 01:00.0 VGA compatible controller: ATI Technologies Inc RV280 [Radeon 9200] (rev 01) (prog-if 00 [VGA])
> Subsystem: ATI Technologies Inc Unknown device 2002
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
> Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
> Latency: 32 (2000ns min), Cache Line Size 08
> Interrupt: pin A routed to IRQ 16
> Region 0: Memory at d0000000 (32-bit, prefetchable) [size=128M]
> Region 1: I/O ports at 8000 [size=256]
> Region 2: Memory at e9010000 (32-bit, non-prefetchable) [size=64K]
> [virtual] Expansion ROM at e8000000 [disabled] [size=128K]
> Capabilities: [58] AGP version 3.0
> Status: RQ=256 Iso- ArqSz=0 Cal=0 SBA+ ITACoh- GART64- HTrans- 64bit- FW+ AGP3+ Rate=x4,x8
> Command: RQ=32 ArqSz=2 Cal=0 SBA+ AGP+ GART64- 64bit- FW- Rate=x8
> Capabilities: [50] Power Management version 2
> Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
> Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>
> booting with:
>
> kernel /boot/2.6.19-rc5-mm1 root=/dev/sda3 vga=0x318 video=vesafb:ywrap,mtrr:3 console=tty0 console=ttyS0,38400 nmi_watchdog=1
>
> gives a strangely corrupted screen. The characters seem reversed...
>

Yup, thanks. You'll need to revert
fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch:'


diff -puN drivers/video/cfbimgblt.c~revert-fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit drivers/video/cfbimgblt.c
--- a/drivers/video/cfbimgblt.c~revert-fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit
+++ a/drivers/video/cfbimgblt.c
@@ -168,7 +168,7 @@ static inline void slow_imageblit(const

while (j--) {
l--;
- color = (*s & (1 << FB_BIT_NR(l))) ? fgcolor : bgcolor;
+ color = (*s & (1 << l)) ? fgcolor : bgcolor;
val |= FB_SHIFT_HIGH(color, shift);

/* Did the bitshift spill bits to the next long? */
@@ -258,7 +258,7 @@ static inline void fast_imageblit(const
s += spitch;
}
}
-
+
void cfb_imageblit(struct fb_info *p, const struct fb_image *image)
{
u32 fgcolor, bgcolor, start_index, bitstart, pitch_index = 0;
diff -puN include/linux/fb.h~revert-fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit include/linux/fb.h
--- a/include/linux/fb.h~revert-fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit
+++ a/include/linux/fb.h
@@ -854,12 +854,10 @@ struct fb_info {
#endif

#if defined (__BIG_ENDIAN)
-#define FB_BIT_NR(b) (b)
#define FB_LEFT_POS(bpp) (32 - bpp)
#define FB_SHIFT_HIGH(val, bits) ((val) >> (bits))
#define FB_SHIFT_LOW(val, bits) ((val) << (bits))
#else
-#define FB_BIT_NR(b) (7 - (b))
#define FB_LEFT_POS(bpp) (0)
#define FB_SHIFT_HIGH(val, bits) ((val) << (bits))
#define FB_SHIFT_LOW(val, bits) ((val) >> (bits))
_

2006-11-10 04:51:38

by Andi Kleen

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem


> > >
> > > Well, I've got some data from earlyprintk (forgot I needed to boot with
> > > vga=normal).
> > >
> > > Unfortunately, I had to rewrite the trace manually:
> > >
> > > clear_IO_APIC_pin+0x15/0x6a
> > > try_apic_pin+0x7a/0x98
> > > setup_IO_APIC+0x600/0xb7a
> > > smp_prepare_cpus+0x33a/0x371
> > > init+0x60/0x32d
> > > child_rip+0xa/0x12
> > >
> > > [And then the unwinder said it got stuck.]
> > >
> > > RIP is reported to be at ioapic_read_entry+0x33/0x61,
> >
> > This is 100% reproducible on the nx6325 (but not on the other boxes) and
> > apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
> > happen with this patch reverted).
>
> Thanks, dropped.

can I have details please?

On what system (CPU, motherboard, BIOS version) does the noidlehz stuff break?
And what did you drop exactly?


Thanks,

-Andi

2006-11-10 05:15:51

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

On Fri, 10 Nov 2006 05:49:08 +0100
Andi Kleen <[email protected]> wrote:

>
> > > >
> > > > Well, I've got some data from earlyprintk (forgot I needed to boot with
> > > > vga=normal).
> > > >
> > > > Unfortunately, I had to rewrite the trace manually:
> > > >
> > > > clear_IO_APIC_pin+0x15/0x6a
> > > > try_apic_pin+0x7a/0x98
> > > > setup_IO_APIC+0x600/0xb7a
> > > > smp_prepare_cpus+0x33a/0x371
> > > > init+0x60/0x32d
> > > > child_rip+0xa/0x12
> > > >
> > > > [And then the unwinder said it got stuck.]
> > > >
> > > > RIP is reported to be at ioapic_read_entry+0x33/0x61,
> > >
> > > This is 100% reproducible on the nx6325 (but not on the other boxes) and
> > > apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
> > > happen with this patch reverted).
> >
> > Thanks, dropped.
>
> can I have details please?

I think what's in this thread is all you'll get.

It would be nice to see the access address. I'd be guessing that it's
trying to read the io-apic before we're ready to read it and io_apic_base()
is returning gunk and boom.

> On what system (CPU, motherboard, BIOS version) does the noidlehz stuff break?

nx6325

It's x86_64: no noidlehz.

> And what did you drop exactly?

x86_64-mm-try-multiple-timer-pins.patch

2006-11-10 06:19:16

by Andi Kleen

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

On Friday 10 November 2006 06:15, Andrew Morton wrote:
> On Fri, 10 Nov 2006 05:49:08 +0100
> Andi Kleen <[email protected]> wrote:
>
> >
> > > > >
> > > > > Well, I've got some data from earlyprintk (forgot I needed to boot with
> > > > > vga=normal).
> > > > >
> > > > > Unfortunately, I had to rewrite the trace manually:
> > > > >
> > > > > clear_IO_APIC_pin+0x15/0x6a
> > > > > try_apic_pin+0x7a/0x98
> > > > > setup_IO_APIC+0x600/0xb7a
> > > > > smp_prepare_cpus+0x33a/0x371
> > > > > init+0x60/0x32d
> > > > > child_rip+0xa/0x12
> > > > >
> > > > > [And then the unwinder said it got stuck.]
> > > > >
> > > > > RIP is reported to be at ioapic_read_entry+0x33/0x61,
> > > >
> > > > This is 100% reproducible on the nx6325 (but not on the other boxes) and
> > > > apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
> > > > happen with this patch reverted).
> > >
> > > Thanks, dropped.
> >
> > can I have details please?
>
> I think what's in this thread is all you'll get.

That's probably not enough then.


>
> It would be nice to see the access address. I'd be guessing that it's
> trying to read the io-apic before we're ready to read it and io_apic_base()
> is returning gunk and boom.

I would like to see the full output from the earlyprintk crash please.
.jpg would be ok.

>
> > On what system (CPU, motherboard, BIOS version) does the noidlehz stuff break?
>
> nx6325

Ah -- it seems to be an ATI chipset. I tested it on a ATI chipset machine
here so it must be doing something strange.

Anyways, you most likely broke a wide range of other motherboards again
by dropping it.

>
> It's x86_64: no noidlehz.
>
> > And what did you drop exactly?
>
> x86_64-mm-try-multiple-timer-pins.patch

Ah that was the information I was missing.

-Andi

2006-11-10 09:53:47

by Paul Mackerras

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure

Benjamin Herrenschmidt writes:

> > Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
> > default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
> > occured by default on my config then we end up with two module_init()
> > calls, which is illegal.
> >
> > powerpc-add-of_platform-support-for-ohci-bigendian-hc
> >
> > I am guessing that we are only meant to be able to have one of these
> > defined at a time? I changed the default to n for this and I could at
> > least compile the kernel, but I am sure thats not the right fix.
>
> Paul, which patch did you merge ? I rejected the initial one that was
> doing 2 drivers/probe routines and Nicolas did a new one.. You may have
> taken the wrong one.

I didn't merge either of them.

Paul.

2006-11-10 10:00:08

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure

On Fri, 2006-11-10 at 20:49 +1100, Paul Mackerras wrote:
> Benjamin Herrenschmidt writes:
>
> > > Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
> > > default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
> > > occured by default on my config then we end up with two module_init()
> > > calls, which is illegal.
> > >
> > > powerpc-add-of_platform-support-for-ohci-bigendian-hc
> > >
> > > I am guessing that we are only meant to be able to have one of these
> > > defined at a time? I changed the default to n for this and I could at
> > > least compile the kernel, but I am sure thats not the right fix.
> >
> > Paul, which patch did you merge ? I rejected the initial one that was
> > doing 2 drivers/probe routines and Nicolas did a new one.. You may have
> > taken the wrong one.
>
> I didn't merge either of them.

Ah, must be Andrew then. Andrew, can you drop this (along with the other
Efika/MPC5200) patches from -mm ? They'll get in via the powerpc merge
and I'll make sure Paulus gets the right versions.

Cheers,
Ben.


2006-11-10 10:43:33

by Franck Bui-Huu

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

Andrew Morton wrote:
> On Thu, 9 Nov 2006 16:42:00 +0100
> "Rafael J. Wysocki" <[email protected]> wrote:
>
>> This indeed is caused by fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
>> which affects two out of three boxes on which I tested it (both have Radeon cards).
>
> Thanks, dropped.
>

Well I'm probably missing something but I really don't see what !

For example, let say that the four first bytes of an image are 0x06,
0xe0, 0x38, 0x00.

If
bpp = 1
start_index = 0
on a little endian platform
this patch is _not_ applied

slow_imageblit() will write into the frame buffer the following
bytes: 0x60, 0x07, 0x1c, 0x00 instead of the original ones. The bits
of each bytes have been inversed (bit7->bit0, bit6->bit1, bit5->bit2,
bit4->bit3, bit3->bit4, ...) and that's the reason why _I_ get all
fonts inverted.

With this patch applied, the bytes written into the frame buffer will
be exactly the same as the original ones. Therefore it fixes my
inverted view but broke Rafael's one.

Now, I'm very not familiar with all frame buffer stuff so I must be
missing somthing obvious. If anyone could give me some hints there
that would be nice.

Thanks
Franck

2006-11-10 11:23:47

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem

On Friday, 10 November 2006 07:19, Andi Kleen wrote:
> On Friday 10 November 2006 06:15, Andrew Morton wrote:
> > On Fri, 10 Nov 2006 05:49:08 +0100
> > Andi Kleen <[email protected]> wrote:
> >
> > >
> > > > > >
> > > > > > Well, I've got some data from earlyprintk (forgot I needed to boot with
> > > > > > vga=normal).
> > > > > >
> > > > > > Unfortunately, I had to rewrite the trace manually:
> > > > > >
> > > > > > clear_IO_APIC_pin+0x15/0x6a
> > > > > > try_apic_pin+0x7a/0x98
> > > > > > setup_IO_APIC+0x600/0xb7a
> > > > > > smp_prepare_cpus+0x33a/0x371
> > > > > > init+0x60/0x32d
> > > > > > child_rip+0xa/0x12
> > > > > >
> > > > > > [And then the unwinder said it got stuck.]
> > > > > >
> > > > > > RIP is reported to be at ioapic_read_entry+0x33/0x61,
> > > > >
> > > > > This is 100% reproducible on the nx6325 (but not on the other boxes) and
> > > > > apparently caused by x86_64-mm-try-multiple-timer-pins.patch (doesn't
> > > > > happen with this patch reverted).
> > > >
> > > > Thanks, dropped.
> > >
> > > can I have details please?
> >
> > I think what's in this thread is all you'll get.
>
> That's probably not enough then.
>
>
> >
> > It would be nice to see the access address. I'd be guessing that it's
> > trying to read the io-apic before we're ready to read it and io_apic_base()
> > is returning gunk and boom.
>
> I would like to see the full output from the earlyprintk crash please.
> .jpg would be ok.

Full is impossible, because it doesn't fit in the screen. Also JPG would be
difficult, because I have no camera here. :-(

Still I can post a dmesg log from a non-failing kernel, the output of lspci
etc. if that helps.

Greetings,
Rafael


--
You never change things by fighting the existing reality.
R. Buckminster Fuller

2006-11-10 11:51:13

by Andi Kleen

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1: HPC nx6325 breakage, VESA fb problem, md-raid problem


>
> Still I can post a dmesg log from a non-failing kernel, the output of lspci
> etc. if that helps.

No need, I can reproduce it on another test system now.

Will fix.

-Andi

2006-11-10 12:17:14

by Ed Tomlinson

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Thursday 09 November 2006 22:31, Andrew Morton wrote:
> On Thu, 9 Nov 2006 22:21:49 -0500
> Ed Tomlinson <[email protected]> wrote:
>
> > On Wednesday 08 November 2006 04:54, Andrew Morton wrote:
> > > -radeonfb-support-24bpp-32bpp-minus-alpha.patch
> > >
> > > ?Dropped
> > >
> > > +various-fbdev-files-mark-structs-fix.patch
> > >
> > > ?Fix various-fbdev-files-mark-structs.patch
> > >
> > > +fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch
> > >
> > > ?fbdev fix
> >
> > Strongly suspect that something is not right with these patches. I have a:
> >
> > 01:00.0 VGA compatible controller: ATI Technologies Inc RV280 [Radeon 9200] (rev 01) (prog-if 00 [VGA])
....
> > gives a strangely corrupted screen. The characters seem reversed...
> >
>
> Yup, thanks. You'll need to revert
> fbcon-rere-fix-little-endian-bogosity-in-slow_imageblit.patch:'

Confirmed. Reverting fixes the screen.

Thanks
Ed Tomlinson

2006-11-10 16:29:58

by Benoit Boissinot

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On 11/8/06, Andrew Morton <[email protected]> wrote:
> [snip]
> - The hrtimer+dynticks code still doesn't work right for machines which halt
> their TSC in low-power states.
>

With CONFIG_NO_HZ=y, xmoto (xmoto.sf.net, a 3d game) is sluggish, the
movement is not fluid (it is "bursty").

.config is at http://perso.ens-lyon.fr/benoit.boissinot/kernel/config-2.6.19-rc5-mm1
lspci -vv: http://perso.ens-lyon.fr/benoit.boissinot/kernel/docked_lspci
dmesg: http://perso.ens-lyon.fr/benoit.boissinot/kernel/dmesg-2.6.19-rc5-mm1

I can test any patch or provide any needed information.

regards,

Benoit

2006-11-10 16:56:52

by Thomas Gleixner

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Fri, 2006-11-10 at 17:29 +0100, Benoit Boissinot wrote:
> On 11/8/06, Andrew Morton <[email protected]> wrote:
> > [snip]
> > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > their TSC in low-power states.
> >
>
> With CONFIG_NO_HZ=y, xmoto (xmoto.sf.net, a 3d game) is sluggish, the
> movement is not fluid (it is "bursty").
>
> .config is at http://perso.ens-lyon.fr/benoit.boissinot/kernel/config-2.6.19-rc5-mm1
> lspci -vv: http://perso.ens-lyon.fr/benoit.boissinot/kernel/docked_lspci
> dmesg: http://perso.ens-lyon.fr/benoit.boissinot/kernel/dmesg-2.6.19-rc5-mm1

I'm confused about that one:

[ 8.966364] Disabling NO_HZ and high resolution timers due to timer broadcasting (C3 stops local apic)

This message is nowhere in rc5-mm1. It was in rc4-mmX, but got removed
in the updates.

> I can test any patch or provide any needed information.

http://tglx.de/private/tglx/2.6.19-rc5-mm1-dyntick.diff

That's the rework I did yesterday.

tglx


2006-11-10 17:25:51

by Benoit Boissinot

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On 11/10/06, Thomas Gleixner <[email protected]> wrote:
> On Fri, 2006-11-10 at 17:29 +0100, Benoit Boissinot wrote:
> > On 11/8/06, Andrew Morton <[email protected]> wrote:
> > > [snip]
> > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > their TSC in low-power states.
> > >
> >
> > With CONFIG_NO_HZ=y, xmoto (xmoto.sf.net, a 3d game) is sluggish, the
> > movement is not fluid (it is "bursty").
> >
> > .config is at http://perso.ens-lyon.fr/benoit.boissinot/kernel/config-2.6.19-rc5-mm1
> > lspci -vv: http://perso.ens-lyon.fr/benoit.boissinot/kernel/docked_lspci
> > dmesg: http://perso.ens-lyon.fr/benoit.boissinot/kernel/dmesg-2.6.19-rc5-mm1
>
> I'm confused about that one:
>
> [ 8.966364] Disabling NO_HZ and high resolution timers due to timer broadcasting (C3 stops local apic)
>
> This message is nowhere in rc5-mm1. It was in rc4-mmX, but got removed
> in the updates.
>
I forget to mention I reverted the following patches from -mm:
i386-apic-timer-use-clockevents-broadcast.patch
acpi-verify-lapic-timer.patch
acpi-verify-lapic-timer-exports.patch
acpi-verify-lapic-timer-fix.patch

since it did not boot with them.

> > I can test any patch or provide any needed information.
>
> http://tglx.de/private/tglx/2.6.19-rc5-mm1-dyntick.diff
>
> That's the rework I did yesterday.
>

I'll undo the reverts I did and try it on top of -mm

Thanks,

Benoit

2006-11-10 19:15:46

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

On Thu, Nov 09, 2006 at 04:11:23PM -0800, Andrew Morton wrote:
> On Fri, 10 Nov 2006 00:39:46 +0100
> "C__dric Augonnet" <[email protected]> wrote:
>
> > 2006/11/9, Andrew Morton <[email protected]>:
> >
> > >
> > > hm. Maybe it's the disk_sysfs_symlinks() changes.
> > >
> > > Could someone who can reproduce this please try this revert, on
> > > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
[...]
> >
> > Hi,
> >
> > This patch seems to be working : whereas i had the same oops as Mattia
> > each time I unplugged my USB external DD drive, now it does not happen
> > anymore.
> > Thank you very much for this one !
> >
>
> OK, thanks. I dropped the patch. So ide-cs will now start deadlocking
> again.

No, it will not. I'm really sorry, mainline was already fixed at
2.6.17-rc5 time by that commit:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=1a2acc9e9214699a99389e323e6686e9e0e2ca67

But for some reason handhelds.org kernel tree's block/genhd.c file was
unsynchronized with mainline. I've revealed that only after my patch was
removed and I've started to investigate SCSI oops issue triggered by my
patch.

Resume: mainline do not need my patch, handhelds.org's kernel should be
synchronized with mainline.

-- Anton (irc: bd2)

2006-11-10 19:29:49

by Benoit Boissinot

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1

On Thu, Nov 09, 2006 at 02:51:00PM -0800, Andrew Morton wrote:
> On Thu, 9 Nov 2006 16:58:31 -0500 (EST)
> Alan Stern <[email protected]> wrote:
> > On Thu, 9 Nov 2006, Mattia Dongili wrote:
> > > On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> > > [...]
> > > > > [27526.232000] EIP: [<e8074e26>]
> > > > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > > > 0068:dfdb1e3c
> > > > >
> > > > > full dmesg attached, I can test patches and provide any useful
> > > > > information if needed (just not now because the dock is at work).
> > > >
> > > > You're the second or third person to report this (to no effect, btw).
> > >
> > > oh, great. I was going to report the same (had with usb key unplug).
> > > Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
> >
> > I don't know exactly where the problem lies, but I have narrowed it down.
> >
> > In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the
> > device's refcount by 1. However in sd_remove(), the call to del_gendisk()
> > decreases the device's refcount by 2. Consequently the structure is
> > deallocated too early, causing the oops.
> >
> > Somebody who knows more than I do about add_disk() and del_gendisk() will
> > have to figure what's going wrong.
> >
>
> hm. Maybe it's the disk_sysfs_symlinks() changes.
>
> Could someone who can reproduce this please try this revert, on
> 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
>

I confirm it fixes it for me too.

regards,

Benoit

--
:wq

2006-11-10 20:20:29

by Benoit Boissinot

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On 11/10/06, Benoit Boissinot <[email protected]> wrote:
> On 11/10/06, Thomas Gleixner <[email protected]> wrote:
> > On Fri, 2006-11-10 at 17:29 +0100, Benoit Boissinot wrote:
> > > On 11/8/06, Andrew Morton <[email protected]> wrote:
> > > > [snip]
> > > > - The hrtimer+dynticks code still doesn't work right for machines which halt
> > > > their TSC in low-power states.
> > > >
> > >
> > > With CONFIG_NO_HZ=y, xmoto (xmoto.sf.net, a 3d game) is sluggish, the
> > > movement is not fluid (it is "bursty").
> > >
> > > .config is at http://perso.ens-lyon.fr/benoit.boissinot/kernel/config-2.6.19-rc5-mm1
> > > lspci -vv: http://perso.ens-lyon.fr/benoit.boissinot/kernel/docked_lspci
> > > dmesg: http://perso.ens-lyon.fr/benoit.boissinot/kernel/dmesg-2.6.19-rc5-mm1
> >
> > I'm confused about that one:
> >
> > [ 8.966364] Disabling NO_HZ and high resolution timers due to timer broadcasting (C3 stops local apic)
> >
> > This message is nowhere in rc5-mm1. It was in rc4-mmX, but got removed
> > in the updates.
> >
> I forget to mention I reverted the following patches from -mm:
> i386-apic-timer-use-clockevents-broadcast.patch
> acpi-verify-lapic-timer.patch
> acpi-verify-lapic-timer-exports.patch
> acpi-verify-lapic-timer-fix.patch
>
> since it did not boot with them.
>
> > > I can test any patch or provide any needed information.
> >
> > http://tglx.de/private/tglx/2.6.19-rc5-mm1-dyntick.diff
> >
> > That's the rework I did yesterday.
> >
>
> I'll undo the reverts I did and try it on top of -mm
>
It works fine with the following additional patch.

Thanks,

Benoit

Index: linux-mm/arch/i386/kernel/apic.c
===================================================================
--- a/arch/i386/kernel/apic.c 2006-11-10 20:42:30.000000000 +0100
+++ b/arch/i386/kernel/apic.c 2006-11-10 20:42:41.000000000 +0100
@@ -610,6 +610,7 @@
if (evt->event_handler)
clockevents_set_broadcast(evt, broadcast);
}
+EXPORT_SYMBOL_GPL(lapic_timer_idle_broadcast);

int setup_profiling_timer(unsigned int multiplier)
{

2006-11-10 20:39:25

by Thomas Gleixner

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Fri, 2006-11-10 at 21:20 +0100, Benoit Boissinot wrote:
> It works fine with the following additional patch.
>
> Thanks,
>
> Benoit

Doh, this modular build of ACPI again.

Acked-by: Thomas Gleixner <[email protected]>

> Index: linux-mm/arch/i386/kernel/apic.c
> ===================================================================
> --- a/arch/i386/kernel/apic.c 2006-11-10 20:42:30.000000000 +0100
> +++ b/arch/i386/kernel/apic.c 2006-11-10 20:42:41.000000000 +0100
> @@ -610,6 +610,7 @@
> if (evt->event_handler)
> clockevents_set_broadcast(evt, broadcast);
> }
> +EXPORT_SYMBOL_GPL(lapic_timer_idle_broadcast);
>
> int setup_profiling_timer(unsigned int multiplier)
> {

2006-11-13 15:58:41

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

Hello,

I tried to compile 2.6.19-rc5-mm1 on x86_64 box and it failed.
Looking at the Documentation/Changes the box tools are a bit old but
the kernel should compile. This was 'allmodconfig' with CONFIG_KVM=n
because binutils are too old for that. So either this is a bug or
Documentation/Changes should be updated soon.

LD .tmp_vmlinux1
arch/x86_64/kernel/built-in.o(.init.text+0x31b7): In function `alternative_instructions':
arch/i386/kernel/alternative.c:437: undefined reference to `__stop_parainstructions'
arch/x86_64/kernel/built-in.o(.init.text+0x31be):arch/i386/kernel/alternative.c:437: undefined reference to `__start_parainstructions'
make: *** [.tmp_vmlinux1] Error 1

Linux x 2.6.14.3-051207a #1 SMP Wed Dec 7 12:17:16 CET 2005 x86_64 x86_64 x86_64 GNU/Linux

Gnu C 3.3.5
Gnu make 3.80
binutils 2.15.94.0.2.2
util-linux 2.12q
mount 2.12q
module-init-tools 3.2-pre1
e2fsprogs 1.36
jfsutils 1.1.7
reiserfsprogs 3.6.18
xfsprogs 2.6.25
quota-tools 3.12.
Linux C Library x 1 root root 1446783 Jun 11 2005 /lib64/tls/libc.so.6
Dynamic linker (ldd) 2.3.4
Linux C++ Library 5.0.7
Procps 3.2.5
Net-tools 1.60
Kbd 1.12
Sh-utils 5.3.0
udev 053
Modules Loaded thermal fan sg ide_cd cdrom dm_mod

processor : 0
vendor_id : AuthenticAMD
cpu family : 15
model : 47
model name : AMD Athlon(tm) 64 Processor 3200+
stepping : 2
cpu MHz : 1000.045
cache size : 512 KB
fpu : yes
fpu_exception : yes
cpuid level : 1
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx mmxext fxsr_opt lm 3dnowext 3dnow pni lahf_lm
bogomips : 2002.26
TLB size : 1024 4K pages
clflush size : 64
cache_alignment : 64
address sizes : 40 bits physical, 48 bits virtual
power management: ts fid vid ttp tm stc

--
Regards,

Mariusz Kozlowski

2006-11-13 21:03:27

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] arch/i386/kernel/apic.c: make a function static

This patch makes the needlessly global local_apic_timer_interrupt()
static.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/apic.c.old 2006-11-13 17:51:59.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/apic.c 2006-11-13 17:53:14.000000000 +0100
@@ -545,7 +545,7 @@
/*
* The guts of the apic timer interrupt
*/
-fastcall void local_apic_timer_interrupt(struct pt_regs *regs)
+static fastcall void local_apic_timer_interrupt(struct pt_regs *regs)
{
int cpu = smp_processor_id();
struct clock_event_device *evt = &per_cpu(lapic_events, cpu).evdev;

2006-11-13 21:03:46

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make arch/i386/kernel/io_apic.c:timer_irq_works() static again

timer_irq_works() needlessly became global.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old 2006-11-13 18:18:37.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c 2006-11-13 18:18:54.000000000 +0100
@@ -1948,7 +1948,7 @@
* - if this function detects that timer IRQs are defunct, then we fall
* back to ISA timer IRQs
*/
-int __init timer_irq_works(void)
+static int __init timer_irq_works(void)
{
unsigned long t1 = jiffies;


2006-11-13 21:04:12

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] i386: unexport read_persistent_clock

This patch removes the unused EXPORT_SYMBOL(read_persistent_clock).

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/time.c.old 2006-11-13 18:23:40.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/time.c 2006-11-13 18:23:46.000000000 +0100
@@ -210,7 +210,6 @@

return retval;
}
-EXPORT_SYMBOL(read_persistent_clock);

static void sync_cmos_clock(unsigned long dummy);


2006-11-13 21:04:11

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make arch/i386/kernel/cpu/common.c:alloc_gdt() static

This patch makes the needlessly global alloc_gdt() static.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/cpu/common.c.old 2006-11-13 17:57:57.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/cpu/common.c 2006-11-13 17:58:35.000000000 +0100
@@ -609,7 +609,7 @@
return regs;
}

-__cpuinit int alloc_gdt(int cpu)
+static __cpuinit int alloc_gdt(int cpu)
{
struct Xgt_desc_struct *cpu_gdt_descr = &per_cpu(cpu_gdt_descr, cpu);
struct desc_struct *gdt;

2006-11-13 21:52:43

by Zachary Amsden

[permalink] [raw]
Subject: Re: [-mm patch] make arch/i386/kernel/io_apic.c:timer_irq_works() static again

Adrian Bunk wrote:
> timer_irq_works() needlessly became global.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>

Ack'd-by: Zachary Amsden <[email protected]>

2006-11-13 22:19:32

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Mon, 13 Nov 2006 16:58:05 +0100
Mariusz Kozlowski <[email protected]> wrote:

> I tried to compile 2.6.19-rc5-mm1 on x86_64 box and it failed.
> Looking at the Documentation/Changes the box tools are a bit old but
> the kernel should compile. This was 'allmodconfig' with CONFIG_KVM=n
> because binutils are too old for that. So either this is a bug or
> Documentation/Changes should be updated soon.
>
> LD .tmp_vmlinux1
> arch/x86_64/kernel/built-in.o(.init.text+0x31b7): In function `alternative_instructions':
> arch/i386/kernel/alternative.c:437: undefined reference to `__stop_parainstructions'
> arch/x86_64/kernel/built-in.o(.init.text+0x31be):arch/i386/kernel/alternative.c:437: undefined reference to `__start_parainstructions'
> make: *** [.tmp_vmlinux1] Error 1

Thanks. Please send me the .config and I'll see if it's still happening.

2006-11-13 22:27:12

by Mariusz Kozlowski

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

> > LD .tmp_vmlinux1
> > arch/x86_64/kernel/built-in.o(.init.text+0x31b7): In function
> > `alternative_instructions': arch/i386/kernel/alternative.c:437: undefined
> > reference to `__stop_parainstructions'
> > arch/x86_64/kernel/built-in.o(.init.text+0x31be):arch/i386/kernel/alterna
> >tive.c:437: undefined reference to `__start_parainstructions' make: ***
> > [.tmp_vmlinux1] Error 1
>
> Thanks. Please send me the .config and I'll see if it's still happening.

Please find .config attached.

--
Regards,

Mariusz Kozlowski


Attachments:
(No filename) (539.00 B)
.config (69.25 kB)
Download all attachments

2006-11-13 23:37:55

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.19-rc5-mm1

On Mon, 13 Nov 2006 23:26:35 +0100
Mariusz Kozlowski <[email protected]> wrote:

> > > LD .tmp_vmlinux1
> > > arch/x86_64/kernel/built-in.o(.init.text+0x31b7): In function
> > > `alternative_instructions': arch/i386/kernel/alternative.c:437: undefined
> > > reference to `__stop_parainstructions'
> > > arch/x86_64/kernel/built-in.o(.init.text+0x31be):arch/i386/kernel/alterna
> > >tive.c:437: undefined reference to `__start_parainstructions' make: ***
> > > [.tmp_vmlinux1] Error 1
> >
> > Thanks. Please send me the .config and I'll see if it's still happening.
>
> Please find .config attached.

Thanks. The paravirt patches have churned a bit recently and we appear to
have fixed this one.

2006-11-14 06:55:22

by Ingo Molnar

[permalink] [raw]
Subject: Re: [-mm patch] make arch/i386/kernel/io_apic.c:timer_irq_works() static again

On Mon, 2006-11-13 at 22:03 +0100, Adrian Bunk wrote:
> timer_irq_works() needlessly became global.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ingo Molnar <[email protected]>

Ingo

2006-11-14 06:56:30

by Ingo Molnar

[permalink] [raw]
Subject: Re: [-mm patch] arch/i386/kernel/apic.c: make a function static

On Mon, 2006-11-13 at 22:03 +0100, Adrian Bunk wrote:
> This patch makes the needlessly global local_apic_timer_interrupt()
> static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ingo Molnar <[email protected]>

Ingo