Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
request_firmware instead of sys_*. Since that is the last driver in the
kernel that uses sys_{read,close}, this patch kills these exports. sys_open
is left exported for sparc64 only.
Cc: Takashi Iwai <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Arjan van de Ven <[email protected]>
Signed-off-by: Eugene Teo <[email protected]>
---
fs/open.c | 4 ++--
fs/read_write.c | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index 1d9e5e9..dc121ce 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -1056,7 +1056,9 @@ asmlinkage long sys_open(const char __user *filename, int flags, int mode)
prevent_tail_call(ret);
return ret;
}
+#ifdef CONFIG_SPARC64
EXPORT_SYMBOL_GPL(sys_open);
+#endif
asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
int mode)
@@ -1148,8 +1150,6 @@ out_unlock:
return -EBADF;
}
-EXPORT_SYMBOL(sys_close);
-
/*
* This routine simulates a hangup on the tty, to arrange that users
* are given clean terminals at login time.
diff --git a/fs/read_write.c b/fs/read_write.c
index 507ddff..d913d1e 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -370,7 +370,6 @@ asmlinkage ssize_t sys_read(unsigned int fd, char __user * buf, size_t count)
return ret;
}
-EXPORT_SYMBOL_GPL(sys_read);
asmlinkage ssize_t sys_write(unsigned int fd, const char __user * buf, size_t count)
{
On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
> request_firmware instead of sys_*. Since that is the last driver in the
> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
> is left exported for sparc64 only.
I can't find any spar user of it, so please kill it. In the case a symbol
is needed only for a particular architecture it's better to do it in the
architecture-specific ksyms file than with an ifdef, btw.
Christoph Hellwig wrote:
> On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
>> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
>> request_firmware instead of sys_*. Since that is the last driver in the
>> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
>> is left exported for sparc64 only.
>
> I can't find any spar user of it, so please kill it.
it's in the solaris compat code which is modular
> In the case a symbol
> is needed only for a particular architecture it's better to do it in the
> architecture-specific ksyms file than with an ifdef, btw.
agreed.
(well if it's only 1 or 2, if it's "half of them" it's obviously a
different story)
On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
> request_firmware instead of sys_*. Since that is the last driver in the
> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
> is left exported for sparc64 only.
>...
fs/binfmt_misc.c still uses sys_close.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Mon, Aug 27, 2007 at 03:49:01PM -0700, Arjan van de Ven wrote:
> Christoph Hellwig wrote:
> >On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
> >>Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
> >>request_firmware instead of sys_*. Since that is the last driver in the
> >>kernel that uses sys_{read,close}, this patch kills these exports.
> >>sys_open
> >>is left exported for sparc64 only.
> >
> >I can't find any spar user of it, so please kill it.
>
> it's in the solaris compat code which is modular
While it does use some sys_ symbols, I can't find it use sys_open.