[permalink] [raw]

Subject: [PATCH 019/206] Staging: hv: Get rid of the calls to storvsc_cleanup

The storvsc_cleanup() is an empty function; get rid of it.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/blkvsc_drv.c | 3 ---
drivers/staging/hv/storvsc.c | 7 -------
drivers/staging/hv/storvsc_api.h | 1 -
drivers/staging/hv/storvsc_drv.c | 1 -
4 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index bca36b5..2e69af0 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -886,7 +886,6 @@ static int blkvsc_drv_exit_cb(struct device *dev, void *data)

static void blkvsc_drv_exit(void)
{
- struct storvsc_driver *storvsc_drv = &blkvsc_drv;
struct hv_driver *drv = &blkvsc_drv.base;
struct device *current_dev;
int ret;
@@ -911,8 +910,6 @@ static void blkvsc_drv_exit(void)
device_unregister(current_dev);
}

- storvsc_cleanup(&storvsc_drv->base);
-
vmbus_child_driver_unregister(&drv->driver);

return;
diff --git a/drivers/staging/hv/storvsc.c b/drivers/staging/hv/storvsc.c
index 867eba1..7074520 100644
--- a/drivers/staging/hv/storvsc.c
+++ b/drivers/staging/hv/storvsc.c
@@ -660,10 +660,3 @@ int stor_vsc_get_major_info(struct storvsc_device_info *device_info,
return -ENODEV;
}

-/*
- * stor_vsc_on_cleanup - Perform any cleanup when the driver is removed
- */
-void storvsc_cleanup(struct hv_driver *driver)
-{
-}
-
diff --git a/drivers/staging/hv/storvsc_api.h b/drivers/staging/hv/storvsc_api.h
index f8c724b..84ee5a9 100644
--- a/drivers/staging/hv/storvsc_api.h
+++ b/drivers/staging/hv/storvsc_api.h
@@ -169,7 +169,6 @@ int storvsc_dev_remove(struct hv_device *device);

int storvsc_do_io(struct hv_device *device,
struct hv_storvsc_request *request);
-void storvsc_cleanup(struct hv_driver *driver);

int stor_vsc_get_major_info(struct storvsc_device_info *device_info,
struct storvsc_major_info *major_info);
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 799231c..c54a5fe 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -115,7 +115,6 @@ static int stor_vsc_initialize(struct hv_driver *driver)
/* Setup the dispatch table */
stor_driver->base.dev_add = storvsc_dev_add;
stor_driver->base.dev_rm = storvsc_dev_remove;
- stor_driver->base.cleanup = storvsc_cleanup;

stor_driver->on_io_request = storvsc_do_io;

--
1.7.4.1

2011-05-09 22:11:46

by KY Srinivasan

[permalink] [raw]

[permalink] [raw]

Subject: [PATCH 057/206] Staging: hv: Get rid of the forward declaration of storvsc_probe()

2011-05-09 22:01:31

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 058/206] Staging: hv: Rename the driver variable

2011-05-09 22:01:29

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 059/206] Staging: hv: Move the declaration of the driver variable

2011-05-09 21:58:17

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:59:33

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:58:19

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 068/206] Staging: hv: Make netvsc_device_remove non static

2011-05-09 21:58:16

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 069/206] Staging: hv: Get rid of netvsc_cleanup()

netvsc_cleanup() is an empty function; get rid of it.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/netvsc.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/hv/netvsc.c b/drivers/staging/hv/netvsc.c
index 8790f0f..34828c4 100644
--- a/drivers/staging/hv/netvsc.c
+++ b/drivers/staging/hv/netvsc.c
@@ -622,13 +622,6 @@ int netvsc_device_remove(struct hv_device *device)
return 0;
}

-/*
- * netvsc_cleanup - Perform any cleanup when the driver is removed
- */
-static void netvsc_cleanup(struct hv_driver *drv)
-{
-}
-
static void netvsc_send_completion(struct hv_device *device,
struct vmpacket_descriptor *packet)
{
@@ -1194,7 +1187,6 @@ int netvsc_initialize(struct hv_driver *drv)
/* Setup the dispatch table */
driver->base.dev_add = netvsc_device_add;
driver->base.dev_rm = netvsc_device_remove;
- driver->base.cleanup = netvsc_cleanup;

driver->send = netvsc_send;

--
1.7.4.1

2011-05-09 21:58:13

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 070/206] Staging: hv: Make rndis_filte_device_add() non static

2011-05-09 21:58:14

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 071/206] Staging: hv: Make rndis_filter_device_remove() non static

2011-05-09 21:58:10

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 072/206] Staging: hv: Get rid of rndis_filter_cleanup()

rndis_filter_cleanup() is an empty function; get rid of it.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/rndis_filter.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c
index 455d440..b0c888e 100644
--- a/drivers/staging/hv/rndis_filter.c
+++ b/drivers/staging/hv/rndis_filter.c
@@ -84,8 +84,6 @@ struct rndis_filter_packet {
};

-static void rndis_filter_cleanup(struct hv_driver *drv);
-
static int rndis_filter_send(struct hv_device *dev,
struct hv_netvsc_packet *pkt);

@@ -621,7 +619,6 @@ int rndis_filter_init(struct netvsc_driver *drv)
/* Override */
drv->base.dev_add = rndis_filte_device_add;
drv->base.dev_rm = rndis_filter_device_remove;
- drv->base.cleanup = rndis_filter_cleanup;
drv->send = rndis_filter_send;
drv->recv_cb = rndis_filter_receive;

@@ -818,9 +815,6 @@ int rndis_filter_device_remove(struct hv_device *dev)
return 0;
}

-static void rndis_filter_cleanup(struct hv_driver *drv)
-{
-}

int rndis_filter_open(struct hv_device *dev)
{
--
1.7.4.1

2011-05-09 21:57:44

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 073/206] Staging: hv: Get rid of the indirection to invoke rndis_filte_device_add()

2011-05-09 21:56:52

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 074/206] Staging: hv: Get rid of the indirection to invoke netvsc_device_add()

2011-05-09 21:57:45

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 075/206] Staging: hv: Get rid of the indirection in invoking rndis_filter_device_remove()

2011-05-09 21:57:33

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:55:24

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:51:38

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 090/206] Staging: hv: Move the declaration of the variable netvsc_drv

2011-05-09 21:54:17

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 091/206] Staging: hv: Statically initialize probe/remove

Statically initialize probe/remove.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/netvsc_drv.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 566865f..c5e7b93 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -440,7 +440,10 @@ static int netvsc_drv_exit_cb(struct device *dev, void *data)
}

/* The one and only one */
-static struct netvsc_driver netvsc_drv;
+static struct netvsc_driver netvsc_drv = {
+ .base.probe = netvsc_probe,
+ .base.remove = netvsc_remove,
+};

static void netvsc_drv_exit(void)
{
@@ -485,9 +488,6 @@ static int netvsc_drv_init(int (*drv_init)(struct hv_driver *drv))

drv->driver.name = net_drv_obj->base.name;

- drv->probe = netvsc_probe;
- drv->remove = netvsc_remove;
-
/* The driver belongs to vmbus */
ret = vmbus_child_driver_register(&drv->driver);

--
1.7.4.1

2011-05-09 21:54:20

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:48:37

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 107/206] Staging: hv: Get rid of the volatile qualifier for a variable in ring_buffer.c

Access to this variable is already serialized via a spin lock. Get
rid of the unnecessary volatile qualifier.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/ring_buffer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/hv/ring_buffer.c b/drivers/staging/hv/ring_buffer.c
index 2a461ddee..badf52a 100644
--- a/drivers/staging/hv/ring_buffer.c
+++ b/drivers/staging/hv/ring_buffer.c
@@ -364,7 +364,7 @@ int hv_ringbuffer_write(struct hv_ring_buffer_info *outring_info,
u32 totalbytes_towrite = 0;

struct scatterlist *sg;
- volatile u32 next_write_location;
+ u32 next_write_location;
u64 prev_indices = 0;
unsigned long flags;

--
1.7.4.1

2011-05-09 21:48:33

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 108/206] Staging: hv: Cleanup ring_buffer.h

Access to these variables is already serialized via a spin lock. Get
rid of the unnecessary volatile qualifier.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/ring_buffer.h | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hv/ring_buffer.h b/drivers/staging/hv/ring_buffer.h
index 1bc0b8a..089c536 100644
--- a/drivers/staging/hv/ring_buffer.h
+++ b/drivers/staging/hv/ring_buffer.h
@@ -30,12 +30,12 @@

struct hv_ring_buffer {
/* Offset in bytes from the start of ring data below */
- volatile u32 write_index;
+ u32 write_index;

/* Offset in bytes from the start of ring data below */
- volatile u32 read_index;
+ u32 read_index;

- volatile u32 interrupt_mask;
+ u32 interrupt_mask;

/* Pad it to PAGE_SIZE so that data starts on page boundary */
u8 reserved[4084];
@@ -45,7 +45,6 @@ struct hv_ring_buffer {
* vmbus connection also uses this data structure and its data starts
* here, we commented out this field.
*/
- /* volatile u32 InterruptMask; */

/*
* Ring data starts here + RingDataStartOffset
--
1.7.4.1

2011-05-09 21:50:12

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 109/206] Staging: hv: Rename the variable gSupportedDeviceClasses

2011-05-09 21:50:10

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 110/206] Staging: hv: Rename the variable messageHandler

2011-05-09 21:50:01

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 111/206] Staging: hv: Rename the variable messageType

2011-05-09 21:50:04

by KY Srinivasan

[permalink] [raw]

2011-05-09 21:48:36

by KY Srinivasan

[permalink] [raw]

2011-05-10 08:49:41

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 130/206] Staging: hv: Make blkvsc_drv_init the module init function

Now, get rid of the redundant function and make
blkvsc_drv_init the module init function.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/blkvsc_drv.c | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index ed1439f..eebaaee 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -1044,15 +1044,6 @@ static void blkvsc_request_completion(struct hv_storvsc_request *request)
spin_unlock_irqrestore(&blkdev->lock, flags);
}

-static int __init blkvsc_init(void)
-{
- int ret;
-
- ret = blkvsc_drv_init();
-
- return ret;
-}
-
static void __exit blkvsc_exit(void)
{
blkvsc_drv_exit();
@@ -1061,5 +1052,5 @@ static void __exit blkvsc_exit(void)
MODULE_LICENSE("GPL");
MODULE_VERSION(HV_DRV_VERSION);
MODULE_DESCRIPTION("Microsoft Hyper-V virtual block driver");
-module_init(blkvsc_init);
+module_init(blkvsc_drv_init);
module_exit(blkvsc_exit);
--
1.7.4.1

2011-05-10 09:37:33

by KY Srinivasan

[permalink] [raw]

2011-05-10 08:38:37

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 139/206] Staging: hv: Move the assignment of name to the hv_driver

In preperation to eliminate the function storvsc_initialize()
move the name assignment.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/storvsc_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index e342bcc..9447130 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -86,7 +86,6 @@ static int storvsc_initialize(struct hv_driver *driver)

/* Make sure we are at least 2 pages since 1 page is used for control */

- driver->name = driver_name;
memcpy(&driver->dev_type, &gStorVscDeviceType,
sizeof(struct hv_guid));

@@ -806,6 +805,7 @@ static int storvsc_drv_init(void)
STORVSC_MAX_IO_REQUESTS)
return -1;

+ drv->name = driver_name;
drv->driver.name = driver_name;

--
1.7.4.1

2011-05-10 08:51:03

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 140/206] Staging: hv: Inline the copying of the dev_type information

In preperation to eliminate the function storvsc_initialize()
move the copying of dev_type info.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
drivers/staging/hv/storvsc_drv.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 9447130..3be4f1a 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -83,12 +83,6 @@ static int storvsc_initialize(struct hv_driver *driver)

stor_driver = hvdr_to_stordr(driver);

-
- /* Make sure we are at least 2 pages since 1 page is used for control */
-
- memcpy(&driver->dev_type, &gStorVscDeviceType,
- sizeof(struct hv_guid));
-
return 0;
}

@@ -801,6 +795,9 @@ static int storvsc_drv_init(void)
/* Callback to client driver to complete the initialization */
storvsc_initialize(&storvsc_drv_obj->base);

+ memcpy(&drv->dev_type, &gStorVscDeviceType,
+ sizeof(struct hv_guid));
+
if (max_outstanding_req_per_channel <
STORVSC_MAX_IO_REQUESTS)
return -1;
--
1.7.4.1

2011-05-10 09:54:10

by KY Srinivasan

[permalink] [raw]

The subject line says it all.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
include/linux/hyperv.h | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 2751b10..f91e3a4 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -31,6 +31,7 @@
#include <linux/workqueue.h>
#include <linux/completion.h>
#include <linux/scatterlist.h>
+#include <linux/device.h>

#define MAX_PAGE_BUFFER_COUNT 16
#define MAX_MULTIPAGE_BUFFER_COUNT 32 /* 128K */
@@ -757,8 +758,6 @@ extern unsigned int vmbus_loglevel;
#define HV_DRV_VERSION "3.1"

-#include <linux/device.h>
-#include <linux/workqueue.h>

struct hv_driver;
@@ -821,11 +820,6 @@ struct hv_device {
void *ext;
};

-#include <linux/device.h>
-
-
-
-
static inline struct hv_device *device_to_hv_device(struct device *d)
{
return container_of(d, struct hv_device, device);
--
1.7.4.1

2011-05-10 08:31:16

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 163/206] Staging: hv: Include asm/hyperv.h

The subject line says it all.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
include/linux/hyperv.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index f91e3a4..92369b9 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -32,6 +32,7 @@
#include <linux/completion.h>
#include <linux/scatterlist.h>
#include <linux/device.h>
+#include <asm/hyperv.h>

#define MAX_PAGE_BUFFER_COUNT 16
#define MAX_MULTIPAGE_BUFFER_COUNT 32 /* 128K */
--
1.7.4.1

2011-05-10 09:56:21

by KY Srinivasan

[permalink] [raw]

Subject: [PATCH 164/206] Staging: hv: Add the definition hv_guid

The subject line says it all.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Abhishek Kane <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
include/linux/hyperv.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 92369b9..81f8742 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -34,6 +34,10 @@
#include <linux/device.h>
#include <asm/hyperv.h>

+struct hv_guid {
+ unsigned char data[16];
+};
+
#define MAX_PAGE_BUFFER_COUNT 16
#define MAX_MULTIPAGE_BUFFER_COUNT 32 /* 128K */

--
1.7.4.1

Subject: [PATCH 178/206] Staging: hv: Include the contents of rndis_filter.h

2011-05-10 08:37:03

by KY Srinivasan

[permalink] [raw]

On 05/10/11 13:13, Greg KH wrote:
> On Tue, May 10, 2011 at 11:11:03AM +0100, Jonathan Cameron wrote:
>> On 05/09/11 22:54, K. Y. Srinivasan wrote:
>>> Rename the variable g_blk_device_type.
>> Why?
>
> Because "g_blk_device_type" is in Hungarian notation, which isn't needed
> in the kernel.
>
Fair enough, I'd misunderstood what g_blk referred to. Sorry for the noise.

2011-05-10 12:52:10

by KY Srinivasan

[permalink] [raw]

Subject: RE: [PATCH 115/206] Staging: hv: Use completion abstraction in struct netvsc_device

> -----Original Message-----
> From: Christoph Hellwig [mailto:[email protected]]
> Sent: Tuesday, May 10, 2011 3:07 AM
> To: KY Srinivasan
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Haiyang Zhang;
> Abhishek Kane (Mindtree Consulting PVT LTD); Hank Janssen
> Subject: Re: [PATCH 115/206] Staging: hv: Use completion abstraction in struct
> netvsc_device
>
> > - net_device->wait_condition = 0;
> > ret = vmbus_sendpacket(device->channel, init_packet,
> > sizeof(struct nvsp_message),
> > (unsigned long)init_packet,
> > @@ -272,10 +272,8 @@ static int netvsc_init_recv_buf(struct hv_device
> *device)
> > goto cleanup;
> > }
> >
> > - wait_event_timeout(net_device->channel_init_wait,
> > - net_device->wait_condition,
> > - msecs_to_jiffies(1000));
> > - BUG_ON(net_device->wait_condition == 0);
> > + t = wait_for_completion_timeout(&net_device->channel_init_wait, HZ);
> > + BUG_ON(t == 0);
>
> I don't think you want a BUG_ON here, but rather fail the
> initialization.

This is existing code and all I did was change the synchronization
primitive used. Back in Feb. when this was done (prior to then), the
wait was indefinite and one of the comments that was
longstanding was that the wait had to be bounded and so these
timed waits were introduced. When this was done,
in some cases, there was no easy way to roll-back state if we did not
get the response within our expected window of time. This is one
such instance where the guest is handing over the receive buffers
(guest physical addresses) to the host. There was a discussion on this very
topic on this mailing list and the consensus was to leave the BUG_ON()
call in cases where we could not reasonably recover.

>
> Also I think you really should add synchronous versions of
> vmbus_sendpacket*, to the vmbus core so that all the synchronous waiting
> can be consolidated into a few helpers instead of needing to opencode
> it everywhere.

True; but having a non-blocking interface at the lowest level gives you
the most flexibility. In addition to this non-blocking interface, we
may want to look at potentially a blocking interface. In the current
code, the blocking primitive that is embedded in a higher level
abstraction is used for a variety of situations including the initial
handshake which is what can be addressed with a synchronous API
at the lowest level.

Regards,

K. Y