2018-12-21 08:59:53

by Kangjie Lu

Subject: [PATCH] media: mt312: fix a missing check of mt312 reset

mt312_reset() may fail. Although it is called in the end of
mt312_set_frontend(), we better check its status and return its error
code upstream instead of 0.

Signed-off-by: Kangjie Lu <[email protected]>
---
drivers/media/dvb-frontends/mt312.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c
index 03e74a729168..bfbb879469f2 100644
--- a/drivers/media/dvb-frontends/mt312.c
+++ b/drivers/media/dvb-frontends/mt312.c
@@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe)
if (ret < 0)
return ret;

- mt312_reset(state, 0);
+ ret = mt312_reset(state, 0);
+ if (ret < 0)
+ return ret;

return 0;
}
--
2.17.2 (Apple Git-113)

2018-12-24 11:24:45

by Matthias Schwarzott

Subject: Re: [PATCH] media: mt312: fix a missing check of mt312 reset

Am 21.12.18 um 08:07 schrieb Kangjie Lu:
> mt312_reset() may fail. Although it is called in the end of
> mt312_set_frontend(), we better check its status and return its error
> code upstream instead of 0.
>
> Signed-off-by: Kangjie Lu <[email protected]>

Thanks for submitting this patch. It looks correct.

Reviewed-by: Matthias Schwarzott <[email protected]>

> ---
> drivers/media/dvb-frontends/mt312.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c
> index 03e74a729168..bfbb879469f2 100644
> --- a/drivers/media/dvb-frontends/mt312.c
> +++ b/drivers/media/dvb-frontends/mt312.c
> @@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe)
> if (ret < 0)
> return ret;
>
> - mt312_reset(state, 0);
> + ret = mt312_reset(state, 0);
> + if (ret < 0)
> + return ret;
>
> return 0;
> }
>