2016-11-30 04:29:27

by Yan Laijun

Subject: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.c file.

Signed-off-by: Yan Laijun <[email protected]>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5f11f6e..3447fc5 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
{
struct wlandevice *wlandev = urb->context;
struct hfa384x *hw;
- union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
+ union hfa384x_usbin *usbin = NULL;
struct sk_buff *skb = NULL;
int result;
int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
ABORT
} action;

+ usbin = (union hfa384x_usbin *)urb->transfer_buffer;
if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
goto exit;

--
1.9.1

2016-11-30 09:10:32

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
>
> Signed-off-by: Yan Laijun <[email protected]>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..3447fc5 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> {
> struct wlandevice *wlandev = urb->context;
> struct hfa384x *hw;
> - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> + union hfa384x_usbin *usbin = NULL;

Why set this to NULL if you then assign it to something else a few lines
later?

thanks,

greg k-h

2016-12-02 10:09:00

by Yan Laijun

Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

Remove initialization of usbin on its decarlation.

Yan Laijun (1):
Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--
1.9.1

2016-12-02 10:09:21

by Yan Laijun

Subject: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings.

Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.c file.

Signed-off-by: Yan Laijun <[email protected]>
---
Changes in v2:
- Remove initialization of usbin on its decarlation.
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5f11f6e..c7bda04 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
{
struct wlandevice *wlandev = urb->context;
struct hfa384x *hw;
- union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
+ union hfa384x_usbin *usbin;
struct sk_buff *skb = NULL;
int result;
int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
ABORT
} action;

+ usbin = (union hfa384x_usbin *)urb->transfer_buffer;
if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
goto exit;

--
1.9.1

2016-12-02 10:49:39

by Markus Böhme

Subject: Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings.

On 12/02/2016 11:09 AM, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
>
> Signed-off-by: Yan Laijun <[email protected]>
> ---
> Changes in v2:
> - Remove initialization of usbin on its decarlation.
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..c7bda04 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> {
> struct wlandevice *wlandev = urb->context;
> struct hfa384x *hw;
> - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> + union hfa384x_usbin *usbin;
> struct sk_buff *skb = NULL;
> int result;
> int urb_status;
> @@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> ABORT
> } action;
>
> + usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
> goto exit;
>
>

If you separate declaration and assignment of usbin, maybe it makes
sense to move the assignment down to where usbin is used for the first time.

Regards,
Markus