2023-05-06 15:46:52

by Yan Yan(cailing)

Subject: [PATCH] sched/headers: remove duplicate included header

linux/psi.h is included more than once.

Signed-off-by: Yan Yan <[email protected]>
---
kernel/sched/build_utility.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
index 99bdd96f454f..80a3df49ab47 100644
--- a/kernel/sched/build_utility.c
+++ b/kernel/sched/build_utility.c
@@ -34,7 +34,6 @@
#include <linux/nospec.h>
#include <linux/proc_fs.h>
#include <linux/psi.h>
-#include <linux/psi.h>
#include <linux/ptrace_api.h>
#include <linux/sched_clock.h>
#include <linux/security.h>
--
2.32.0.3.g01195cf9f

2023-05-15 16:04:21

by Yan Yan(cailing)

Subject: Re: [PATCH] sched/headers: remove duplicate included header

Ping.

It seems that removing the two same included lines is ok. Because the
following "sched.h" also includes psi.h.

Any comments?

Thanks,

-Yan Yan

在 2023/5/6 23:39, 晏艳(采苓) 写道:
> linux/psi.h is included more than once.
>
> Signed-off-by: Yan Yan <[email protected]>
> ---
> kernel/sched/build_utility.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
> index 99bdd96f454f..80a3df49ab47 100644
> --- a/kernel/sched/build_utility.c
> +++ b/kernel/sched/build_utility.c
> @@ -34,7 +34,6 @@
> #include <linux/nospec.h>
> #include <linux/proc_fs.h>
> #include <linux/psi.h>
> -#include <linux/psi.h>
> #include <linux/ptrace_api.h>
> #include <linux/sched_clock.h>
> #include <linux/security.h>

2023-05-22 02:52:12

by Yan Yan(cailing)

Subject: Re: [PATCH] sched/headers: remove duplicate included header

Ping, any comments?

thanks,

-Yan Yan

在 2023/5/16 00:00, Yan Yan 写道:
> Ping.
>
> It seems that removing the two same included lines is ok. Because the
> following "sched.h" also includes psi.h.
>
> Any comments?
>
> Thanks,
>
> -Yan Yan
>
> 在 2023/5/6 23:39, 晏艳(采苓) 写道:
>> linux/psi.h is included more than once.
>>
>> Signed-off-by: Yan Yan <[email protected]>
>> ---
>>   kernel/sched/build_utility.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
>> index 99bdd96f454f..80a3df49ab47 100644
>> --- a/kernel/sched/build_utility.c
>> +++ b/kernel/sched/build_utility.c
>> @@ -34,7 +34,6 @@
>>   #include <linux/nospec.h>
>>   #include <linux/proc_fs.h>
>>   #include <linux/psi.h>
>> -#include <linux/psi.h>
>>   #include <linux/ptrace_api.h>
>>   #include <linux/sched_clock.h>
>>   #include <linux/security.h>

2023-05-22 04:23:00

by Christophe JAILLET

Subject: Re: [PATCH] sched/headers: remove duplicate included header

Le 22/05/2023 à 04:26, Yan Yan(cailing) a écrit :
> Ping, any comments?
>
> thanks,
>
> -Yan Yan
>
> 在 2023/5/16 00:00, Yan Yan 写道:
>> Ping.
>>
>> It seems that removing the two same included lines is ok. Because the
>> following "sched.h" also includes psi.h.
>>
>> Any comments?

FWIW, yes, looks good.


If you want to ga that way, their are some other potential removal
candidates in build_utility.c:

linux/sched/mm.h

linux/cpufreq.h
linux/ctype.h
linux/proc_fs.h
linux/spinlock_api.h
linux/wait_api.h
linux/workqueue_api.h

CJ

>>
>> Thanks,
>>
>> -Yan Yan
>>
>> 在 2023/5/6 23:39, 晏艳(采苓) 写道:
>>> linux/psi.h is included more than once.
>>>
>>> Signed-off-by: Yan Yan <[email protected]>
>>> ---
>>>   kernel/sched/build_utility.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
>>> index 99bdd96f454f..80a3df49ab47 100644
>>> --- a/kernel/sched/build_utility.c
>>> +++ b/kernel/sched/build_utility.c
>>> @@ -34,7 +34,6 @@
>>>   #include <linux/nospec.h>
>>>   #include <linux/proc_fs.h>
>>>   #include <linux/psi.h>
>>> -#include <linux/psi.h>
>>>   #include <linux/ptrace_api.h>
>>>   #include <linux/sched_clock.h>
>>>   #include <linux/security.h>
>