On 4/29/2013 1:25 PM, Gupta, Pekon wrote:
> From: avinash philip <[email protected]>
>
> NAND flash connected in am335x-evm on GPMC controller. This patch adds
> device tree node in am3355-evm with GPMC contoller timing for NAND flash
> interface, NAND partition table, ECC scheme, elm handle id.
>
> Signed-off-by: Philip Avinash <[email protected]>
> Tested-by: Pekon Gupta <[email protected]>
>
> ---
> arch/arm/boot/dts/am335x-evm.dts | 98 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 97 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 0423298..1c2fd89 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -26,7 +26,8 @@
>
> am33xx_pinmux: pinmux@44e10800 {
> pinctrl-names = "default";
> - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> + &nandflash_pins_s0>;
Why add this to the board level fallback (called pinctrl hogs, I think)?
This can be part of nand node you added below so that the pinctrl will
take effect when nand gets probed instead of all the time.
Thanks,
Sekhar
* Sekhar Nori <[email protected]> [130429 22:11]:
>
> On 4/29/2013 1:25 PM, Gupta, Pekon wrote:
> > From: avinash philip <[email protected]>
> >
> > NAND flash connected in am335x-evm on GPMC controller. This patch adds
> > device tree node in am3355-evm with GPMC contoller timing for NAND flash
> > interface, NAND partition table, ECC scheme, elm handle id.
> >
> > Signed-off-by: Philip Avinash <[email protected]>
> > Tested-by: Pekon Gupta <[email protected]>
> >
> > ---
> > arch/arm/boot/dts/am335x-evm.dts | 98 +++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 97 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> > index 0423298..1c2fd89 100644
> > --- a/arch/arm/boot/dts/am335x-evm.dts
> > +++ b/arch/arm/boot/dts/am335x-evm.dts
> > @@ -26,7 +26,8 @@
> >
> > am33xx_pinmux: pinmux@44e10800 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> > + &nandflash_pins_s0>;
>
> Why add this to the board level fallback (called pinctrl hogs, I think)?
> This can be part of nand node you added below so that the pinctrl will
> take effect when nand gets probed instead of all the time.
Yes we should have all the pinctrl entries under the related drivers.
This makes it easy remux pins during runtime if needed, and also
allows unloading pinctrl-single.ko for development.
Regards,
Tony
> > >
> > > am33xx_pinmux: pinmux@44e10800 {
> > > pinctrl-names = "default";
> > > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> > > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> > > + &nandflash_pins_s0>;
> >
> > Why add this to the board level fallback (called pinctrl hogs, I think)?
> > This can be part of nand node you added below so that the pinctrl will
> > take effect when nand gets probed instead of all the time.
>
> Yes we should have all the pinctrl entries under the related drivers.
> This makes it easy remux pins during runtime if needed, and also
> allows unloading pinctrl-single.ko for development.
>
Yes, accepted. This has been already fixed in v3 of this patch set.
If all fine, then please pull this for next merge..
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html (already pulled)
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
with regards, pekon
> > > >
> > > > am33xx_pinmux: pinmux@44e10800 {
> > > > pinctrl-names = "default";
> > > > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> > > > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> > > > + &nandflash_pins_s0>;
> > >
> > > Why add this to the board level fallback (called pinctrl hogs, I think)?
> > > This can be part of nand node you added below so that the pinctrl will
> > > take effect when nand gets probed instead of all the time.
> >
> > Yes we should have all the pinctrl entries under the related drivers.
> > This makes it easy remux pins during runtime if needed, and also
> > allows unloading pinctrl-single.ko for development.
> >
> Yes, accepted. This has been already fixed in v3 of this patch set.
> If all fine, then please pull this for next merge..
>
> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
>
> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html
>
> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
>
>
> with regards, pekon
Request you to please accept | provide feedbacks on this patch series.
These are waiting acceptance since Jan-2013, and are necessary for
DT based configs for board having NAND support.
with regards, pekon
Hi Pekon,
On 05/20/2013 06:44 AM, Gupta, Pekon wrote:
>
>>>>>
>>>>> am33xx_pinmux: pinmux@44e10800 {
>>>>> pinctrl-names = "default";
>>>>> - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
>>>>> + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
>>>>> + &nandflash_pins_s0>;
>>>>
>>>> Why add this to the board level fallback (called pinctrl hogs, I think)?
>>>> This can be part of nand node you added below so that the pinctrl will
>>>> take effect when nand gets probed instead of all the time.
>>>
>>> Yes we should have all the pinctrl entries under the related drivers.
>>> This makes it easy remux pins during runtime if needed, and also
>>> allows unloading pinctrl-single.ko for development.
>>>
>> Yes, accepted. This has been already fixed in v3 of this patch set.
>> If all fine, then please pull this for next merge..
>>
>> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
>>
>> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html
>>
>> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
>>
>>
>> with regards, pekon
>
> Request you to please accept | provide feedbacks on this patch series.
> These are waiting acceptance since Jan-2013, and are necessary for
> DT based configs for board having NAND support.
>
> with regards, pekon
Sorry, I missed that series.
I'm applying it right now.
Thanks,
Benoit
> Sorry, I missed that series.
>
> I'm applying it right now.
>
No issues.. Please pick newer v4 versions of this series.
Following are rebased, updated and tested on linux-3.10-rc3
[PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
[PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
[PATCH v4,2/3] (please skip this one)
instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
[PATCH v4,3/3] http://www.spinics.net/lists/linux-omap/msg91167.html
Thanks..
with regards, pekon
> > Sorry, I missed that series.
> >
> > I'm applying it right now.
> >
> No issues.. Please pick newer v4 versions of this series.
> Following are rebased, updated and tested on linux-3.10-rc3
>
> [PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
>
> [PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
>
> [PATCH v4,2/3] (please skip this one)
> instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
>
> [PATCH v4,3/3] (typo)
http://www.spinics.net/lists/linux-omap/msg91164.html
>
>
> Thanks..
> with regards, pekon
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
On 05/30/2013 09:31 AM, Gupta, Pekon wrote:
>> Sorry, I missed that series.
>>
>> I'm applying it right now.
>>
> No issues.. Please pick newer v4 versions of this series.
> Following are rebased, updated and tested on linux-3.10-rc3
>
> [PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
>
> [PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
>
> [PATCH v4,2/3] (please skip this one)
> instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
>
> [PATCH v4,3/3] http://www.spinics.net/lists/linux-omap/msg91167.html
Could you please rebase on for_3.11/dts and repost the whole stuff. It
looks like Tony already pulled the GPMC node, and the two other ones
cannot apply anymore.
Thanks,
Benoit