2022-07-18 21:29:34

by Horatiu Vultur

Subject: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

On pcb8291, can0 and the network driver share some of the GPIOs so only
1 device can be active. Therefore disable can0 as we want to enable the
network driver.

Signed-off-by: Horatiu Vultur <[email protected]>
---
arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index 02fbf7371a8d..2cb532aa33f0 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
pins = "GPIO_52", "GPIO_53";
function = "fc3_b";
};
-
- can0_b_pins: can0-b-pins {
- /* RX, TX */
- pins = "GPIO_35", "GPIO_36";
- function = "can0_b";
- };
-};
-
-&can0 {
- pinctrl-0 = <&can0_b_pins>;
- pinctrl-names = "default";
- status = "okay";
};

&flx3 {
--
2.33.0

2022-07-19 08:10:11

by Claudiu Beznea

Subject: Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

On 19.07.2022 00:29, Horatiu Vultur wrote:
> On pcb8291, can0 and the network driver share some of the GPIOs so only
> 1 device can be active. Therefore disable can0 as we want to enable the
> network driver.
>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 02fbf7371a8d..2cb532aa33f0 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
> pins = "GPIO_52", "GPIO_53";
> function = "fc3_b";
> };
> -
> - can0_b_pins: can0-b-pins {
> - /* RX, TX */
> - pins = "GPIO_35", "GPIO_36";
> - function = "can0_b";
> - };
> -};
> -
> -&can0 {
> - pinctrl-0 = <&can0_b_pins>;
> - pinctrl-names = "default";
> - status = "okay";

You can just delete the status line here or change it to "disabled" and
leave the rest for reference. For evaluation one could just enable it here
afterwards. On the other AT91 specific boards we are using status =
"disabled"; and a short comment after like this:

status = "disabled"; /* Conflict with gmac0. */

> };
>
> &flx3 {

2022-07-19 20:12:04

by Horatiu Vultur

Subject: Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

The 07/19/2022 07:55, Claudiu Beznea - M18063 wrote:
> On 19.07.2022 00:29, Horatiu Vultur wrote:
> > On pcb8291, can0 and the network driver share some of the GPIOs so only
> > 1 device can be active. Therefore disable can0 as we want to enable the
> > network driver.
> >
> > Signed-off-by: Horatiu Vultur <[email protected]>
> > ---
> > arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index 02fbf7371a8d..2cb532aa33f0 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
> > pins = "GPIO_52", "GPIO_53";
> > function = "fc3_b";
> > };
> > -
> > - can0_b_pins: can0-b-pins {
> > - /* RX, TX */
> > - pins = "GPIO_35", "GPIO_36";
> > - function = "can0_b";
> > - };
> > -};
> > -
> > -&can0 {
> > - pinctrl-0 = <&can0_b_pins>;
> > - pinctrl-names = "default";
> > - status = "okay";
>
> You can just delete the status line here or change it to "disabled" and
> leave the rest for reference. For evaluation one could just enable it here
> afterwards. On the other AT91 specific boards we are using status =
> "disabled"; and a short comment after like this:
>
> status = "disabled"; /* Conflict with gmac0. */

That is a great idea. Yes I will do that.

>
> > };
> >
> > &flx3 {
>

--
/Horatiu