state_size and ops are in the wrong position, fix it.
Signed-off-by: Miaohe Lin <[email protected]>
---
include/linux/proc_fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
index a705aa2d03f9..0640be56dcbd 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);
struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct seq_operations *ops,
unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
- proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+ proc_create_net_data(name, mode, parent, ops, state_size, NULL)
struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
struct proc_dir_entry *parent,
int (*show)(struct seq_file *, void *), void *data);
--
2.21.GIT
Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM)
[email protected] (open list:PROC FILESYSTEM)
[email protected] (open list:PROC FILESYSTEM)
------------------------------------------------------
From: Miaohe Lin <[email protected]>
Subject: fix confusing macro arg name
state_size and ops are in the wrong position, fix it.
Signed-off-by: Miaohe Lin <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---
include/linux/proc_fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct seq_operations *ops,
unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
- proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+ proc_create_net_data(name, mode, parent, ops, state_size, NULL)
struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
struct proc_dir_entry *parent,
int (*show)(struct seq_file *, void *), void *data);
--
2.21.GIT
On 2019/10/8 14:44, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <[email protected]>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> Reviewed-by: Andrew Morton <[email protected]>
> Cc: Alexey Dobriyan <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
> ---
Good catch!
This is interesting, I saw this interface has 50+ callers,
How did they work before? ;)
Thanks,
-Aubrey
>
> include/linux/proc_fs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
> struct proc_dir_entry *parent, const struct seq_operations *ops,
> unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> - proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> + proc_create_net_data(name, mode, parent, ops, state_size, NULL)
> struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> struct proc_dir_entry *parent,
> int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>
>
On 2019-10-08, linmiaohe <[email protected]> wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <[email protected]>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> Reviewed-by: Andrew Morton <[email protected]>
> Cc: Alexey Dobriyan <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
Looks reasonable.
Acked-by: Aleksa Sarai <[email protected]>
> ---
>
> include/linux/proc_fs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
> struct proc_dir_entry *parent, const struct seq_operations *ops,
> unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> - proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> + proc_create_net_data(name, mode, parent, ops, state_size, NULL)
> struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> struct proc_dir_entry *parent,
> int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
On 2019/10/8 15:05, Aubrey wrote:
>> On 2019/10/8 14:44, linmiaohe wrote:
>> state_size and ops are in the wrong position, fix it.
>>
>
> Good catch!
>
> This is interesting, I saw this interface has 50+ callers, How did they work before? ;)
>
This confused me too. The args of function proc_create_net_single is consistent with
the callers, so it works. But the wrong args name in macro proc_create_net makes
it confusing.
Thanks, have a nice day!
> Thanks,
> -Aubrey
>
On Tue, Oct 08, 2019 at 06:44:18AM +0000, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <[email protected]> (reviewer:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
> [email protected] (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <[email protected]>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> Reviewed-by: Andrew Morton <[email protected]>
> Cc: Alexey Dobriyan <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
I thought I already reviewed this weeks ago...
Reviewed-by: Christian Brauner <[email protected]>