The value obtained from GINTSTS2 should be masked with the GINTMSK2
value. Looks like this has been broken since
dwc2_gadget_wkup_alert_handler() was added back in 2018.
Also fixes the following W=1 warning:
drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
259 | u32 gintmsk2;
| ^~~~~~~~
Cc: Minas Harutyunyan <[email protected]>
Cc: Ben Dooks <[email protected]>
Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
Signed-off-by: Lee Jones <[email protected]>
---
Changelog:
v2: Re-written to *use* instad of *remove* gintmsk2
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index df5fedaca60a0..03cf1fa856219 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -260,6 +260,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
gintsts2 = dwc2_readl(hsotg, GINTSTS2);
gintmsk2 = dwc2_readl(hsotg, GINTMSK2);
+ gintsts2 &= gintmsk2;
if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
--
2.25.1
On 7/15/2020 1:32 PM, Lee Jones wrote:
> The value obtained from GINTSTS2 should be masked with the GINTMSK2
> value. Looks like this has been broken since
> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>
> Also fixes the following W=1 warning:
>
> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
> 259 | u32 gintmsk2;
> | ^~~~~~~~
>
> Cc: Minas Harutyunyan <[email protected]>
> Cc: Ben Dooks <[email protected]>
> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
> Signed-off-by: Lee Jones <[email protected]>
Acked-by: Minas Harutyunyan <[email protected]>
> ---
> Changelog:
>
> v2: Re-written to *use* instad of *remove* gintmsk2
>
> drivers/usb/dwc2/gadget.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index df5fedaca60a0..03cf1fa856219 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -260,6 +260,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>
> gintsts2 = dwc2_readl(hsotg, GINTSTS2);
> gintmsk2 = dwc2_readl(hsotg, GINTMSK2);
> + gintsts2 &= gintmsk2;
>
> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>
Minas Harutyunyan <[email protected]> writes:
> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> value. Looks like this has been broken since
>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>
>> Also fixes the following W=1 warning:
>>
>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>> 259 | u32 gintmsk2;
>> | ^~~~~~~~
>>
>> Cc: Minas Harutyunyan <[email protected]>
>> Cc: Ben Dooks <[email protected]>
>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> Signed-off-by: Lee Jones <[email protected]>
>
> Acked-by: Minas Harutyunyan <[email protected]>
Should I apply the entire series or only 1/8?
--
balbi
Hi Felipe,
On 7/21/2020 1:43 PM, Felipe Balbi wrote:
> Minas Harutyunyan <[email protected]> writes:
>
>> On 7/15/2020 1:32 PM, Lee Jones wrote:
>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>>> value. Looks like this has been broken since
>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>>
>>> Also fixes the following W=1 warning:
>>>
>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>>> 259 | u32 gintmsk2;
>>> | ^~~~~~~~
>>>
>>> Cc: Minas Harutyunyan <[email protected]>
>>> Cc: Ben Dooks <[email protected]>
>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>>> Signed-off-by: Lee Jones <[email protected]>
>>
>> Acked-by: Minas Harutyunyan <[email protected]>
>
> Should I apply the entire series or only 1/8?
>
In this series only 2 patches are related to dwc2, which I'm already Acked:
[PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
[PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control
register
I can't acked other patches from this series, because they are not
related to dwc2.
Thanks,
Minas
Minas Harutyunyan <[email protected]> writes:
> Hi Felipe,
>
> On 7/21/2020 1:43 PM, Felipe Balbi wrote:
>> Minas Harutyunyan <[email protected]> writes:
>>
>>> On 7/15/2020 1:32 PM, Lee Jones wrote:
>>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>>>> value. Looks like this has been broken since
>>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>>>
>>>> Also fixes the following W=1 warning:
>>>>
>>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>>>> 259 | u32 gintmsk2;
>>>> | ^~~~~~~~
>>>>
>>>> Cc: Minas Harutyunyan <[email protected]>
>>>> Cc: Ben Dooks <[email protected]>
>>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>>>> Signed-off-by: Lee Jones <[email protected]>
>>>
>>> Acked-by: Minas Harutyunyan <[email protected]>
>>
>> Should I apply the entire series or only 1/8?
>>
> In this series only 2 patches are related to dwc2, which I'm already Acked:
>
> [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
> [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control
> register
>
> I can't acked other patches from this series, because they are not
> related to dwc2.
heh, I saw that after sending the email, sorry :-)
--
balbi
On Tue, 21 Jul 2020, Felipe Balbi wrote:
> Minas Harutyunyan <[email protected]> writes:
>
> > Hi Felipe,
> >
> > On 7/21/2020 1:43 PM, Felipe Balbi wrote:
> >> Minas Harutyunyan <[email protected]> writes:
> >>
> >>> On 7/15/2020 1:32 PM, Lee Jones wrote:
> >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
> >>>> value. Looks like this has been broken since
> >>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
> >>>>
> >>>> Also fixes the following W=1 warning:
> >>>>
> >>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
> >>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
> >>>> 259 | u32 gintmsk2;
> >>>> | ^~~~~~~~
> >>>>
> >>>> Cc: Minas Harutyunyan <[email protected]>
> >>>> Cc: Ben Dooks <[email protected]>
> >>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
> >>>> Signed-off-by: Lee Jones <[email protected]>
> >>>
> >>> Acked-by: Minas Harutyunyan <[email protected]>
> >>
> >> Should I apply the entire series or only 1/8?
> >>
> > In this series only 2 patches are related to dwc2, which I'm already Acked:
> >
> > [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
> > [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control
> > register
> >
> > I can't acked other patches from this series, because they are not
> > related to dwc2.
>
> heh, I saw that after sending the email, sorry :-)
Also, all patches are already in -next, courtesy of Greg.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Hi,
Lee Jones <[email protected]> writes:
> On Tue, 21 Jul 2020, Felipe Balbi wrote:
>
>> Minas Harutyunyan <[email protected]> writes:
>>
>> > Hi Felipe,
>> >
>> > On 7/21/2020 1:43 PM, Felipe Balbi wrote:
>> >> Minas Harutyunyan <[email protected]> writes:
>> >>
>> >>> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> >>>> value. Looks like this has been broken since
>> >>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>> >>>>
>> >>>> Also fixes the following W=1 warning:
>> >>>>
>> >>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>> >>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>> >>>> 259 | u32 gintmsk2;
>> >>>> | ^~~~~~~~
>> >>>>
>> >>>> Cc: Minas Harutyunyan <[email protected]>
>> >>>> Cc: Ben Dooks <[email protected]>
>> >>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> >>>> Signed-off-by: Lee Jones <[email protected]>
>> >>>
>> >>> Acked-by: Minas Harutyunyan <[email protected]>
>> >>
>> >> Should I apply the entire series or only 1/8?
>> >>
>> > In this series only 2 patches are related to dwc2, which I'm already Acked:
>> >
>> > [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
>> > [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control
>> > register
>> >
>> > I can't acked other patches from this series, because they are not
>> > related to dwc2.
>>
>> heh, I saw that after sending the email, sorry :-)
>
> Also, all patches are already in -next, courtesy of Greg.
Cool, I'll rebase on top of Greg's branch
--
balbi