2020-09-09 08:48:13

by Jing Xiangfeng

Subject: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe()

esas2r_probe() calls scsi_host_put() in an error path. However,
esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/scsi/esas2r/esas2r_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c
index 7b49e2e9fcde..7d3fa9dac4ce 100644
--- a/drivers/scsi/esas2r/esas2r_main.c
+++ b/drivers/scsi/esas2r/esas2r_main.c
@@ -456,7 +456,7 @@ static int esas2r_probe(struct pci_dev *pcid,

scsi_host_put(host);

- esas2r_log_dev(ESAS2R_LOG_INFO, &(host->shost_gendev),
+ esas2r_log_dev(ESAS2R_LOG_INFO, NULL,
"pci_set_drvdata(%p, NULL) called",
pcid);

--
2.17.1

2020-09-15 21:49:25

by Martin K. Petersen

Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe()

Jing,

> esas2r_probe() calls scsi_host_put() in an error path. However,
> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.

Wouldn't it be better to move the scsi_host_put() call after the error
message?

--
Martin K. Petersen Oracle Linux Engineering

2020-09-16 20:39:23

by Jing Xiangfeng

Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe()

On 2020/9/16 5:44, Martin K. Petersen wrote:
>
> Jing,
>
>> esas2r_probe() calls scsi_host_put() in an error path. However,
>> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.
>
> Wouldn't it be better to move the scsi_host_put() call after the error
> message?

There is already a message before the scsi_host_put() call. It is used
to record calling function.

>

2020-09-30 00:54:29

by Jing Xiangfeng

Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe()

On 2020/9/16 5:44, Martin K. Petersen wrote:
>
> Jing,
>
>> esas2r_probe() calls scsi_host_put() in an error path. However,
>> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.
>
> Wouldn't it be better to move the scsi_host_put() call after the error
> message?

There is already a message before the scsi_host_put() call. It is used
to record calling function.

>