2022-09-02 13:57:48

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time. Fix this up by properly
> calling dput().
>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Rodrigo Siqueira <[email protected]>
> Cc: Alex Deucher <[email protected]>
> Cc: "Christian K?nig" <[email protected]>
> Cc: "Pan, Xinhui" <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Wayne Lin <[email protected]>
> Cc: hersen wu <[email protected]>
> Cc: Wenjing Liu <[email protected]>
> Cc: Patrik Jakobsson <[email protected]>
> Cc: Thelford Williams <[email protected]>
> Cc: Fangzhi Zuo <[email protected]>
> Cc: Yongzhi Liu <[email protected]>
> Cc: Mikita Lipski <[email protected]>
> Cc: Jiapeng Chong <[email protected]>
> Cc: Bhanuprakash Modem <[email protected]>
> Cc: Sean Paul <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---

Despite a zillion cc: items, I forgot to cc: stable on this. Can the
maintainer add that here, or do you all want me to resend it with that
item added?

thanks,

greg k-h


2022-09-06 16:08:43

by Rodrigo Siqueira Jordao

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()



On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>> When calling debugfs_lookup() the result must have dput() called on it,
>> otherwise the memory will leak over time. Fix this up by properly
>> calling dput().
>>
>> Cc: Harry Wentland <[email protected]>
>> Cc: Leo Li <[email protected]>
>> Cc: Rodrigo Siqueira <[email protected]>
>> Cc: Alex Deucher <[email protected]>
>> Cc: "Christian König" <[email protected]>
>> Cc: "Pan, Xinhui" <[email protected]>
>> Cc: David Airlie <[email protected]>
>> Cc: Daniel Vetter <[email protected]>
>> Cc: Wayne Lin <[email protected]>
>> Cc: hersen wu <[email protected]>
>> Cc: Wenjing Liu <[email protected]>
>> Cc: Patrik Jakobsson <[email protected]>
>> Cc: Thelford Williams <[email protected]>
>> Cc: Fangzhi Zuo <[email protected]>
>> Cc: Yongzhi Liu <[email protected]>
>> Cc: Mikita Lipski <[email protected]>
>> Cc: Jiapeng Chong <[email protected]>
>> Cc: Bhanuprakash Modem <[email protected]>
>> Cc: Sean Paul <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>> ---
>
> Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> maintainer add that here, or do you all want me to resend it with that
> item added?
>
> thanks,
>
> greg k-h

Hi Greg,

Reviewed-by: Rodrigo Siqueira <[email protected]>

Is 'Cc: [email protected]' enough here? I can make this change
before I merge it into amd-staging-drm-next.

Thanks
Siqueira

2022-09-06 16:37:23

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <[email protected]>
> > > Cc: Leo Li <[email protected]>
> > > Cc: Rodrigo Siqueira <[email protected]>
> > > Cc: Alex Deucher <[email protected]>
> > > Cc: "Christian K?nig" <[email protected]>
> > > Cc: "Pan, Xinhui" <[email protected]>
> > > Cc: David Airlie <[email protected]>
> > > Cc: Daniel Vetter <[email protected]>
> > > Cc: Wayne Lin <[email protected]>
> > > Cc: hersen wu <[email protected]>
> > > Cc: Wenjing Liu <[email protected]>
> > > Cc: Patrik Jakobsson <[email protected]>
> > > Cc: Thelford Williams <[email protected]>
> > > Cc: Fangzhi Zuo <[email protected]>
> > > Cc: Yongzhi Liu <[email protected]>
> > > Cc: Mikita Lipski <[email protected]>
> > > Cc: Jiapeng Chong <[email protected]>
> > > Cc: Bhanuprakash Modem <[email protected]>
> > > Cc: Sean Paul <[email protected]>
> > > Cc: [email protected]
> > > Cc: [email protected]
> > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <[email protected]>
>
> Is 'Cc: [email protected]' enough here? I can make this change before I
> merge it into amd-staging-drm-next.

Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.

thanks,

greg k-h