Signed-off-by: Luis de Bethencourt <[email protected]>
---
Hi all,
Testing the waters with this cleanup patch. If it is OK to send these there are
two very similar ones, plus more in general. Happy to send them.
I have a C.H.I.P. board, which is why this driver is interesting for me to play
with.
Thanks,
Luis
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 3fca0c2d4c8d..da59496f6e04 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -967,7 +967,7 @@ static int rtw_wx_set_mode(struct net_device *dev, struct iw_request_info *a,
break;
default :
- ret = -EINVAL;;
+ ret = -EINVAL;
RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_err_, ("\n Mode: %s is not supported \n", iw_operation_mode[wrqu->mode]));
goto exit;
}
--
2.15.1
On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
I can't take patches without any changelog text, sorry :(
On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>> Signed-off-by: Luis de Bethencourt <[email protected]>
>> ---
>
> I can't take patches without any changelog text, sorry :(
>
Hi Greg,
I have done some research around previous patches to this driver and
I am not entirely sure what you mean.
Sorry, but I need to ask before sending a v2.
Do you mind I'm missing a small summary in the commit message? Fix is
so small I thought just the commit subject would be enough.
It is something different let me know and I will correct it.
Thanks,
Luis
Hi,
On 09-01-18 17:02, Luis de Bethencourt wrote:
> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>>> Signed-off-by: Luis de Bethencourt <[email protected]>
>>> ---
>>
>> I can't take patches without any changelog text, sorry :(
>>
>
> Hi Greg,
>
> I have done some research around previous patches to this driver and
> I am not entirely sure what you mean.
>
> Sorry, but I need to ask before sending a v2.
>
> Do you mind I'm missing a small summary in the commit message? Fix is
> so small I thought just the commit subject would be enough.
>
> It is something different let me know and I will correct it.
I'm not entirely sure, but I believe Greg may have a script for this,
given the amount of mail he receives and commits without a changelog
in general not being a good idea.
What I usually do with trivial patches like this, is simply take the
part after the last : in the subject, append a "." and voila you've
a changelog txt. So in this case that would simply be:
Fix trailing semicolon.
Regards,
Hans
On 01/09/2018 04:11 PM, Hans de Goede wrote:
> Hi,
>
> On 09-01-18 17:02, Luis de Bethencourt wrote:
>> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>>>> Signed-off-by: Luis de Bethencourt <[email protected]>
>>>> ---
>>>
>>> I can't take patches without any changelog text, sorry :(
>>>
>>
>> Hi Greg,
>>
>> I have done some research around previous patches to this driver and
>> I am not entirely sure what you mean.
>>
>> Sorry, but I need to ask before sending a v2.
>>
>> Do you mind I'm missing a small summary in the commit message? Fix is
>> so small I thought just the commit subject would be enough.
>>
>> It is something different let me know and I will correct it.
>
> I'm not entirely sure, but I believe Greg may have a script for this,
> given the amount of mail he receives and commits without a changelog
> in general not being a good idea.
>
> What I usually do with trivial patches like this, is simply take the
> part after the last : in the subject, append a "." and voila you've
> a changelog txt. So in this case that would simply be:
>
> Fix trailing semicolon.
>
> Regards,
>
> Hans
>
>
>
Hi Hans,
That was my plan! Resending.
I like your detailed step-by-step guide :)
Thanks,
Luis
On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote:
> Hi,
>
> On 09-01-18 17:02, Luis de Bethencourt wrote:
> > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
> > > > Signed-off-by: Luis de Bethencourt <[email protected]>
> > > > ---
> > >
> > > I can't take patches without any changelog text, sorry :(
> > >
> >
> > Hi Greg,
> >
> > I have done some research around previous patches to this driver and
> > I am not entirely sure what you mean.
> >
> > Sorry, but I need to ask before sending a v2.
> >
> > Do you mind I'm missing a small summary in the commit message? Fix is
> > so small I thought just the commit subject would be enough.
> >
> > It is something different let me know and I will correct it.
>
> I'm not entirely sure, but I believe Greg may have a script for this,
> given the amount of mail he receives and commits without a changelog
> in general not being a good idea.
No script for this, yet :)
> What I usually do with trivial patches like this, is simply take the
> part after the last : in the subject, append a "." and voila you've
> a changelog txt. So in this case that would simply be:
>
> Fix trailing semicolon.
Ick, no, come on, you can do it correctly...
greg k-h