This driver is for chips that operate only in the 2.4 GHz band.
Frequencies for 5 GHz channels can be removed from the ch_freq_map
array.
Signed-off-by: Michael Straube <[email protected]>
---
drivers/staging/r8188eu/core/rtw_rf.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_rf.c b/drivers/staging/r8188eu/core/rtw_rf.c
index e704092d31d0..51425971782b 100644
--- a/drivers/staging/r8188eu/core/rtw_rf.c
+++ b/drivers/staging/r8188eu/core/rtw_rf.c
@@ -17,22 +17,6 @@ static struct ch_freq ch_freq_map[] = {
{1, 2412}, {2, 2417}, {3, 2422}, {4, 2427}, {5, 2432},
{6, 2437}, {7, 2442}, {8, 2447}, {9, 2452}, {10, 2457},
{11, 2462}, {12, 2467}, {13, 2472}, {14, 2484},
- /* UNII */
- {36, 5180}, {40, 5200}, {44, 5220}, {48, 5240}, {52, 5260},
- {56, 5280}, {60, 5300}, {64, 5320}, {149, 5745}, {153, 5765},
- {157, 5785}, {161, 5805}, {165, 5825}, {167, 5835}, {169, 5845},
- {171, 5855}, {173, 5865},
- /* HiperLAN2 */
- {100, 5500}, {104, 5520}, {108, 5540}, {112, 5560}, {116, 5580},
- {120, 5600}, {124, 5620}, {128, 5640}, {132, 5660}, {136, 5680},
- {140, 5700},
- /* Japan MMAC */
- {34, 5170}, {38, 5190}, {42, 5210}, {46, 5230},
- /* Japan */
- {184, 4920}, {188, 4940}, {192, 4960}, {196, 4980},
- {208, 5040},/* Japan, means J08 */
- {212, 5060},/* Japan, means J12 */
- {216, 5080},/* Japan, means J16 */
};
static int ch_freq_map_num = ARRAY_SIZE(ch_freq_map);
--
2.35.1
On 2/21/22 18:13, Greg KH wrote:
> On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
>> This driver is for chips that operate only in the 2.4 GHz band.
>
> How do we know that?
>
The documentation that I've found for RTL8188EU and RTL8188ETV says
that both are 2.4 Ghz only chips.
Also the old rtl8188eu driver had a TODO item to remove code that is
only valid for 5 GHz.
So I thought this can be removed. Did I miss something?
regards,
Michael
On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
> This driver is for chips that operate only in the 2.4 GHz band.
How do we know that?
thanks,
greg k-h
On 2/21/22 11:13, Greg KH wrote:
> On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
>> This driver is for chips that operate only in the 2.4 GHz band.
>
> How do we know that?
>
> thanks,
Realtek
(https://www.realtek.com/en/products/communications-network-ics/item/rtl8188eus)
states the following:
"The Realtek RTL8188EUS is an 802.11bgn 2.4G single-chip that integrates
Wireless LAN (WLAN) and a network USB interface (USB 1.0/1.1/2.0 compatible)
controller. It combines a WLAN MAC, a 1T1R capable WLAN baseband, and WLAN RF in
a single chip. The RTL8188EUS provides a complete solution for high-throughput
performance and low power consumption integrated wireless LAN devices."
The reason there are 5G snippets in the driver is because Realtek uses the base
code to generate drivers for other chip families such as RTL8192DU that have
radios for both 2.4 and 5G bands. The RTL81288EU and variants have only a single
radio.
Larry
On Mon, Feb 21, 2022 at 01:41:22PM -0600, Larry Finger wrote:
> On 2/21/22 11:13, Greg KH wrote:
> > On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
> > > This driver is for chips that operate only in the 2.4 GHz band.
> >
> > How do we know that?
> >
> > thanks,
> Realtek (https://www.realtek.com/en/products/communications-network-ics/item/rtl8188eus)
> states the following:
>
> "The Realtek RTL8188EUS is an 802.11bgn 2.4G single-chip that integrates
> Wireless LAN (WLAN) and a network USB interface (USB 1.0/1.1/2.0 compatible)
> controller. It combines a WLAN MAC, a 1T1R capable WLAN baseband, and WLAN
> RF in a single chip. The RTL8188EUS provides a complete solution for
> high-throughput performance and low power consumption integrated wireless
> LAN devices."
>
> The reason there are 5G snippets in the driver is because Realtek uses the
> base code to generate drivers for other chip families such as RTL8192DU that
> have radios for both 2.4 and 5G bands. The RTL81288EU and variants have only
> a single radio.
Ah, ok, that's good to know. And should belong in the changelog text so
that we are not confused :)
thanks,
greg k-h