2020-12-01 11:46:47

by Zou Wei

Subject: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword

Fix the following sparse warning:

drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/firmware/xilinx/zynqmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index d08ac82..fd95ede 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -29,7 +29,7 @@
#define PM_API_FEATURE_CHECK_MAX_ORDER 7

static bool feature_check_enabled;
-DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
+static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);

/**
* struct pm_api_feature_data - PM API Feature data
--
2.6.2

2020-12-01 12:09:26

by Michal Simek

Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword

On 01. 12. 20 12:51, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/firmware/xilinx/zynqmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index d08ac82..fd95ede 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -29,7 +29,7 @@
> #define PM_API_FEATURE_CHECK_MAX_ORDER 7
>
> static bool feature_check_enabled;
> -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
> +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>
> /**
> * struct pm_api_feature_data - PM API Feature data
>

The patch is good but I am missing fixed tag to get it to LTS.
When you add it please add my
Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal

2020-12-01 21:28:53

by Greg Kroah-Hartman

Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword

On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
>
>
> On 01. 12. 20 12:51, Zou Wei wrote:
> > Fix the following sparse warning:
> >
> > drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
> >
> > Signed-off-by: Zou Wei <[email protected]>
> > ---
> > drivers/firmware/xilinx/zynqmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> > index d08ac82..fd95ede 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -29,7 +29,7 @@
> > #define PM_API_FEATURE_CHECK_MAX_ORDER 7
> >
> > static bool feature_check_enabled;
> > -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
> > +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
> >
> > /**
> > * struct pm_api_feature_data - PM API Feature data
> >
>
> The patch is good but I am missing fixed tag to get it to LTS.

Why is this needed for any stable kernel release? It's a sparse
warning, no one trips across those in stable kernels...

thanks,

greg k-h

2020-12-02 07:34:06

by Michal Simek

Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword

On 01. 12. 20 22:26, Greg KH wrote:
> On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
>>
>>
>> On 01. 12. 20 12:51, Zou Wei wrote:
>>> Fix the following sparse warning:
>>>
>>> drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
>>>
>>> Signed-off-by: Zou Wei <[email protected]>
>>> ---
>>> drivers/firmware/xilinx/zynqmp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>>> index d08ac82..fd95ede 100644
>>> --- a/drivers/firmware/xilinx/zynqmp.c
>>> +++ b/drivers/firmware/xilinx/zynqmp.c
>>> @@ -29,7 +29,7 @@
>>> #define PM_API_FEATURE_CHECK_MAX_ORDER 7
>>>
>>> static bool feature_check_enabled;
>>> -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>> +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>>
>>> /**
>>> * struct pm_api_feature_data - PM API Feature data
>>>
>>
>> The patch is good but I am missing fixed tag to get it to LTS.
>
> Why is this needed for any stable kernel release? It's a sparse
> warning, no one trips across those in stable kernels...

Ok thanks for explanation.

Applied to zynqmp/soc branch.

Thanks,
Michal