From: Peng Fan <[email protected]>
Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/power/fsl,scu-pd.yaml | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
index 407b7cfec783..3a92e4fef7ae 100644
--- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
@@ -18,11 +18,14 @@ allOf:
properties:
compatible:
- items:
+ oneOf:
- enum:
- - fsl,imx8qm-scu-pd
- - fsl,imx8qxp-scu-pd
- - const: fsl,scu-pd
+ - fsl,scu-pd
+ - items:
+ - enum:
+ - fsl,imx8qm-scu-pd
+ - fsl,imx8qxp-scu-pd
+ - const: fsl,scu-pd
'#power-domain-cells':
const: 1
--
2.37.1
On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
Why not just add a soc-specific compatible for the i.MX8DXL?
The current form of this does not look right to me.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../devicetree/bindings/power/fsl,scu-pd.yaml | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - enum:
> - - fsl,imx8qm-scu-pd
> - - fsl,imx8qxp-scu-pd
> - - const: fsl,scu-pd
> + - fsl,scu-pd
> + - items:
> + - enum:
> + - fsl,imx8qm-scu-pd
> + - fsl,imx8qxp-scu-pd
> + - const: fsl,scu-pd
>
> '#power-domain-cells':
> const: 1
> --
> 2.37.1
>
> Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
>
> On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
>
> Why not just add a soc-specific compatible for the i.MX8DXL?
> The current form of this does not look right to me.
I could add one dedicated for i.MX8DXL.
Thanks,
Peng.
>
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > .../devicetree/bindings/power/fsl,scu-pd.yaml | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > index 407b7cfec783..3a92e4fef7ae 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > @@ -18,11 +18,14 @@ allOf:
> >
> > properties:
> > compatible:
> > - items:
> > + oneOf:
> > - enum:
> > - - fsl,imx8qm-scu-pd
> > - - fsl,imx8qxp-scu-pd
> > - - const: fsl,scu-pd
> > + - fsl,scu-pd
> > + - items:
> > + - enum:
> > + - fsl,imx8qm-scu-pd
> > + - fsl,imx8qxp-scu-pd
> > + - const: fsl,scu-pd
> >
> > '#power-domain-cells':
> > const: 1
> > --
> > 2.37.1
> >
On Wed, Jul 26, 2023 at 12:21:10AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
> >
> > On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <[email protected]>
> > >
> > > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> >
> > Why not just add a soc-specific compatible for the i.MX8DXL?
> > The current form of this does not look right to me.
>
> I could add one dedicated for i.MX8DXL.
Also, where is the user for this? I'd expect to see a dts patch too?
> > > Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-
> pd
> > >
> > > On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <[email protected]>
> > > >
> > > > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> > >
> > > Why not just add a soc-specific compatible for the i.MX8DXL?
> > > The current form of this does not look right to me.
> >
> > I could add one dedicated for i.MX8DXL.
>
> Also, where is the user for this? I'd expect to see a dts patch too?
arch/arm64/boot/dts/freescale/imx8dxl.dtsi scu node
not use fsl,imx8dxl-scxx. It's already in tree.I am just trying to address
the dtbs_check issue.
Regards,
Peng.
On 25/07/2023 12:29, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../devicetree/bindings/power/fsl,scu-pd.yaml | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - enum:
> - - fsl,imx8qm-scu-pd
> - - fsl,imx8qxp-scu-pd
> - - const: fsl,scu-pd
> + - fsl,scu-pd
No, sorry, you got in the past comments about style of compatibles.
Best regards,
Krzysztof