When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. Fix this up by properly
calling dput().
Cc: Harry Wentland <[email protected]>
Cc: Leo Li <[email protected]>
Cc: Rodrigo Siqueira <[email protected]>
Cc: Alex Deucher <[email protected]>
Cc: "Christian König" <[email protected]>
Cc: "Pan, Xinhui" <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Wayne Lin <[email protected]>
Cc: hersen wu <[email protected]>
Cc: Wenjing Liu <[email protected]>
Cc: Patrik Jakobsson <[email protected]>
Cc: Thelford Williams <[email protected]>
Cc: Fangzhi Zuo <[email protected]>
Cc: Yongzhi Liu <[email protected]>
Cc: Mikita Lipski <[email protected]>
Cc: Jiapeng Chong <[email protected]>
Cc: Bhanuprakash Modem <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 0e48824f55e3..ee242d9d8b06 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3288,6 +3288,7 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
&crc_win_y_end_fops);
debugfs_create_file_unsafe("crc_win_update", 0644, dir, crtc,
&crc_win_update_fops);
+ dput(dir);
#endif
debugfs_create_file("amdgpu_current_bpc", 0644, crtc->debugfs_entry,
crtc, &amdgpu_current_bpc_fops);
--
2.37.3
On 2022-09-06 11:06, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>>
>>
>> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
>>> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>>>> When calling debugfs_lookup() the result must have dput() called on it,
>>>> otherwise the memory will leak over time. Fix this up by properly
>>>> calling dput().
>>>>
>>>> Cc: Harry Wentland <[email protected]>
>>>> Cc: Leo Li <[email protected]>
>>>> Cc: Rodrigo Siqueira <[email protected]>
>>>> Cc: Alex Deucher <[email protected]>
>>>> Cc: "Christian König" <[email protected]>
>>>> Cc: "Pan, Xinhui" <[email protected]>
>>>> Cc: David Airlie <[email protected]>
>>>> Cc: Daniel Vetter <[email protected]>
>>>> Cc: Wayne Lin <[email protected]>
>>>> Cc: hersen wu <[email protected]>
>>>> Cc: Wenjing Liu <[email protected]>
>>>> Cc: Patrik Jakobsson <[email protected]>
>>>> Cc: Thelford Williams <[email protected]>
>>>> Cc: Fangzhi Zuo <[email protected]>
>>>> Cc: Yongzhi Liu <[email protected]>
>>>> Cc: Mikita Lipski <[email protected]>
>>>> Cc: Jiapeng Chong <[email protected]>
>>>> Cc: Bhanuprakash Modem <[email protected]>
>>>> Cc: Sean Paul <[email protected]>
>>>> Cc: [email protected]
>>>> Cc: [email protected]
>>>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>>>> ---
>>>
>>> Despite a zillion cc: items, I forgot to cc: stable on this. Can the
>>> maintainer add that here, or do you all want me to resend it with that
>>> item added?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Hi Greg,
>>
>> Reviewed-by: Rodrigo Siqueira <[email protected]>
>>
>> Is 'Cc: [email protected]' enough here? I can make this change before I
>> merge it into amd-staging-drm-next.
>
> Yes, please add the cc: stable@ line to the body of the patch, sorry I
> forgot that.
>
Change applied to amd-staging-drm-next, with the Cc to the stable branch.
Thanks
Siqueira
> thanks,
>
> greg k-h
On Tue, Sep 06, 2022 at 11:39:44AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-06 11:06, Greg Kroah-Hartman wrote:
> > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
> > >
> > >
> > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > > > When calling debugfs_lookup() the result must have dput() called on it,
> > > > > otherwise the memory will leak over time. Fix this up by properly
> > > > > calling dput().
> > > > >
> > > > > Cc: Harry Wentland <[email protected]>
> > > > > Cc: Leo Li <[email protected]>
> > > > > Cc: Rodrigo Siqueira <[email protected]>
> > > > > Cc: Alex Deucher <[email protected]>
> > > > > Cc: "Christian K?nig" <[email protected]>
> > > > > Cc: "Pan, Xinhui" <[email protected]>
> > > > > Cc: David Airlie <[email protected]>
> > > > > Cc: Daniel Vetter <[email protected]>
> > > > > Cc: Wayne Lin <[email protected]>
> > > > > Cc: hersen wu <[email protected]>
> > > > > Cc: Wenjing Liu <[email protected]>
> > > > > Cc: Patrik Jakobsson <[email protected]>
> > > > > Cc: Thelford Williams <[email protected]>
> > > > > Cc: Fangzhi Zuo <[email protected]>
> > > > > Cc: Yongzhi Liu <[email protected]>
> > > > > Cc: Mikita Lipski <[email protected]>
> > > > > Cc: Jiapeng Chong <[email protected]>
> > > > > Cc: Bhanuprakash Modem <[email protected]>
> > > > > Cc: Sean Paul <[email protected]>
> > > > > Cc: [email protected]
> > > > > Cc: [email protected]
> > > > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > > > > ---
> > > >
> > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > > > maintainer add that here, or do you all want me to resend it with that
> > > > item added?
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Hi Greg,
> > >
> > > Reviewed-by: Rodrigo Siqueira <[email protected]>
> > >
> > > Is 'Cc: [email protected]' enough here? I can make this change before I
> > > merge it into amd-staging-drm-next.
> >
> > Yes, please add the cc: stable@ line to the body of the patch, sorry I
> > forgot that.
> >
>
> Change applied to amd-staging-drm-next, with the Cc to the stable branch.
Wonderful, thanks!