2021-12-10 02:29:17

by CGEL

Subject: [PATCH] tools/perf: remove unneeded variable make code cleaner

From: Minghao Chi <[email protected]>

return value form directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
tools/perf/util/callchain.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 8e2777133bd9..ed30da7e14ab 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -1301,24 +1301,16 @@ int callchain_branch_counts(struct callchain_root *root,

static int count_pri64_printf(int idx, const char *str, u64 value, char *bf, int bfsize)
{
- int printed;
-
- printed = scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
-
- return printed;
+ return scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
}

static int count_float_printf(int idx, const char *str, float value,
char *bf, int bfsize, float threshold)
{
- int printed;
-
if (threshold != 0.0 && value < threshold)
return 0;

- printed = scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
-
- return printed;
+ return scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
}

static int branch_to_str(char *bf, int bfsize,
--
2.25.1

2021-12-10 09:12:26

by kajoljain

Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner

On 12/10/21 7:59 AM, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> return value form directly instead of
> taking this in another redundant variable.

Can we reword the commit message stating what and
from where we are removing it. Its not too clear.
Other than that patch looks good to me.

Reviewed-By: Kajol Jain<[email protected]>

Thanks,
Kajol Jain

>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> tools/perf/util/callchain.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index 8e2777133bd9..ed30da7e14ab 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -1301,24 +1301,16 @@ int callchain_branch_counts(struct callchain_root *root,
>
> static int count_pri64_printf(int idx, const char *str, u64 value, char *bf, int bfsize)
> {
> - int printed;
> -
> - printed = scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
> -
> - return printed;
> + return scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
> }
>
> static int count_float_printf(int idx, const char *str, float value,
> char *bf, int bfsize, float threshold)
> {
> - int printed;
> -
> if (threshold != 0.0 && value < threshold)
> return 0;
>
> - printed = scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
> -
> - return printed;
> + return scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
> }
>
> static int branch_to_str(char *bf, int bfsize,
>

2021-12-10 10:42:23

by Peter Zijlstra

Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner

On Fri, Dec 10, 2021 at 02:41:55PM +0530, kajoljain wrote:
>
>
> On 12/10/21 7:59 AM, [email protected] wrote:
> > From: Minghao Chi <[email protected]>
> >
> > return value form directly instead of
> > taking this in another redundant variable.
>
> Can we reword the commit message stating what and
> from where we are removing it. Its not too clear.
> Other than that patch looks good to me.
>
> Reviewed-By: Kajol Jain<[email protected]>

Never reply or accept email from [email protected], there's multiple
people using it to send email, this cannot be right.

2021-12-10 12:45:13

by kajoljain

Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner

On 12/10/21 4:12 PM, Peter Zijlstra wrote:
> On Fri, Dec 10, 2021 at 02:41:55PM +0530, kajoljain wrote:
>>
>>
>> On 12/10/21 7:59 AM, [email protected] wrote:
>>> From: Minghao Chi <[email protected]>
>>>
>>> return value form directly instead of
>>> taking this in another redundant variable.
>>
>> Can we reword the commit message stating what and
>> from where we are removing it. Its not too clear.
>> Other than that patch looks good to me.
>>
>> Reviewed-By: Kajol Jain<[email protected]>
>
> Never reply or accept email from [email protected], there's multiple
> people using it to send email, this cannot be right.
>

Sure peter, Thanks for pointing it. Will take care next time.

Thanks,
Kajol Jain