2017-12-18 16:05:29

by Dmitry Fleytman

Subject: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

From: Dmitry Fleytman Dmitry Fleytman <[email protected]>

Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround an issue with some Logitech webcams.

There is one more model that has the same issue - C925e, so applying
the same quirk as well.

See aforementioned commit message for detailed explanation of the problem.

Signed-off-by: Dmitry Fleytman <[email protected]>
---
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a10b346b9777..6d2d3b0bcc2a 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Microsoft LifeCam-VX700 v2.0 */
{ USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },

- /* Logitech HD Pro Webcams C920, C920-C and C930e */
+ /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },

/* Logitech ConferenceCam CC3000e */
{ USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
--
2.14.1

2017-12-18 18:08:39

by Kai-Heng Feng

Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

Hi,

> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman <[email protected]> wrote:
>
> From: Dmitry Fleytman Dmitry Fleytman <[email protected]>
>
> Commit e0429362ab15
> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
> introduced quirk to workaround an issue with some Logitech webcams.
>
> There is one more model that has the same issue - C925e, so applying
> the same quirk as well.
>
> See aforementioned commit message for detailed explanation of the problem.
>
> Signed-off-by: Dmitry Fleytman <[email protected]>
> ---
> drivers/usb/core/quirks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a10b346b9777..6d2d3b0bcc2a 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Microsoft LifeCam-VX700 v2.0 */
> { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
>
> - /* Logitech HD Pro Webcams C920, C920-C and C930e */
> + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
> { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
> + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },

Nitpicking here, but maybe use 0x085b instead of 0x085B?

Kai-Heng

>
> /* Logitech ConferenceCam CC3000e */
> { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
> --
> 2.14.1
>

2017-12-19 03:52:58

by Dmitry Fleytman

Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

> On 18 Dec 2017, at 20:07, Kai-Heng Feng <[email protected]> wrote:
>
> Hi,
>
>> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman <[email protected]> wrote:
>>
>> From: Dmitry Fleytman Dmitry Fleytman <[email protected]>
>>
>> Commit e0429362ab15
>> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
>> introduced quirk to workaround an issue with some Logitech webcams.
>>
>> There is one more model that has the same issue - C925e, so applying
>> the same quirk as well.
>>
>> See aforementioned commit message for detailed explanation of the problem.
>>
>> Signed-off-by: Dmitry Fleytman <[email protected]>
>> ---
>> drivers/usb/core/quirks.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index a10b346b9777..6d2d3b0bcc2a 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
>> /* Microsoft LifeCam-VX700 v2.0 */
>> { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
>>
>> - /* Logitech HD Pro Webcams C920, C920-C and C930e */
>> + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
>> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
>> { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
>> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>> + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },
>
> Nitpicking here, but maybe use 0x085b instead of 0x085B?

Yes. Sending v2...

>
> Kai-Heng
>
>>
>> /* Logitech ConferenceCam CC3000e */
>> { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
>> --
>> 2.14.1

2017-12-19 04:02:30

by Dmitry Fleytman

Subject: [PATCH v2] usb: Add device quirk for Logitech HD Pro Webcam C925e

From: Dmitry Fleytman Dmitry Fleytman <[email protected]>

Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround an issue with some Logitech webcams.

There is one more model that has the same issue - C925e, so applying
the same quirk as well.

See aforementioned commit message for detailed explanation of the problem.

Signed-off-by: Dmitry Fleytman <[email protected]>
---
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a10b346b9777..848da96614e8 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Microsoft LifeCam-VX700 v2.0 */
{ USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },

- /* Logitech HD Pro Webcams C920, C920-C and C930e */
+ /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x046d, 0x085b), .driver_info = USB_QUIRK_DELAY_INIT },

/* Logitech ConferenceCam CC3000e */
{ USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
--
2.14.1