2021-06-01 08:23:07

by Zhihao Cheng

Subject: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhihao Cheng <[email protected]>
---
drivers/remoteproc/pru_rproc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index e5778e476245..6491c731c6e2 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
mem_names[i]);
pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
if (IS_ERR(pru->mem_regions[i].va)) {
- dev_err(dev, "failed to parse and map memory resource %d %s\n",
- i, mem_names[i]);
ret = PTR_ERR(pru->mem_regions[i].va);
return ret;
}
--
2.31.1

2021-06-01 15:22:06

by Mathieu Poirier

Subject: Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()

On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhihao Cheng <[email protected]>
> ---
> drivers/remoteproc/pru_rproc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..6491c731c6e2 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
> mem_names[i]);
> pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
> if (IS_ERR(pru->mem_regions[i].va)) {
> - dev_err(dev, "failed to parse and map memory resource %d %s\n",
> - i, mem_names[i]);

https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/

> ret = PTR_ERR(pru->mem_regions[i].va);
> return ret;
> }
> --
> 2.31.1
>

2021-06-02 03:33:22

by Zhihao Cheng

Subject: Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()

?? 2021/6/1 23:20, Mathieu Poirier д??:
> On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote:
>
> @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
> mem_names[i]);
> pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
> if (IS_ERR(pru->mem_regions[i].va)) {
> - dev_err(dev, "failed to parse and map memory resource %d %s\n",
> - i, mem_names[i]);
> https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
Thanks for reminding. Ignore this patch.
>> ret = PTR_ERR(pru->mem_regions[i].va);
>> return ret;
>> }
>> --
>> 2.31.1
>>
> .