2022-11-20 16:48:38

by Haifeng Xu

[permalink] [raw]
Subject: [PATCH] cgroup: Fix typo in comment

Replace iff with if.

Signed-off-by: haifeng.xu <[email protected]>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index f2743a476190..93c5e50b1392 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
* One of the css_sets associated with @cgrp is either getting its first
* task or losing the last. Update @cgrp->nr_populated_* accordingly. The
* count is propagated towards root so that a given cgroup's
- * nr_populated_children is zero iff none of its descendants contain any
+ * nr_populated_children is zero if none of its descendants contain any
* tasks.
*
* @cgrp's interface file "cgroup.populated" is zero if both
--
2.25.1



2022-11-20 17:02:41

by Kamalesh Babulal

[permalink] [raw]
Subject: Re: [PATCH] cgroup: Fix typo in comment



On 11/20/22 21:21, haifeng.xu wrote:
> Replace iff with if.
>
> Signed-off-by: haifeng.xu <[email protected]>
> ---
> kernel/cgroup/cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index f2743a476190..93c5e50b1392 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
> * One of the css_sets associated with @cgrp is either getting its first
> * task or losing the last. Update @cgrp->nr_populated_* accordingly. The
> * count is propagated towards root so that a given cgroup's
> - * nr_populated_children is zero iff none of its descendants contain any
> + * nr_populated_children is zero if none of its descendants contain any
> * tasks.
> *
> * @cgrp's interface file "cgroup.populated" is zero if both

iff abbreviates to if and only if and it's a valid usage.

--
Thanks,
Kamalesh

2022-11-20 17:03:27

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH] cgroup: Fix typo in comment

On Sun, 2022-11-20 at 15:51 +0000, haifeng.xu wrote:
> Replace iff with if.

You can't do this without a more detailed analysis. iff means if and
only if (logical implies in both directions), which appears to be more
correct in the code being patched than if, which is logical implies in
only one direction only.

James


2022-11-21 02:26:27

by Haifeng Xu

[permalink] [raw]
Subject: Re: [PATCH] cgroup: Fix typo in comment



On 2022/11/21 00:38, Kamalesh Babulal wrote:
>
>
> On 11/20/22 21:21, haifeng.xu wrote:
>> Replace iff with if.
>>
>> Signed-off-by: haifeng.xu <[email protected]>
>> ---
>> kernel/cgroup/cgroup.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
>> index f2743a476190..93c5e50b1392 100644
>> --- a/kernel/cgroup/cgroup.c
>> +++ b/kernel/cgroup/cgroup.c
>> @@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
>> * One of the css_sets associated with @cgrp is either getting its first
>> * task or losing the last. Update @cgrp->nr_populated_* accordingly. The
>> * count is propagated towards root so that a given cgroup's
>> - * nr_populated_children is zero iff none of its descendants contain any
>> + * nr_populated_children is zero if none of its descendants contain any
>> * tasks.
>> *
>> * @cgrp's interface file "cgroup.populated" is zero if both
>
> iff abbreviates to if and only if and it's a valid usage.
>

Ok, thanks.