2024-02-23 17:33:39

by Varshini Rajendran

Subject: [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7

Add support for SAM9X7 SoC in the SoC driver.

Signed-off-by: Varshini Rajendran <[email protected]>
Reviewed-by: Claudiu Beznea <[email protected]>
---
Changes in v4:
- Sorted the entries alphabetically as per comment from Claudiu
- Updated EXID
Note: Did not remove the Reviewed-by tag since the changes were only
cosmetic and did not affect functionality
---
drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++
drivers/soc/atmel/soc.h | 9 +++++++++
2 files changed, 32 insertions(+)

diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index cc9a3e107479..cae3452cbc60 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = {
AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH,
"sam9x60 8MiB SDRAM SiP", "sam9x60"),
#endif
+#ifdef CONFIG_SOC_SAM9X7
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH,
+ "sam9x72", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH,
+ "sam9x70", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 1Gb DDR3L SiP ", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 512Mb DDR2 SiP", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 128Mb DDR2 SiP", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 2Gb DDR3L SiP", "sam9x7"),
+#endif
#ifdef CONFIG_SOC_SAMA5
AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH,
diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h
index 7a9f47ce85fb..fc4157c5f6e3 100644
--- a/drivers/soc/atmel/soc.h
+++ b/drivers/soc/atmel/soc.h
@@ -44,6 +44,7 @@ at91_soc_init(const struct at91_soc *socs);
#define AT91SAM9X5_CIDR_MATCH 0x019a05a0
#define AT91SAM9N12_CIDR_MATCH 0x019a07a0
#define SAM9X60_CIDR_MATCH 0x019b35a0
+#define SAM9X7_CIDR_MATCH 0x09750020
#define SAMA7G5_CIDR_MATCH 0x00162100

#define AT91SAM9M11_EXID_MATCH 0x00000001
@@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs);
#define SAMA7G54_D2G_EXID_MATCH 0x00000020
#define SAMA7G54_D4G_EXID_MATCH 0x00000028

+#define SAM9X70_EXID_MATCH 0x00000005
+#define SAM9X72_EXID_MATCH 0x00000004
+#define SAM9X75_D1G_EXID_MATCH 0x00000018
+#define SAM9X75_D2G_EXID_MATCH 0x00000020
+#define SAM9X75_D1M_EXID_MATCH 0x00000003
+#define SAM9X75_D5M_EXID_MATCH 0x00000010
+#define SAM9X75_EXID_MATCH 0x00000000
+
#define AT91SAM9XE128_CIDR_MATCH 0x329973a0
#define AT91SAM9XE256_CIDR_MATCH 0x329a93a0
#define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0
--
2.25.1

2024-02-26 17:13:55

by Nicolas Ferre

Subject: Re: [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7

On 23/02/2024 at 18:27, Varshini Rajendran - I67070 wrote:
> Add support for SAM9X7 SoC in the SoC driver.
>
> Signed-off-by: Varshini Rajendran <[email protected]>
> Reviewed-by: Claudiu Beznea <[email protected]>
> ---
> Changes in v4:
> - Sorted the entries alphabetically as per comment from Claudiu
> - Updated EXID
> Note: Did not remove the Reviewed-by tag since the changes were only
> cosmetic and did not affect functionality
> ---
> drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++
> drivers/soc/atmel/soc.h | 9 +++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index cc9a3e107479..cae3452cbc60 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = {
> AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH,
> "sam9x60 8MiB SDRAM SiP", "sam9x60"),
> #endif
> +#ifdef CONFIG_SOC_SAM9X7
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH,
> + "sam9x72", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH,
> + "sam9x70", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 1Gb DDR3L SiP ", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 512Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 128Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 2Gb DDR3L SiP", "sam9x7"),

(as highlighted in previous review of this patch):
https://lore.kernel.org/linux-arm-kernel/[email protected]/T/#m2dac0ce9e1991c3d714785062a76ccdce11a02a6

I want RAM size in Bytes.

Sorry but NACK.

Best regards,
Nicolas

> +#endif
> #ifdef CONFIG_SOC_SAMA5
> AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH,
> diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h
> index 7a9f47ce85fb..fc4157c5f6e3 100644
> --- a/drivers/soc/atmel/soc.h
> +++ b/drivers/soc/atmel/soc.h
> @@ -44,6 +44,7 @@ at91_soc_init(const struct at91_soc *socs);
> #define AT91SAM9X5_CIDR_MATCH 0x019a05a0
> #define AT91SAM9N12_CIDR_MATCH 0x019a07a0
> #define SAM9X60_CIDR_MATCH 0x019b35a0
> +#define SAM9X7_CIDR_MATCH 0x09750020
> #define SAMA7G5_CIDR_MATCH 0x00162100
>
> #define AT91SAM9M11_EXID_MATCH 0x00000001
> @@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs);
> #define SAMA7G54_D2G_EXID_MATCH 0x00000020
> #define SAMA7G54_D4G_EXID_MATCH 0x00000028
>
> +#define SAM9X70_EXID_MATCH 0x00000005
> +#define SAM9X72_EXID_MATCH 0x00000004
> +#define SAM9X75_D1G_EXID_MATCH 0x00000018
> +#define SAM9X75_D2G_EXID_MATCH 0x00000020
> +#define SAM9X75_D1M_EXID_MATCH 0x00000003
> +#define SAM9X75_D5M_EXID_MATCH 0x00000010
> +#define SAM9X75_EXID_MATCH 0x00000000
> +
> #define AT91SAM9XE128_CIDR_MATCH 0x329973a0
> #define AT91SAM9XE256_CIDR_MATCH 0x329a93a0
> #define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0

2024-03-03 12:21:23

by Claudiu

Subject: Re: [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7

On 23.02.2024 19:27, Varshini Rajendran wrote:
> Add support for SAM9X7 SoC in the SoC driver.
>
> Signed-off-by: Varshini Rajendran <[email protected]>
> Reviewed-by: Claudiu Beznea <[email protected]>
> ---
> Changes in v4:
> - Sorted the entries alphabetically as per comment from Claudiu
> - Updated EXID
> Note: Did not remove the Reviewed-by tag since the changes were only
> cosmetic and did not affect functionality
> ---
> drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++
> drivers/soc/atmel/soc.h | 9 +++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index cc9a3e107479..cae3452cbc60 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = {
> AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH,
> "sam9x60 8MiB SDRAM SiP", "sam9x60"),
> #endif
> +#ifdef CONFIG_SOC_SAM9X7
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH,
> + "sam9x72", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH,
> + "sam9x70", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 1Gb DDR3L SiP ", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 512Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 128Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 2Gb DDR3L SiP", "sam9x7"),

Could you keep these sorted after SoC name and memory size? E.g. see
sama7g5 entries, sama5dX entries.

> +#endif
> #ifdef CONFIG_SOC_SAMA5
> AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH,
> diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h
> index 7a9f47ce85fb..fc4157c5f6e3 100644
> --- a/drivers/soc/atmel/soc.h
> +++ b/drivers/soc/atmel/soc.h
> @@ -44,6 +44,7 @@ at91_soc_init(const struct at91_soc *socs);
> #define AT91SAM9X5_CIDR_MATCH 0x019a05a0
> #define AT91SAM9N12_CIDR_MATCH 0x019a07a0
> #define SAM9X60_CIDR_MATCH 0x019b35a0
> +#define SAM9X7_CIDR_MATCH 0x09750020
> #define SAMA7G5_CIDR_MATCH 0x00162100
>
> #define AT91SAM9M11_EXID_MATCH 0x00000001
> @@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs);
> #define SAMA7G54_D2G_EXID_MATCH 0x00000020
> #define SAMA7G54_D4G_EXID_MATCH 0x00000028
>
> +#define SAM9X70_EXID_MATCH 0x00000005
> +#define SAM9X72_EXID_MATCH 0x00000004
> +#define SAM9X75_D1G_EXID_MATCH 0x00000018
> +#define SAM9X75_D2G_EXID_MATCH 0x00000020
> +#define SAM9X75_D1M_EXID_MATCH 0x00000003
> +#define SAM9X75_D5M_EXID_MATCH 0x00000010
> +#define SAM9X75_EXID_MATCH 0x00000000

Could you keep this chunk after SAM9X60_* one to have some kind of
alphanumerical sort?

> +
> #define AT91SAM9XE128_CIDR_MATCH 0x329973a0
> #define AT91SAM9XE256_CIDR_MATCH 0x329a93a0
> #define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0