2023-02-08 08:09:09

by Ilpo Järvinen

Subject: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR

rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
normal -Exxxx codes. Convert <0 return from ->rsu_status() to
FW_UPLOAD_ERR_HW_ERROR.

Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Signed-off-by: Ilpo Järvinen <[email protected]>

---
drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
index f0acedc80182..d7e2f9f461bc 100644
--- a/drivers/fpga/intel-m10-bmc-sec-update.c
+++ b/drivers/fpga/intel-m10-bmc-sec-update.c
@@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)

ret = sec->ops->rsu_status(sec);
if (ret < 0)
- return ret;
+ return FW_UPLOAD_ERR_HW_ERROR;
status = ret;

if (!rsu_status_ok(status)) {

--
tg: (97f5496f1624..) sec/fix-error-return-code (depends on: sec/flashops-n6000)

2023-02-08 19:28:48

by Russ Weight

Subject: Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR

On 2/8/23 00:08, Ilpo Järvinen wrote:
> rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> FW_UPLOAD_ERR_HW_ERROR.
>
> Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Reviewed-by: Russ Weight <[email protected]>

> Signed-off-by: Ilpo Järvinen <[email protected]>
>
> ---
> drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> index f0acedc80182..d7e2f9f461bc 100644
> --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
>
> ret = sec->ops->rsu_status(sec);
> if (ret < 0)
> - return ret;
> + return FW_UPLOAD_ERR_HW_ERROR;
> status = ret;
>
> if (!rsu_status_ok(status)) {
>

2023-02-10 09:35:42

by Xu Yilun

Subject: Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW_ERROR

On 2023-02-08 at 11:28:26 -0800, Russ Weight wrote:
>
> On 2/8/23 00:08, Ilpo J?rvinen wrote:
> > rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> > normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> > FW_UPLOAD_ERR_HW_ERROR.
> >
> > Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
> Reviewed-by: Russ Weight <[email protected]>

Acked-by: Xu Yilun <[email protected]>

>
> > Signed-off-by: Ilpo J?rvinen <[email protected]>
> >
> > ---
> > drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> > index f0acedc80182..d7e2f9f461bc 100644
> > --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> > +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> > @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
> >
> > ret = sec->ops->rsu_status(sec);
> > if (ret < 0)
> > - return ret;
> > + return FW_UPLOAD_ERR_HW_ERROR;
> > status = ret;
> >
> > if (!rsu_status_ok(status)) {
> >
>