These messages appear each time the mouse wakes from sleep, in my case
(Logitech M705), every minute or so.
Let's downgrade them to the "debug" level so they don't fill the kernel log
by default.
While we are at it, let's make clear that this is a wheel multiplier (and
not, for example, XY movement multiplier).
Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
Cc: [email protected]
Signed-off-by: Maciej S. Szmigiero <[email protected]>
---
Sending again since the previous message bounced for most recipients.
drivers/hid/hid-logitech-hidpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 1e1cf8eae649..b8b53dc95e86 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp)
multiplier = 1;
hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
- hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
+ hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
return 0;
}
On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
> These messages appear each time the mouse wakes from sleep, in my
> case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the
> kernel log
> by default.
>
> While we are at it, let's make clear that this is a wheel multiplier
> (and
> not, for example, XY movement multiplier).
>
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
> on Logitech mice")
> Cc: [email protected]
> Signed-off-by: Maciej S. Szmigiero <[email protected]>
> ---
> Sending again since the previous message bounced for most recipients.
>
> drivers/hid/hid-logitech-hidpp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 1e1cf8eae649..b8b53dc95e86 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
> hidpp_device *hidpp)
> multiplier = 1;
>
> hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
> return 0;
> }
>
I have seen this being useful in some cases, however I do not have a
strong opinion on it. Peter would know better.
Cheers,
Filipe Laíns
On 06.07.2020 14:38, Filipe Laíns wrote:
> On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
>> These messages appear each time the mouse wakes from sleep, in my
>> case
>> (Logitech M705), every minute or so.
>> Let's downgrade them to the "debug" level so they don't fill the
>> kernel log
>> by default.
>>
>> While we are at it, let's make clear that this is a wheel multiplier
>> (and
>> not, for example, XY movement multiplier).
>>
>> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
>> on Logitech mice")
>> Cc: [email protected]
>> Signed-off-by: Maciej S. Szmigiero <[email protected]>
>> ---
>> Sending again since the previous message bounced for most recipients.
>>
>> drivers/hid/hid-logitech-hidpp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
>> logitech-hidpp.c
>> index 1e1cf8eae649..b8b53dc95e86 100644
>> --- a/drivers/hid/hid-logitech-hidpp.c
>> +++ b/drivers/hid/hid-logitech-hidpp.c
>> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
>> hidpp_device *hidpp)
>> multiplier = 1;
>>
>> hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
>> - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
>> + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
>> return 0;
>> }
>>
>
> I have seen this being useful in some cases, however I do not have a
> strong opinion on it. Peter would know better.
Well, the message is not being removed, only hidden by default, so
it doesn't fill the kernel log.
One can still enable it at runtime if wanted.
> Cheers,
> Filipe Laíns
>
Thanks,
Maciej
On Mon, 2020-07-06 at 14:41 +0200, Maciej S. Szmigiero wrote:
> On 06.07.2020 14:38, Filipe Laíns wrote:
> > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
> > > These messages appear each time the mouse wakes from sleep, in my
> > > case
> > > (Logitech M705), every minute or so.
> > > Let's downgrade them to the "debug" level so they don't fill the
> > > kernel log
> > > by default.
> > >
> > > While we are at it, let's make clear that this is a wheel multiplier
> > > (and
> > > not, for example, XY movement multiplier).
> > >
> > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
> > > on Logitech mice")
> > > Cc: [email protected]
> > > Signed-off-by: Maciej S. Szmigiero <[email protected]>
> > > ---
> > > Sending again since the previous message bounced for most recipients.
> > >
> > > drivers/hid/hid-logitech-hidpp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> > > logitech-hidpp.c
> > > index 1e1cf8eae649..b8b53dc95e86 100644
> > > --- a/drivers/hid/hid-logitech-hidpp.c
> > > +++ b/drivers/hid/hid-logitech-hidpp.c
> > > @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
> > > hidpp_device *hidpp)
> > > multiplier = 1;
> > >
> > > hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> > > - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> > > + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
> > > return 0;
> > > }
> > >
> >
> > I have seen this being useful in some cases, however I do not have a
> > strong opinion on it. Peter would know better.
>
> Well, the message is not being removed, only hidden by default, so
> it doesn't fill the kernel log.
>
> One can still enable it at runtime if wanted.
Of course, but instructing users to do that can be annoying, especially
when you're handling a considerable volume of reports.
Anyway, I am fine with this patch, I just thought it was pertinent to
raise this point and maybe get Peter's input on this, as he will likely
be one most affected by it :)
Filipe Laíns
On Sun, 5 Jul 2020 at 10:09, Maciej S. Szmigiero
<[email protected]> wrote:
>
> These messages appear each time the mouse wakes from sleep, in my case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the kernel log
> by default.
>
> While we are at it, let's make clear that this is a wheel multiplier (and
> not, for example, XY movement multiplier).
Looks good to me, thanks!
Reviewed-by: Harry Cutts <[email protected]>
Harry Cutts
Chrome OS Touch/Input team
>
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Cc: [email protected]
> Signed-off-by: Maciej S. Szmigiero <[email protected]>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 1e1cf8eae649..b8b53dc95e86 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp)
> multiplier = 1;
>
> hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
> return 0;
> }
>
On Sun, 5 Jul 2020, Maciej S. Szmigiero wrote:
> These messages appear each time the mouse wakes from sleep, in my case
> (Logitech M705), every minute or so.
> Let's downgrade them to the "debug" level so they don't fill the kernel log
> by default.
>
> While we are at it, let's make clear that this is a wheel multiplier (and
> not, for example, XY movement multiplier).
>
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Cc: [email protected]
> Signed-off-by: Maciej S. Szmigiero <[email protected]>
Applied, thank you Maciej.
--
Jiri Kosina
SUSE Labs