2022-06-30 09:15:04

by Yang Li

Subject: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by: Yang Li <[email protected]>
---
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
index b5f6d41464db..5b0f66573d94 100644
--- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
+++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
break;
default:
return false;
- };
+ }

do {
pwrcfgcmd = pwrseqcmd[aryidx];
--
2.20.1.7.g153144c

2022-06-30 12:07:08

by Martin Kaiser

Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Thus wrote Yang Li ([email protected]):

> Eliminate the following coccicheck warning:
> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> index b5f6d41464db..5b0f66573d94 100644
> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> break;
> default:
> return false;
> - };
> + }

> do {
> pwrcfgcmd = pwrseqcmd[aryidx];
> --
> 2.20.1.7.g153144c

Thanks for spotting this.

Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
Reviewed-by: Martin Kaiser <[email protected]>

2022-07-01 20:06:18

by Pavel Skripkin

Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Hi Martin,

Martin Kaiser <[email protected]> says:
> Thus wrote Yang Li ([email protected]):
>
>> Eliminate the following coccicheck warning:
>> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
>
>> Signed-off-by: Yang Li <[email protected]>
>> ---
>> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> index b5f6d41464db..5b0f66573d94 100644
>> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>> break;
>> default:
>> return false;
>> - };
>> + }
>
>> do {
>> pwrcfgcmd = pwrseqcmd[aryidx];
>> --
>> 2.20.1.7.g153144c
>
> Thanks for spotting this.
>
> Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")

^^^^^^^^^^^^^^^^^^^^^^^^^^

No need to backport code-style warning, so Fixes: is not needed here.




Thanks,
--Pavel Skripkin

2022-07-04 12:19:35

by Dan Carpenter

Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

On Fri, Jul 01, 2022 at 10:58:58PM +0300, Pavel Skripkin wrote:
> Hi Martin,
>
> Martin Kaiser <[email protected]> says:
> > Thus wrote Yang Li ([email protected]):
> >
> > > Eliminate the following coccicheck warning:
> > > ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> >
> > > Signed-off-by: Yang Li <[email protected]>
> > > ---
> > > drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > > diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > index b5f6d41464db..5b0f66573d94 100644
> > > --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> > > break;
> > > default:
> > > return false;
> > > - };
> > > + }
> >
> > > do {
> > > pwrcfgcmd = pwrseqcmd[aryidx];
> > > --
> > > 2.20.1.7.g153144c
> >
> > Thanks for spotting this.
> >
> > Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> No need to backport code-style warning, so Fixes: is not needed here.
>

The Fixes tag doesn't have to do with backporting...

I do think it should only be used for bugs. So I would not have used it
here. But other people do encourage it for style issues so I have given
up fighting about that.

regards,
dan carpenter