From: Kory Maincent <[email protected]>
Enable the PL110 DRM driver, used by the spear600.
CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
Signed-off-by: Kory Maincent <[email protected]>
---
arch/arm/configs/spear6xx_defconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/spear6xx_defconfig b/arch/arm/configs/spear6xx_defconfig
index 1cf0621d2154..231cbd2ac536 100644
--- a/arch/arm/configs/spear6xx_defconfig
+++ b/arch/arm/configs/spear6xx_defconfig
@@ -32,7 +32,6 @@ CONFIG_STMMAC_ETH=y
# CONFIG_LEGACY_PTYS is not set
CONFIG_SERIAL_AMBA_PL011=y
CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
-CONFIG_I2C=y
CONFIG_I2C_DESIGNWARE_PLATFORM=y
CONFIG_SPI=y
CONFIG_SPI_PL022=y
@@ -40,6 +39,8 @@ CONFIG_GPIO_PL061=y
# CONFIG_HWMON is not set
CONFIG_WATCHDOG=y
CONFIG_ARM_SP805_WATCHDOG=y
+CONFIG_DRM=y
+CONFIG_DRM_PL111=y
CONFIG_USB=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_OHCI_HCD=y
--
2.25.1
On Wed, Oct 19, 2022, at 15:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <[email protected]> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>> > From: Kory Maincent <[email protected]>
>> >
>> > Enable the PL110 DRM driver, used by the spear600.
>> >
>> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?
It's something that DRM probably should not select, so if this
ever gets fixed in DRM, you get a broken build. Just leaving
the line in there is harmless.
Arnd
On 19/10/2022 09:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <[email protected]> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>>> From: Kory Maincent <[email protected]>
>>>
>>> Enable the PL110 DRM driver, used by the spear600.
>>>
>>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?
Same question every few months :)
Because otherwise we can drop select in DRM and do not update the
defconfigs.
https://patchwork.kernel.org/project/linux-samsung-soc/patch/[email protected]/#23021125
https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/
https://lore.kernel.org/all/[email protected]/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2315d3aea5976acd919d3d3fcf82f752562c25b
Best regards,
Krzysztof
Hello Krzysztof,
On Wed, 19 Oct 2022 09:38:45 -0400
Krzysztof Kozlowski <[email protected]> wrote:
> On 19/10/2022 09:32, Köry Maincent wrote:
> > From: Kory Maincent <[email protected]>
> >
> > Enable the PL110 DRM driver, used by the spear600.
> >
> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
>
> I2C as a user-selectable option should stay. Don't remove such
> (user-selectable) top-level options just because something else selected it.
As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
Why keeping something that is already automatically enabled by CONFIG_DRM?
Krzysztof
On Wed, 19 Oct 2022 09:57:26 -0400
Krzysztof Kozlowski <[email protected]> wrote:
> On 19/10/2022 09:48, Köry Maincent wrote:
> > Hello Krzysztof,
> >
> > On Wed, 19 Oct 2022 09:38:45 -0400
> > Krzysztof Kozlowski <[email protected]> wrote:
> >
> >> On 19/10/2022 09:32, Köry Maincent wrote:
> >>> From: Kory Maincent <[email protected]>
> >>>
> >>> Enable the PL110 DRM driver, used by the spear600.
> >>>
> >>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
> >>>
> >>
> >> I2C as a user-selectable option should stay. Don't remove such
> >> (user-selectable) top-level options just because something else selected
> >> it.
> >
> > As the CONFIG_DRM selects it, the "make savedefconfig" removes it by
> > default. Why keeping something that is already automatically enabled by
> > CONFIG_DRM?
>
> Same question every few months :)
>
> Because otherwise we can drop select in DRM and do not update the
> defconfigs.
Alright, thanks, I will update it in V2.
I will be more careful with savedefconfig for now !
Köry
On 19/10/2022 09:32, Köry Maincent wrote:
> From: Kory Maincent <[email protected]>
>
> Enable the PL110 DRM driver, used by the spear600.
>
> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
I2C as a user-selectable option should stay. Don't remove such
(user-selectable) top-level options just because something else selected it.
Best regards,
Krzysztof