On Mon, Sep 18, 2023 at 10:01:13AM -0400, Luiz Capitulino wrote:
>
>
> On 2023-09-05 20:57, Luiz Capitulino wrote:
> > We have a need of using favordynmods with cgroup v1, which doesn't support
> > changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at
> > build-time is not an option because we want to be able to selectively
> > enable it for certain systems.
> >
> > This commit addresses this by introducing the cgroup_favordynmods=
> > command-line option. This option works for both cgroup v1 and v2 and
> > also allows for disabling favorynmods when the kernel built with
> > CONFIG_FAVOR_DYNMODS=y.
> >
> > Signed-off-by: Luiz Capitulino <[email protected]>
>
> Ping?
Michal raised some valid concerns. I don't really mind that it's not great
on the edges tho. Michal, what do you think?
Thanks.
--
tejun
On Mon, Sep 18, 2023 at 07:47:13AM -1000, Tejun Heo <[email protected]> wrote:
> Michal raised some valid concerns. I don't really mind that it's not great
> on the edges tho. Michal, what do you think?
I'd have a few suggestions:
- reset to have_dynmods value instead of false in cgroup_destroy_root()
(to the benefing of the users of this option, not the common default
users) or not touch the value in cgroup_destroy_root() at all
- s/CONFIG_FAVOR_DYNMODS/CONFIG_CGROUP_FAVOR_DYNMODS/ in commit message
Those should be minor tweaks,
Michal