2017-08-08 12:46:21

by Anton Volkov

[permalink] [raw]
Subject: Question about bh1770glc.ko

Hello.

In drivers/misc/bh1770glc.c several functions have comments stating that
they must be called under lock protection, e.g.
bh1770_prox_mode_control, bh1770_lux_interrupt_control, bh1770_lux_rate,
bh1770_chip_on. However there are places where they are called without
lock being held, e.g. during the bh1770_resume. Do you know anything
about whether this is intended or this is a bug?

Thank you for your time.

-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: [email protected]


2017-08-08 14:57:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: Question about bh1770glc.ko

On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote:
> Hello.
>
> In drivers/misc/bh1770glc.c several functions have comments stating that
> they must be called under lock protection, e.g. bh1770_prox_mode_control,
> bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However there
> are places where they are called without lock being held, e.g. during the
> bh1770_resume. Do you know anything about whether this is intended or this
> is a bug?
>
> Thank you for your time.

I have no idea, sorry.