2021-02-05 03:45:12

by Palmer Dabbelt

Subject: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

From: Palmer Dabbelt <[email protected]>

VSC8541 phys need a special reset sequence, which the driver doesn't
currentlny support. As a result enabling the reset via GPIO essentially
guarnteees that the device won't work correctly.

This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.

Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
Cc: [email protected]
Signed-off-by: Palmer Dabbelt <[email protected]>
---
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 24d75a146e02..60846e88ae4b 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -90,7 +90,6 @@ &eth0 {
phy0: ethernet-phy@0 {
compatible = "ethernet-phy-id0007.0771";
reg = <0>;
- reset-gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
};
};

--
2.30.0.478.g8a0d178c01-goog

2021-02-10 12:52:52

by Andreas Schwab

Subject: Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <[email protected]>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support. As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: [email protected]
> Signed-off-by: Palmer Dabbelt <[email protected]>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.

--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."

2021-02-13 00:46:35

by Palmer Dabbelt

Subject: Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

On Wed, 10 Feb 2021 04:47:34 PST (-0800), [email protected] wrote:
> On Feb 04 2021, Palmer Dabbelt wrote:
>
>> From: Palmer Dabbelt <[email protected]>
>>
>> VSC8541 phys need a special reset sequence, which the driver doesn't
>> currentlny support. As a result enabling the reset via GPIO essentially
>> guarnteees that the device won't work correctly.
>>
>> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>>
>> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
>> Cc: [email protected]
>> Signed-off-by: Palmer Dabbelt <[email protected]>
>
> This fixes ethernet on the HiFive Unleashed with 5.10.12.

Thanks for testing. Looks like I forgot to reply, but it's in Linus' tree and
should end up in stable.