The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/hwtracing/intel_th/acpi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hwtracing/intel_th/acpi.c b/drivers/hwtracing/intel_th/acpi.c
index 87f9024e4bbb..503620e9fd10 100644
--- a/drivers/hwtracing/intel_th/acpi.c
+++ b/drivers/hwtracing/intel_th/acpi.c
@@ -60,18 +60,16 @@ static int intel_th_acpi_probe(struct platform_device *pdev)
return 0;
}
-static int intel_th_acpi_remove(struct platform_device *pdev)
+static void intel_th_acpi_remove(struct platform_device *pdev)
{
struct intel_th *th = platform_get_drvdata(pdev);
intel_th_free(th);
-
- return 0;
}
static struct platform_driver intel_th_acpi_driver = {
.probe = intel_th_acpi_probe,
- .remove = intel_th_acpi_remove,
+ .remove_new = intel_th_acpi_remove,
.driver = {
.name = DRIVER_NAME,
.acpi_match_table = intel_th_acpi_ids,
--
2.42.0
Hello,
On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K?nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
I didn't get any feedback to this patch and it didn't make it into next
up to now.
Is this still on someone's radar?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Alexander,
On Wed, Jan 10, 2024 at 09:41:54AM +0100, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K?nig wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
>
> I didn't get any feedback to this patch and it didn't make it into next
> up to now.
>
> Is this still on someone's radar?
Is there a chance to get this patch into v6.9-rc1? Are you the right one
to talk to about this patch? (According to MAINTAINERS you are.)
The patch was sent during the 6.7 merge window and now already missed
the 6.8 one :-\
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Greg,
On Thu, Feb 15, 2024 at 10:16:41PM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Jan 10, 2024 at 09:41:54AM +0100, Uwe Kleine-K?nig wrote:
> > On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K?nig wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is ignored (apart
> > > from emitting a warning) and this typically results in resource leaks.
> > >
> > > To improve here there is a quest to make the remove callback return
> > > void. In the first step of this quest all drivers are converted to
> > > .remove_new(), which already returns void. Eventually after all drivers
> > > are converted, .remove_new() will be renamed to .remove().
> > >
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >
> > > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> >
> > I didn't get any feedback to this patch and it didn't make it into next
> > up to now.
> >
> > Is this still on someone's radar?
>
> Is there a chance to get this patch into v6.9-rc1? Are you the right one
> to talk to about this patch? (According to MAINTAINERS you are.)
>
> The patch was sent during the 6.7 merge window and now already missed
> the 6.8 one :-\
I failed in several attempts to get feedback on this patch. You applied
the last two patches for this driver (that is all patches since the
driver was born). Would you care for that one, too? Tell me if you want
a resend. Note that the other 7 patches from this series are already
cared for, so if you're using b4 am or shazam, make use of -P7.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Uwe Kleine-König <[email protected]> writes:
> Hello Greg,
>
> On Thu, Feb 15, 2024 at 10:16:41PM +0100, Uwe Kleine-König wrote:
>> On Wed, Jan 10, 2024 at 09:41:54AM +0100, Uwe Kleine-König wrote:
>> > On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-König wrote:
>> > > The .remove() callback for a platform driver returns an int which makes
>> > > many driver authors wrongly assume it's possible to do error handling by
>> > > returning an error code. However the value returned is ignored (apart
>> > > from emitting a warning) and this typically results in resource leaks.
>> > >
>> > > To improve here there is a quest to make the remove callback return
>> > > void. In the first step of this quest all drivers are converted to
>> > > .remove_new(), which already returns void. Eventually after all drivers
>> > > are converted, .remove_new() will be renamed to .remove().
>> > >
>> > > Trivially convert this driver from always returning zero in the remove
>> > > callback to the void returning variant.
>> > >
>> > > Signed-off-by: Uwe Kleine-König <[email protected]>
>> >
>> > I didn't get any feedback to this patch and it didn't make it into next
>> > up to now.
>> >
>> > Is this still on someone's radar?
>>
>> Is there a chance to get this patch into v6.9-rc1? Are you the right one
>> to talk to about this patch? (According to MAINTAINERS you are.)
>>
>> The patch was sent during the 6.7 merge window and now already missed
>> the 6.8 one :-\
>
> I failed in several attempts to get feedback on this patch. You applied
> the last two patches for this driver (that is all patches since the
> driver was born). Would you care for that one, too? Tell me if you want
> a resend. Note that the other 7 patches from this series are already
> cared for, so if you're using b4 am or shazam, make use of -P7.
Apologies. This looks good to me, I will pick it up for my next
submission to Greg unless somebody objects.
Regards,
--
Alex
Hello Alex,
On Wed, Feb 21, 2024 at 08:50:32PM +0200, Alexander Shishkin wrote:
> Uwe Kleine-K?nig <[email protected]> writes:
> > On Thu, Feb 15, 2024 at 10:16:41PM +0100, Uwe Kleine-K?nig wrote:
> >> On Wed, Jan 10, 2024 at 09:41:54AM +0100, Uwe Kleine-K?nig wrote:
> >> > On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K?nig wrote:
> >> > > The .remove() callback for a platform driver returns an int which makes
> >> > > many driver authors wrongly assume it's possible to do error handling by
> >> > > returning an error code. However the value returned is ignored (apart
> >> > > from emitting a warning) and this typically results in resource leaks.
> >> > >
> >> > > To improve here there is a quest to make the remove callback return
> >> > > void. In the first step of this quest all drivers are converted to
> >> > > .remove_new(), which already returns void. Eventually after all drivers
> >> > > are converted, .remove_new() will be renamed to .remove().
> >> > >
> >> > > Trivially convert this driver from always returning zero in the remove
> >> > > callback to the void returning variant.
> >> > >
> >> > > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> >> >
> >> > I didn't get any feedback to this patch and it didn't make it into next
> >> > up to now.
> >> >
> >> > Is this still on someone's radar?
> >>
> >> Is there a chance to get this patch into v6.9-rc1? Are you the right one
> >> to talk to about this patch? (According to MAINTAINERS you are.)
> >>
> >> The patch was sent during the 6.7 merge window and now already missed
> >> the 6.8 one :-\
> >
> > I failed in several attempts to get feedback on this patch. You applied
> > the last two patches for this driver (that is all patches since the
> > driver was born). Would you care for that one, too? Tell me if you want
> > a resend. Note that the other 7 patches from this series are already
> > cared for, so if you're using b4 am or shazam, make use of -P7.
>
> Apologies. This looks good to me, I will pick it up for my next
> submission to Greg unless somebody objects.
Given there are not that many patches left (~50) as of today's next, I'd
like to see this patch going in during the next merge window, that I can
finalize the (next step of the) quest around platform_driver::remove.
Is sending this patch to Greg still on your todo list?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Uwe Kleine-König <[email protected]> writes:
> Hello Alex,
Hi Uwe,
> Given there are not that many patches left (~50) as of today's next, I'd
> like to see this patch going in during the next merge window, that I can
> finalize the (next step of the) quest around platform_driver::remove.
>
> Is sending this patch to Greg still on your todo list?
Yes, as soon as I finalize other patches on my series. Should be soon.
Regards,
--
Alex