2020-02-21 13:23:50

by Joe Perches

Subject: [trivial PATCH] cifs: Use #define in cifs_dbg

All other uses of cifs_dbg use defines so change this one.

Signed-off-by: Joe Perches <[email protected]>
---
fs/cifs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index b5e663..cd95e0 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -653,8 +653,8 @@ cifs_all_info_to_fattr(struct cifs_fattr *fattr, FILE_ALL_INFO *info,
*/
if ((fattr->cf_nlink < 1) && !tcon->unix_ext &&
!info->DeletePending) {
- cifs_dbg(1, "bogus file nlink value %u\n",
- fattr->cf_nlink);
+ cifs_dbg(VFS, "bogus file nlink value %u\n",
+ fattr->cf_nlink);
fattr->cf_flags |= CIFS_FATTR_UNKNOWN_NLINK;
}
}

2020-02-21 13:44:59

by Aurélien Aptel

Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg

Joe Perches <[email protected]> writes:
> + cifs_dbg(VFS, "bogus file nlink value %u\n",
> + fattr->cf_nlink);

Good catch :)
I realize that 1 is VFS but this should probably be FYI.

Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

2020-02-21 13:58:47

by Joe Perches

Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg

On Fri, 2020-02-21 at 14:44 +0100, Aur?lien Aptel wrote:
> Joe Perches <[email protected]> writes:
> > + cifs_dbg(VFS, "bogus file nlink value %u\n",
> > + fattr->cf_nlink);
>
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.

change it as you please.

fyi:

Perhaps commit f2f176b41 ("CIFS: add ONCE flag for cifs_dbg type")
may have increased object size quite a bit as it now tests
an external variable.

2020-02-24 05:58:48

by Steve French

Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg

Seems like a plausible debug (VFS not FYI) msg. If delete is not
pending, it is a little strange if nlink is 0. merged into
cifs-2.6.git for-next


On Fri, Feb 21, 2020 at 7:46 AM Aurélien Aptel <[email protected]> wrote:
>
> Joe Perches <[email protected]> writes:
> > + cifs_dbg(VFS, "bogus file nlink value %u\n",
> > + fattr->cf_nlink);
>
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)



--
Thanks,

Steve