2021-04-27 16:08:18

by Michael Walle

[permalink] [raw]
Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2

Am 2021-04-27 17:29, schrieb Michael Walle:

> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts. The codec name is
This should read "CPU name" of course.

-michael


2021-05-09 23:18:16

by Kuninori Morimoto

[permalink] [raw]
Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2


Hi

I'm sorry for my late response. Japan was holiday

> _But_ later
> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to
> NULL in simple_parse_node() if "single" is 1 and then we end up
> having two links with the same name.

Ahh, OK thanks.
I think understand that why my posted patch
(= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()")
breaks your board.

I will try to fixup the issue.

Thank you for your help !!

Best regards
---
Kuninori Morimoto

2021-05-10 12:52:25

by Michael Walle

[permalink] [raw]
Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2

Hi,

Am 2021-05-10 01:16, schrieb Kuninori Morimoto:
> I'm sorry for my late response. Japan was holiday
>
>> _But_ later
>> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to
>> NULL in simple_parse_node() if "single" is 1 and then we end up
>> having two links with the same name.
>
> Ahh, OK thanks.
> I think understand that why my posted patch
> (= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()")
> breaks your board.
>
> I will try to fixup the issue.
>
> Thank you for your help !!

I've just tested your new patches. Unfortunately, it was very
successful. I've also traced the is_single_links and it is still
1 for this board. Is this correct?

Still these two questions are open:
>> Which begs the two questions:
>> (1) What is "single" actually and when should it be 1?
>> (2) If single is 1, then the sysfs file will be named
>> "(null)-codec-name".
>> Do we want that?

-michael

2021-05-10 22:19:14

by Kuninori Morimoto

[permalink] [raw]
Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2


Hi Michael

> I've just tested your new patches. Unfortunately, it was very
> successful. I've also traced the is_single_links and it is still
> 1 for this board. Is this correct?

Grr, thank you for your test.
is_single_links itself is no problem.
This is name creating timing issue, and indeed posted
patch was still not good.
I'm so sorry to bother you.

Thank you for your help !!

Best regards
---
Kuninori Morimoto