Remove the repeated word "the" in comments.
Signed-off-by: Charles Han <[email protected]>
---
Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
index 1625d1131093..a0678101a7d0 100644
--- a/Documentation/filesystems/xfs-online-fsck-design.rst
+++ b/Documentation/filesystems/xfs-online-fsck-design.rst
@@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
2. The second transaction contains a physical update to the free space btrees
of AG 3 to release the former BMBT block and a second physical update to the
free space btrees of AG 7 to release the unmapped file space.
- Observe that the the physical updates are resequenced in the correct order
+ Observe that the physical updates are resequenced in the correct order
when possible.
Attached to the transaction is a an extent free done (EFD) log item.
The EFD contains a pointer to the EFI logged in transaction #1 so that log
--
2.31.1
On Mon, Sep 18, 2023 at 02:14:58AM -0600, Jonathan Corbet wrote:
> Bagas Sanjaya <[email protected]> writes:
>
> > On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
> >> Remove the repeated word "the" in comments.
> >
> > Patch title looks OK but in this case, the patch description should also match.
> > Hint: there is no code comments in the doc below.
> >
> >>
> >> Signed-off-by: Charles Han <[email protected]>
> >> ---
> >> Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> >> index 1625d1131093..a0678101a7d0 100644
> >> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> >> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> >> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> >> 2. The second transaction contains a physical update to the free space btrees
> >> of AG 3 to release the former BMBT block and a second physical update to the
> >> free space btrees of AG 7 to release the unmapped file space.
> >> - Observe that the the physical updates are resequenced in the correct order
> >> + Observe that the physical updates are resequenced in the correct order
> >> when possible.
> >> Attached to the transaction is a an extent free done (EFD) log item.
> >> The EFD contains a pointer to the EFI logged in transaction #1 so that log
> >
> > Regardless, wait for one or few days before rerolling this patch with
> > reviews addressed. It allows other reviewers to catch up and review. You can
> > also Cc: me if you'd like.
>
> Bagas, this is a patch removing an extra "the". We do not need to make
> life this hard for such a simple fix.
>
> Charles, the patch is good enough, no need for a third version.
>
> (Next time, though, do wait before resubmitting a patch. When you do,
> put a description of what changed below the "---" line.)
Thanks for the reminder!
--
An old man doll... just what I always wanted! - Clara
On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
> Remove the repeated word "the" in comments.
Patch title looks OK but in this case, the patch description should also match.
Hint: there is no code comments in the doc below.
>
> Signed-off-by: Charles Han <[email protected]>
> ---
> Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> 2. The second transaction contains a physical update to the free space btrees
> of AG 3 to release the former BMBT block and a second physical update to the
> free space btrees of AG 7 to release the unmapped file space.
> - Observe that the the physical updates are resequenced in the correct order
> + Observe that the physical updates are resequenced in the correct order
> when possible.
> Attached to the transaction is a an extent free done (EFD) log item.
> The EFD contains a pointer to the EFI logged in transaction #1 so that log
Regardless, wait for one or few days before rerolling this patch with
reviews addressed. It allows other reviewers to catch up and review. You can
also Cc: me if you'd like.
See you in v3!
--
An old man doll... just what I always wanted! - Clara
Bagas Sanjaya <[email protected]> writes:
> On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
>> Remove the repeated word "the" in comments.
>
> Patch title looks OK but in this case, the patch description should also match.
> Hint: there is no code comments in the doc below.
>
>>
>> Signed-off-by: Charles Han <[email protected]>
>> ---
>> Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst
>> index 1625d1131093..a0678101a7d0 100644
>> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
>> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
>> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
>> 2. The second transaction contains a physical update to the free space btrees
>> of AG 3 to release the former BMBT block and a second physical update to the
>> free space btrees of AG 7 to release the unmapped file space.
>> - Observe that the the physical updates are resequenced in the correct order
>> + Observe that the physical updates are resequenced in the correct order
>> when possible.
>> Attached to the transaction is a an extent free done (EFD) log item.
>> The EFD contains a pointer to the EFI logged in transaction #1 so that log
>
> Regardless, wait for one or few days before rerolling this patch with
> reviews addressed. It allows other reviewers to catch up and review. You can
> also Cc: me if you'd like.
Bagas, this is a patch removing an extra "the". We do not need to make
life this hard for such a simple fix.
Charles, the patch is good enough, no need for a third version.
(Next time, though, do wait before resubmitting a patch. When you do,
put a description of what changed below the "---" line.)
Thanks,
jon