Hi,
Pengcheng Li <[email protected]> writes:
> The USBTRDTIM field needs to be cleared before setting a new value.
> Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
>
> Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> Signed-off-by: Pengcheng Li <[email protected]>
> Acked-by: John Youn <[email protected]>
which commit are you fixing? Seems like you're missing a:
Fixes: foobar ....
line here. Also, you need to remove Gerritisms from commit log ;-)
--
balbi
> -----Original Message-----
> From: Felipe Balbi [mailto:[email protected]]
> Sent: Monday, October 17, 2016 5:37 PM
> To: Lipengcheng; [email protected]
> Cc: [email protected]; [email protected]; [email protected]; Xuejiancheng; Lidongpo; Caizhiyong; Lipengcheng
> Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting
>
>
> Hi,
>
> Pengcheng Li <[email protected]> writes:
> > The USBTRDTIM field needs to be cleared before setting a new value.
> > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
> >
> > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> > Signed-off-by: Pengcheng Li <[email protected]>
> > Acked-by: John Youn <[email protected]>
>
> which commit are you fixing? Seems like you're missing a:
>
commit c45574ff02d1d1f35a6bf4b8ad051fc06c001fc7.
> Fixes: foobar ....
>
> line here. Also, you need to remove Gerritisms from commit log ;-)
>
Ok, I will remove at the next patch.
> --
> Balbi
Best Regards
Pengcheng Li