2020-05-09 11:25:55

by Ravi Bangoria

Subject: [PATCH] perf powerpc: Don't ignore sym-handling.c file

Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
removed powerpc specific sym-handling.c file from Build. This wasn't
caught by build CI because all functions in this file are declared
as __weak in common code. Fix it.

Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
Reported-by: Sandipan Das <[email protected]>
Signed-off-by: Ravi Bangoria <[email protected]>
---
tools/perf/arch/powerpc/util/Build | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
index e5c9504f8586..e86e210bf514 100644
--- a/tools/perf/arch/powerpc/util/Build
+++ b/tools/perf/arch/powerpc/util/Build
@@ -2,6 +2,7 @@ perf-y += header.o
perf-y += kvm-stat.o
perf-y += perf_regs.o
perf-y += mem-events.o
+perf-y += sym-handling.o

perf-$(CONFIG_DWARF) += dwarf-regs.o
perf-$(CONFIG_DWARF) += skip-callchain-idx.o
--
2.21.1

2020-05-11 18:19:20

by Sandipan Das

Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> removed powerpc specific sym-handling.c file from Build. This wasn't
> caught by build CI because all functions in this file are declared
> as __weak in common code. Fix it.
>
> Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> Reported-by: Sandipan Das <[email protected]>
> Signed-off-by: Ravi Bangoria <[email protected]>
> ---
> tools/perf/arch/powerpc/util/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> index e5c9504f8586..e86e210bf514 100644
> --- a/tools/perf/arch/powerpc/util/Build
> +++ b/tools/perf/arch/powerpc/util/Build
> @@ -2,6 +2,7 @@ perf-y += header.o
> perf-y += kvm-stat.o
> perf-y += perf_regs.o
> perf-y += mem-events.o
> +perf-y += sym-handling.o
>
> perf-$(CONFIG_DWARF) += dwarf-regs.o
> perf-$(CONFIG_DWARF) += skip-callchain-idx.o
>

Thanks for fixing this!

Acked-by: Sandipan Das <[email protected]>

2020-05-12 13:29:55

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
>
> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > removed powerpc specific sym-handling.c file from Build. This wasn't
> > caught by build CI because all functions in this file are declared
> > as __weak in common code. Fix it.
> >
> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > Reported-by: Sandipan Das <[email protected]>
> > Signed-off-by: Ravi Bangoria <[email protected]>
> > ---
> > tools/perf/arch/powerpc/util/Build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> > index e5c9504f8586..e86e210bf514 100644
> > --- a/tools/perf/arch/powerpc/util/Build
> > +++ b/tools/perf/arch/powerpc/util/Build
> > @@ -2,6 +2,7 @@ perf-y += header.o
> > perf-y += kvm-stat.o
> > perf-y += perf_regs.o
> > perf-y += mem-events.o
> > +perf-y += sym-handling.o
> >
> > perf-$(CONFIG_DWARF) += dwarf-regs.o
> > perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> >
>
> Thanks for fixing this!
>
> Acked-by: Sandipan Das <[email protected]>

Leo, Naveen, can you comment on this?

- Arnaldo

2020-05-12 14:01:34

by Leo Yan

Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

On Sat, May 09, 2020 at 04:51:13PM +0530, Ravi Bangoria wrote:
> Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> removed powerpc specific sym-handling.c file from Build. This wasn't
> caught by build CI because all functions in this file are declared
> as __weak in common code. Fix it.
>
> Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> Reported-by: Sandipan Das <[email protected]>
> Signed-off-by: Ravi Bangoria <[email protected]>
> ---
> tools/perf/arch/powerpc/util/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> index e5c9504f8586..e86e210bf514 100644
> --- a/tools/perf/arch/powerpc/util/Build
> +++ b/tools/perf/arch/powerpc/util/Build
> @@ -2,6 +2,7 @@ perf-y += header.o
> perf-y += kvm-stat.o
> perf-y += perf_regs.o
> perf-y += mem-events.o
> +perf-y += sym-handling.o

My bad, thanks for fixing. FWIW:

Reviewed-by: Leo Yan <[email protected]>

> perf-$(CONFIG_DWARF) += dwarf-regs.o
> perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> --
> 2.21.1
>

2020-05-13 20:46:50

by Naveen N. Rao

Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

Arnaldo Carvalho de Melo wrote:
> Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
>>
>> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
>> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > removed powerpc specific sym-handling.c file from Build. This wasn't
>> > caught by build CI because all functions in this file are declared
>> > as __weak in common code. Fix it.
>> >
>> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > Reported-by: Sandipan Das <[email protected]>
>> > Signed-off-by: Ravi Bangoria <[email protected]>
>> > ---
>> > tools/perf/arch/powerpc/util/Build | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
>> > index e5c9504f8586..e86e210bf514 100644
>> > --- a/tools/perf/arch/powerpc/util/Build
>> > +++ b/tools/perf/arch/powerpc/util/Build
>> > @@ -2,6 +2,7 @@ perf-y += header.o
>> > perf-y += kvm-stat.o
>> > perf-y += perf_regs.o
>> > perf-y += mem-events.o
>> > +perf-y += sym-handling.o
>> >
>> > perf-$(CONFIG_DWARF) += dwarf-regs.o
>> > perf-$(CONFIG_DWARF) += skip-callchain-idx.o
>> >
>>
>> Thanks for fixing this!
>>
>> Acked-by: Sandipan Das <[email protected]>
>
> Leo, Naveen, can you comment on this?

Shoot -- this is a bad miss, I should have caught it. FWIW:
Reviewed-by: Naveen N. Rao <[email protected]>

Thanks,
Naveen