2020-04-20 22:02:41

by Colin King

Subject: [PATCH] f2fs: remove redundant assignment to variable err

From: Colin Ian King <[email protected]>

The variable err is being assigned with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/f2fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index f54119da2217..e4585c3d1a7c 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -564,7 +564,7 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
struct inode *inode = d_inode(dentry);
struct f2fs_dir_entry *de;
struct page *page;
- int err = -ENOENT;
+ int err;

trace_f2fs_unlink_enter(dir, dentry);

--
2.25.1

2020-04-21 11:37:25

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant assignment to variable err

On 2020/4/21 6:00, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being assigned with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,