2021-09-19 04:12:26

by Michael Straube

Subject: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

Hi Larry, Phillip and all.

While removing code that checks for the chip type I stumbled upon this:


void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
{
if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
return;

if (pDM_Odm->SupportICType == ODM_RTL8188E) {
/* ??? */
/* This part need to be redefined. */
}
}


(pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
Currently the function does nothing and the driver seems to work fine.
Because of the comment I'm not sure if the whole function can just be
removed?

Regards,
Michael

2021-09-19 06:48:47

by Larry Finger

Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

On 9/18/21 08:31, Michael Straube wrote:
> Hi Larry, Phillip and all.
>
> While removing code that checks for the chip type I stumbled upon this:
>
>
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
>     if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
>         return;
>
>     if (pDM_Odm->SupportICType == ODM_RTL8188E) {
>         /*  ??? */
>         /*  This part need to be redefined. */
>     }
> }
>
>
> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
> Currently the function does nothing and the driver seems to work fine.
> Because of the comment I'm not sure if the whole function can just be
> removed?

Yes, I agree. No later driver does anything with this routine, thus it is dead
and can be removed.

Larry

2021-09-19 06:52:14

by Michael Straube

Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

On 9/18/21 18:46, Larry Finger wrote:
> On 9/18/21 08:31, Michael Straube wrote:
>> Hi Larry, Phillip and all.
>>
>> While removing code that checks for the chip type I stumbled upon this:
>>
>>
>> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
>> {
>>      if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
>>          return;
>>
>>      if (pDM_Odm->SupportICType == ODM_RTL8188E) {
>>          /*  ??? */
>>          /*  This part need to be redefined. */
>>      }
>> }
>>
>>
>> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
>> Currently the function does nothing and the driver seems to work fine.
>> Because of the comment I'm not sure if the whole function can just be
>> removed?
>
> Yes, I agree. No later driver does anything with this routine, thus it
> is dead and can be removed.
>
> Larry
>

Ok, thank you.

Regards,
Michael

2021-09-20 09:55:55

by Dan Carpenter

Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

On Sat, Sep 18, 2021 at 03:31:48PM +0200, Michael Straube wrote:
> Hi Larry, Phillip and all.
>
> While removing code that checks for the chip type I stumbled upon this:
>
>
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
> if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
> return;
>
> if (pDM_Odm->SupportICType == ODM_RTL8188E) {
> /* ??? */
> /* This part need to be redefined. */
> }
> }

Always just delete dead code. The future is very hard to predict so
don't leave things lying around because of possible futures. Don't be
a hoarder.

regards,
dan carpenter