A "\n" at the end of bellow ACPI_INFO message is causing a blank line
in the kernel log:
ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
This patch removes the "\n".
Kernel log before this patch:
ACPI: Core revision 20160108
ACPI: 2 ACPI AML tables successfully acquired and loaded
Security Framework initialized
Kernel log after this patch:
ACPI: Core revision 20160108
ACPI: 2 ACPI AML tables successfully acquired and loaded
Security Framework initialized
Signed-off-by: Daniel Bristot de Oliveira <[email protected]>
diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index 3151968..e435b84 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -240,7 +240,8 @@ acpi_status acpi_tb_load_namespace(void)
}
if (!tables_failed) {
- ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
+ ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded",
+ tables_loaded));
} else {
ACPI_ERROR((AE_INFO,
"%u table load failures, %u successful",
--
2.5.0
Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?
> -----Original Message-----
> From: Daniel Bristot de Oliveira [mailto:[email protected]]
> Sent: Monday, March 28, 2016 10:59 AM
> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot
> message
>
> A "\n" at the end of bellow ACPI_INFO message is causing a blank line in
> the kernel log:
>
> ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n",
> tables_loaded));
>
> This patch removes the "\n".
>
> Kernel log before this patch:
> ACPI: Core revision 20160108
> ACPI: 2 ACPI AML tables successfully acquired and loaded
>
> Security Framework initialized
>
> Kernel log after this patch:
> ACPI: Core revision 20160108
> ACPI: 2 ACPI AML tables successfully acquired and loaded
> Security Framework initialized
>
> Signed-off-by: Daniel Bristot de Oliveira <[email protected]>
>
> diff --git a/drivers/acpi/acpica/tbxfload.c
> b/drivers/acpi/acpica/tbxfload.c index 3151968..e435b84 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,8 @@ acpi_status acpi_tb_load_namespace(void)
> }
>
> if (!tables_failed) {
> - ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> + ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded",
> + tables_loaded));
> } else {
> ACPI_ERROR((AE_INFO,
> "%u table load failures, %u successful",
> --
> 2.5.0
On 03/29/2016 04:09 PM, Moore, Robert wrote:
> Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?
Well, I do not believe that there is a real problem on it.
On the other hand, it does not seem to be common to have blank lines in
the kernel log, and as there is no info about from where the black line
comes from, it does not even seems to be connected to the previous
message. So although my patch is about "cosmetics", IMHO it is worth as
pattern or best practices. Feel free to reject if it is not the case, np
:-).
-- Daniel
On Wed, 2016-03-30 at 22:11 -0300, Daniel Bristot de Oliveira wrote:
> On 03/29/2016 04:09 PM, Moore, Robert wrote:
> > Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?
> Well, I do not believe that there is a real problem on it.
>
> On the other hand, it does not seem to be common to have blank lines in
> the kernel log, and as there is no info about from where the black line
> comes from, it does not even seems to be connected to the previous
> message. So although my patch is about "cosmetics", IMHO it is worth as
> pattern or best practices.
FWIW: I agree with Daniel.