2015-08-03 06:17:07

by Shreyas B. Prabhu

Subject: [PATCH] cpupower tools: Fix error when running cpupower monitor

get_cpu_topology() tries to get topology info from all cpus by reading
files in the topology sysfs dir. If a cpu is offlined, since it doesn't
have topology dir, this function fails and returns -1. This causes
functions relying on get_cpu_topology() to fail. For example-

$ cpupower monitor
Cannot read number of available processors

Fix this by skipping fetching topology info for offline cpus.

Signed-off-by: Shreyas B. Prabhu <[email protected]>
Reported-by: Pavaman Subramaniyam <[email protected]>
---
tools/power/cpupower/utils/helpers/topology.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/power/cpupower/utils/helpers/topology.c b/tools/power/cpupower/utils/helpers/topology.c
index c13120af519b..cea398c176e7 100644
--- a/tools/power/cpupower/utils/helpers/topology.c
+++ b/tools/power/cpupower/utils/helpers/topology.c
@@ -73,6 +73,8 @@ int get_cpu_topology(struct cpupower_topology *cpu_top)
for (cpu = 0; cpu < cpus; cpu++) {
cpu_top->core_info[cpu].cpu = cpu;
cpu_top->core_info[cpu].is_online = sysfs_is_cpu_online(cpu);
+ if (!cpu_top->core_info[cpu].is_online)
+ continue;
if(sysfs_topology_read_file(
cpu,
"physical_package_id",
--
1.9.3

2015-08-10 12:29:05

by Thomas Renninger

Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor

On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
> get_cpu_topology() tries to get topology info from all cpus by reading
> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
> have topology dir, this function fails and returns -1. This causes
> functions relying on get_cpu_topology() to fail. For example-
>
> $ cpupower monitor
> Cannot read number of available processors
>
> Fix this by skipping fetching topology info for offline cpus.

Looks fine.

Thanks!

Acked-by: Thomas Renninger <[email protected]>


>
> Signed-off-by: Shreyas B. Prabhu <[email protected]>
> Reported-by: Pavaman Subramaniyam <[email protected]>
> ---
> tools/power/cpupower/utils/helpers/topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/power/cpupower/utils/helpers/topology.c
> b/tools/power/cpupower/utils/helpers/topology.c index
> c13120af519b..cea398c176e7 100644
> --- a/tools/power/cpupower/utils/helpers/topology.c
> +++ b/tools/power/cpupower/utils/helpers/topology.c
> @@ -73,6 +73,8 @@ int get_cpu_topology(struct cpupower_topology *cpu_top)
> for (cpu = 0; cpu < cpus; cpu++) {
> cpu_top->core_info[cpu].cpu = cpu;
> cpu_top->core_info[cpu].is_online = sysfs_is_cpu_online(cpu);
> + if (!cpu_top->core_info[cpu].is_online)
> + continue;
> if(sysfs_topology_read_file(
> cpu,
> "physical_package_id",

2015-08-17 07:53:23

by Shreyas B. Prabhu

Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor

On 08/10/2015 05:58 PM, Thomas Renninger wrote:
> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
>> get_cpu_topology() tries to get topology info from all cpus by reading
>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
>> have topology dir, this function fails and returns -1. This causes
>> functions relying on get_cpu_topology() to fail. For example-
>>
>> $ cpupower monitor
>> Cannot read number of available processors
>>
>> Fix this by skipping fetching topology info for offline cpus.
>
> Looks fine.
>
> Thanks!
>
> Acked-by: Thomas Renninger <[email protected]>
>

Thanks Thomas!
Rafael, can you please pick this patch?


Thanks,
Shreyas

2015-08-25 12:02:02

by Shreyas B. Prabhu

Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor

On 08/17/2015 01:22 PM, Shreyas B Prabhu wrote:
>
>
> On 08/10/2015 05:58 PM, Thomas Renninger wrote:
>> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
>>> get_cpu_topology() tries to get topology info from all cpus by reading
>>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
>>> have topology dir, this function fails and returns -1. This causes
>>> functions relying on get_cpu_topology() to fail. For example-
>>>
>>> $ cpupower monitor
>>> Cannot read number of available processors
>>>
>>> Fix this by skipping fetching topology info for offline cpus.
>>
>> Looks fine.
>>
>> Thanks!
>>
>> Acked-by: Thomas Renninger <[email protected]>
>>
>
> Thanks Thomas!
> Rafael, can you please pick this patch?
>
>


Hi Rafael,

If this patch looks good can you please pick this up?


Thanks,
Shreyas