2020-12-22 15:18:36

by Alex Elder

Subject: [PATCH net] net: ipa: fix interconnect enable bug

When the core clock rate and interconnect bandwidth specifications
were moved into configuration data, a copy/paste bug was introduced,
causing the memory interconnect bandwidth to be set three times
rather than enabling the three different interconnects.

Fix this bug.

Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
Signed-off-by: Alex Elder <[email protected]>
---
drivers/net/ipa/ipa_clock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index 9dcf16f399b7a..135c393437f12 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
return ret;

data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
- ret = icc_set_bw(clock->memory_path, data->average_rate,
+ ret = icc_set_bw(clock->imem_path, data->average_rate,
data->peak_rate);
if (ret)
goto err_memory_path_disable;

data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
- ret = icc_set_bw(clock->memory_path, data->average_rate,
+ ret = icc_set_bw(clock->config_path, data->average_rate,
data->peak_rate);
if (ret)
goto err_imem_path_disable;
--
2.20.1

2020-12-22 16:21:21

by Georgi Djakov

Subject: Re: [PATCH net] net: ipa: fix interconnect enable bug

On 12/22/20 17:16, Alex Elder wrote:
> When the core clock rate and interconnect bandwidth specifications
> were moved into configuration data, a copy/paste bug was introduced,
> causing the memory interconnect bandwidth to be set three times
> rather than enabling the three different interconnects.
>
> Fix this bug.
>
> Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
> Signed-off-by: Alex Elder <[email protected]>

Reviewed-by: Georgi Djakov <[email protected]>

> ---
> drivers/net/ipa/ipa_clock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index 9dcf16f399b7a..135c393437f12 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
> return ret;
>
> data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
> - ret = icc_set_bw(clock->memory_path, data->average_rate,
> + ret = icc_set_bw(clock->imem_path, data->average_rate,
> data->peak_rate);
> if (ret)
> goto err_memory_path_disable;
>
> data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
> - ret = icc_set_bw(clock->memory_path, data->average_rate,
> + ret = icc_set_bw(clock->config_path, data->average_rate,
> data->peak_rate);
> if (ret)
> goto err_imem_path_disable;
>

2020-12-23 19:38:42

by Jakub Kicinski

Subject: Re: [PATCH net] net: ipa: fix interconnect enable bug

On Tue, 22 Dec 2020 18:18:31 +0200 Georgi Djakov wrote:
> On 12/22/20 17:16, Alex Elder wrote:
> > When the core clock rate and interconnect bandwidth specifications
> > were moved into configuration data, a copy/paste bug was introduced,
> > causing the memory interconnect bandwidth to be set three times
> > rather than enabling the three different interconnects.
> >
> > Fix this bug.
> >
> > Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
> > Signed-off-by: Alex Elder <[email protected]>
>
> Reviewed-by: Georgi Djakov <[email protected]>

Applied, thanks!