attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Arvind Yadav (3):
[PATCH 1/3] PCI: pci-sysfs: constify attribute_group structures.
[PATCH 2/3] PCI: pci-label: constify attribute_group structures.
[PATCH 3/3] PCI: hotplug: constify attribute_group structures.
drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +-
drivers/pci/pci-label.c | 4 ++--
drivers/pci/pci-sysfs.c | 10 +++++-----
3 files changed, 8 insertions(+), 8 deletions(-)
--
1.9.1
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
File size After adding 'const':
text data bss dec hex filename
482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
index a796301..edb5d8a 100644
--- a/drivers/pci/hotplug/rpadlpar_sysfs.c
+++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
@@ -102,7 +102,7 @@ static ssize_t remove_slot_show(struct kobject *kobj,
NULL,
};
-static struct attribute_group dlpar_attr_group = {
+static const struct attribute_group dlpar_attr_group = {
.attrs = default_attrs,
};
--
1.9.1
On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
>
> Signed-off-by: Arvind Yadav <[email protected]>
Reviewed-by: Tyrel Datwyler <[email protected]>