2019-03-28 14:18:53

by Dan Carpenter

Subject: [PATCH] vlynq: Fix uninitialized error code in probe()

The "result" variable isn't initialized on this error path.

Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/vlynq/vlynq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index c0227f9418eb..44d3485d1108 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -727,7 +727,8 @@ static int vlynq_probe(struct platform_device *pdev)
dev->local_irq = dev->irq_end - dev->irq_start;
dev->remote_irq = dev->local_irq - 1;

- if (device_register(&dev->dev))
+ result = device_register(&dev->dev);
+ if (result)
goto fail_register;
platform_set_drvdata(pdev, dev);

--
2.17.1

2019-03-28 14:33:00

by Mukesh Ojha

Subject: Re: [PATCH] vlynq: Fix uninitialized error code in probe()

On 3/28/2019 7:47 PM, Dan Carpenter wrote:
> The "result" variable isn't initialized on this error path.
>
> Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus")
> Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh
> ---
> drivers/vlynq/vlynq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index c0227f9418eb..44d3485d1108 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -727,7 +727,8 @@ static int vlynq_probe(struct platform_device *pdev)
> dev->local_irq = dev->irq_end - dev->irq_start;
> dev->remote_irq = dev->local_irq - 1;
>
> - if (device_register(&dev->dev))
> + result = device_register(&dev->dev);
> + if (result)
> goto fail_register;
> platform_set_drvdata(pdev, dev);
>

2019-03-28 17:04:11

by Florian Fainelli

Subject: Re: [PATCH] vlynq: Fix uninitialized error code in probe()

On 3/28/19 7:17 AM, Dan Carpenter wrote:
> The "result" variable isn't initialized on this error path.
>
> Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus")
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Florian Fainelli <[email protected]>

Andrew can you pick this up the same you have you done that before?

> ---
> drivers/vlynq/vlynq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index c0227f9418eb..44d3485d1108 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -727,7 +727,8 @@ static int vlynq_probe(struct platform_device *pdev)
> dev->local_irq = dev->irq_end - dev->irq_start;
> dev->remote_irq = dev->local_irq - 1;
>
> - if (device_register(&dev->dev))
> + result = device_register(&dev->dev);
> + if (result)
> goto fail_register;
> platform_set_drvdata(pdev, dev);
>
>


--
Florian