2017-09-08 08:02:09

by Colin King

Subject: [PATCH] scsi: lpfc: remove redundant null check on eqe

From: Colin Ian King <[email protected]>

The pointer eqe is always non-null inside the while loop, so the
check to see if eqe is NULL is redudant and hence can be removed.

Detected by CoverityScan CID#1248693 ("Logically Dead Code")

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/lpfc/lpfc_sli.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 8b119f87b51d..80036a9fae7f 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -13760,9 +13760,6 @@ lpfc_sli4_hba_intr_handler(int irq, void *dev_id)
* Process all the event on FCP fast-path EQ
*/
while ((eqe = lpfc_sli4_eq_get(fpeq))) {
- if (eqe == NULL)
- break;
-
ccount += lpfc_sli4_hba_handle_eqe(phba, eqe, hba_eqidx);
if (!(++ecount % fpeq->entry_repost) ||
ccount > LPFC_MAX_ISR_CQE)
--
2.14.1

2017-09-14 14:48:04

by James Smart

Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

On 9/8/2017 1:02 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer eqe is always non-null inside the while loop, so the
> check to see if eqe is NULL is redudant and hence can be removed.
>
> Detected by CoverityScan CID#1248693 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <[email protected]>
>

Yep. thank you

Signed-off-by: James Smart <[email protected]>

2017-09-15 19:40:00

by Martin K. Petersen

Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

Colin,

> The pointer eqe is always non-null inside the while loop, so the check
> to see if eqe is NULL is redudant and hence can be removed.

Applied to 4.15/scsi-queue. Thanks!

--
Martin K. Petersen Oracle Linux Engineering