2022-05-22 17:53:03

by Tom Rix

Subject: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter

cppcheck reports
[drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

The functions qla25xx_free_req_que and qla25xx_free_rsp_que are similar.
They free a 'req' and a 'rsp' parameter respectively. The last statement of
both functions is setting the parameter to NULL. This has no effect and
can be removed.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/qla2xxx/qla_mid.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
index e6b5c4ccce97..346d47b61c07 100644
--- a/drivers/scsi/qla2xxx/qla_mid.c
+++ b/drivers/scsi/qla2xxx/qla_mid.c
@@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struct req_que *req)
}
kfree(req->outstanding_cmds);
kfree(req);
- req = NULL;
}

static void
@@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struct rsp_que *rsp)
mutex_unlock(&ha->vport_lock);
}
kfree(rsp);
- rsp = NULL;
}

int
--
2.27.0

2022-05-25 09:05:46

by Himanshu Madhani

Subject: Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter

> On May 21, 2022, at 1:16 PM, Tom Rix <[email protected]> wrote:
>
> cppcheck reports
> [drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
> [drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
>
> The functions qla25xx_free_req_que and qla25xx_free_rsp_que are similar.
> They free a 'req' and a 'rsp' parameter respectively. The last statement of
> both functions is setting the parameter to NULL. This has no effect and
> can be removed.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_mid.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
> index e6b5c4ccce97..346d47b61c07 100644
> --- a/drivers/scsi/qla2xxx/qla_mid.c
> +++ b/drivers/scsi/qla2xxx/qla_mid.c
> @@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struct req_que *req)
> }
> kfree(req->outstanding_cmds);
> kfree(req);
> - req = NULL;
> }
>
> static void
> @@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struct rsp_que *rsp)
> mutex_unlock(&ha->vport_lock);
> }
> kfree(rsp);
> - rsp = NULL;
> }
>
> int
> --
> 2.27.0
>

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2022-06-02 02:50:38

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter

Tom,

> The functions qla25xx_free_req_que and qla25xx_free_rsp_que are
> similar. They free a 'req' and a 'rsp' parameter respectively. The
> last statement of both functions is setting the parameter to NULL.
> This has no effect and can be removed.

Applied to 5.19/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering