2017-06-05 17:30:10

by Colin King

Subject: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt

From: Colin Ian King <[email protected]>

An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove
redundant wait when target is stopped.") removed a null check
on ha->tgt.tgt_ops and replaced it with a new check that null
checked tgt, thus making the subsequent null check on tgt
totally redundant. Remove it.

Detected by CoverityScan, CID#1440452 ("Logically Dead Code")

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/qla2xxx/qla_target.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index cb33ca87ca37..3594a76f6155 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5519,12 +5519,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
if (!tgt || tgt->tgt_stop || tgt->tgt_stopped)
return;

- if (unlikely(tgt == NULL)) {
- ql_dbg(ql_dbg_tgt, vha, 0xe03a,
- "ASYNC EVENT %#x, but no tgt (ha %p)\n", code, ha);
- return;
- }
-
if (((code == MBA_POINT_TO_POINT) || (code == MBA_CHG_IN_CONNECTION)) &&
IS_QLA2100(ha))
return;
--
2.11.0

2017-06-07 22:42:09

by Madhani, Himanshu

Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt

> On Jun 5, 2017, at 10:29 AM, Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove
> redundant wait when target is stopped.") removed a null check
> on ha->tgt.tgt_ops and replaced it with a new check that null
> checked tgt, thus making the subsequent null check on tgt
> totally redundant. Remove it.
>
> Detected by CoverityScan, CID#1440452 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index cb33ca87ca37..3594a76f6155 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -5519,12 +5519,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
> if (!tgt || tgt->tgt_stop || tgt->tgt_stopped)
> return;
>
> - if (unlikely(tgt == NULL)) {
> - ql_dbg(ql_dbg_tgt, vha, 0xe03a,
> - "ASYNC EVENT %#x, but no tgt (ha %p)\n", code, ha);
> - return;
> - }
> -
> if (((code == MBA_POINT_TO_POINT) || (code == MBA_CHG_IN_CONNECTION)) &&
> IS_QLA2100(ha))
> return;
> --
> 2.11.0
>

Looks good.

Acked-by: Himanshu Madhani <[email protected]>

Thanks,
- Himanshu

2017-06-13 01:12:21

by Martin K. Petersen

Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt

Colin,

> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove redundant
> wait when target is stopped.") removed a null check on ha->tgt.tgt_ops
> and replaced it with a new check that null checked tgt, thus making
> the subsequent null check on tgt totally redundant. Remove it.

Applied to 4.13/scsi-queue. Thanks!

--
Martin K. Petersen Oracle Linux Engineering