From: Colin Ian King <[email protected]>
There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.
Detected by CoverityScan, CID#1424402 ("Missing break in switch")
Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 708c601e8ccf..13e65d446ab3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
break;
case OOO_LB_TC:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+ break;
default:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
break;
--
2.11.0
> There seems to be a missing break on the OOO_LB_TC case, pq_id is being
> assigned and then re-assigned on the fall through default case and that
> seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <[email protected]>
Thanks!
Acked-by: Yuval Mintz <[email protected]>
From: Colin King <[email protected]>
Date: Wed, 5 Apr 2017 13:35:44 +0100
> From: Colin Ian King <[email protected]>
>
> There seems to be a missing break on the OOO_LB_TC case, pq_id
> is being assigned and then re-assigned on the fall through default
> case and that seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <[email protected]>
Applied, thanks.